From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/4] fsx: fix strncpy usage error
Date: Sat, 14 Nov 2020 10:42:09 +0000 [thread overview]
Message-ID: <20201114104209.GD11074@infradead.org> (raw)
In-Reply-To: <160505548377.1389938.2367585875193826371.stgit@magnolia>
On Tue, Nov 10, 2020 at 04:44:43PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> We shouldn't feed sizeof() to strncpy as the string length. Just use
> snprintf, which at least doesn't have the zero termination problems.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-11-14 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:44 [PATCH 0/4] xfstests: fix compiler warnings with fsx/fsstress Darrick J. Wong
2020-11-11 0:44 ` [PATCH 1/4] fsx: fix strncpy usage error Darrick J. Wong
2020-11-14 10:42 ` Christoph Hellwig [this message]
2020-11-11 0:44 ` [PATCH 2/4] fsstress: stop using attr_set Darrick J. Wong
2020-11-14 10:45 ` Christoph Hellwig
2020-11-11 0:44 ` [PATCH 3/4] fsstress: remove attr_remove Darrick J. Wong
2020-11-14 10:45 ` Christoph Hellwig
2020-11-11 0:45 ` [PATCH 4/4] fsstress: get rid of attr_list Darrick J. Wong
2020-11-14 10:47 ` Christoph Hellwig
2021-02-11 21:18 ` Darrick J. Wong
2021-02-11 21:22 ` Darrick J. Wong
2020-11-15 9:12 ` [PATCH 0/4] xfstests: fix compiler warnings with fsx/fsstress Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114104209.GD11074@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.