From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
arm@kernel.org, "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andreas Färber" <afaerber@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt
Date: Sat, 14 Nov 2020 17:52:38 +0100 [thread overview]
Message-ID: <20201114175238.7738e082@kernel.org> (raw)
In-Reply-To: <20201114163439.GB1480543@lunn.ch>
On Sat, 14 Nov 2020 17:34:39 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Sat, Nov 14, 2020 at 05:04:06PM +0100, Marek Behún wrote:
> > Describe ethernet-phy interrupt for Turris Omnia so that the PHY does
> > not need to be polled. We also need to describe the PCA9538 as an
> > interrupt controller.
> >
> > Signed-off-by: Marek Behún <kabel@kernel.org>
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
>
> I'm not sure the fixes is justified. This is an optimisation, not a
> fix.
I considered this as a fix in the sense that it should have been there
from the beginning... Although the driver works, the devicetree does not
describe the device correctly without it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
next prev parent reply other threads:[~2020-11-14 16:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:04 [PATCH mvebu-dt 0/6] Turris Omnia device-tree changes Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 1/6] ARM: dts: turris-omnia: enable HW buffer management Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 2/6] ARM: dts: turris-omnia: add comphy handle to eth2 Marek Behún
2020-11-14 16:26 ` Andrew Lunn
2020-11-14 16:04 ` [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt Marek Behún
2020-11-14 16:34 ` Andrew Lunn
2020-11-14 16:52 ` Marek Behún [this message]
2020-11-14 16:40 ` Marek Behún
2020-11-14 16:49 ` Marek Behún
2020-11-14 17:16 ` Andrew Lunn
2020-11-14 17:42 ` Marek Behún
2020-11-14 17:47 ` Marek Behun
2020-11-14 20:16 ` Andrew Lunn
2020-11-14 20:39 ` Marek Behun
2020-11-14 21:20 ` Andreas Färber
2020-11-14 23:32 ` Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 4/6] ARM: dts: turris-omnia: add SFP node Marek Behún
2020-11-14 16:36 ` Andrew Lunn
2020-11-14 16:04 ` [PATCH mvebu-dt 5/6] ARM: dts: turris-omnia: add LED controller node Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 6/6] ARM: dts: turris-omnia: update ethernet-phy node and handle name Marek Behún
2020-11-14 16:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114175238.7738e082@kernel.org \
--to=kabel@kernel.org \
--cc=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.