From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool
Date: Sun, 15 Nov 2020 02:33:47 +0800 [thread overview]
Message-ID: <202011150237.LSGf9lqL-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4244 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Wen Gong <wgong@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1
commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add firmware coredump support
date: 3 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 3 months ago
compiler: nios2-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/net/wireless/ath/ath9k/ar5008_phy.c:0:0: warning: Invalid value: 0xFF000000_S [cppcheckError]
^
drivers/net/wireless/ath/ath9k/ar5008_phy.c:0:0: note: Invalid value: 0xFF000000_S
^
drivers/net/wireless/ath/ath9k/ar5008_phy.c:0:0: note: Invalid value: 0xFF000000_S
^
>> drivers/net/wireless/ath/wcn36xx/smd.c:750:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/net/wireless/ath/wcn36xx/smd.c:745:6: note: first condition
if (ret)
^
drivers/net/wireless/ath/wcn36xx/smd.c:750:9: note: second condition
return ret;
^
drivers/net/wireless/ath/wcn36xx/smd.c:807:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/net/wireless/ath/wcn36xx/smd.c:791:6: note: first condition
if (ret)
^
drivers/net/wireless/ath/wcn36xx/smd.c:807:9: note: second condition
return ret;
^
>> drivers/net/wireless/ath/wcn36xx/smd.c:657:2: warning: Redundant pointer operation on 'msg_body' - it's already a pointer. [redundantPointerOp]
INIT_HAL_MSG((*msg_body), WCN36XX_HAL_START_SCAN_OFFLOAD_REQ);
^
drivers/net/wireless/ath/wcn36xx/smd.c:688:2: warning: Redundant pointer operation on 'msg_body' - it's already a pointer. [redundantPointerOp]
PREPARE_HAL_BUF(wcn->hal_buf, (*msg_body));
^
drivers/net/wireless/ath/wcn36xx/smd.c:1276:2: warning: Redundant pointer operation on 'msg_body' - it's already a pointer. [redundantPointerOp]
INIT_HAL_MSG((*msg_body), WCN36XX_HAL_CONFIG_BSS_REQ);
^
drivers/net/wireless/ath/wcn36xx/smd.c:1364:2: warning: Redundant pointer operation on 'msg_body' - it's already a pointer. [redundantPointerOp]
PREPARE_HAL_BUF(wcn->hal_buf, (*msg_body));
^
>> drivers/net/wireless/ath/wcn36xx/smd.c:1443:2: warning: Redundant pointer operation on 'msg' - it's already a pointer. [redundantPointerOp]
INIT_HAL_MSG((*msg), WCN36XX_HAL_CONFIG_BSS_REQ);
^
drivers/net/wireless/ath/wcn36xx/smd.c:1542:3: warning: Redundant pointer operation on 'msg' - it's already a pointer. [redundantPointerOp]
PREPARE_HAL_BUF(wcn->hal_buf, (*msg));
^
>> drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
^
vim +2234 drivers/net/wireless/ath/ath10k/sdio.c
3c45f21af84eb05 Wen Gong 2020-08-18 2225
3c45f21af84eb05 Wen Gong 2020-08-18 2226 static bool ath10k_sdio_is_fast_dump_supported(struct ath10k *ar)
3c45f21af84eb05 Wen Gong 2020-08-18 2227 {
3c45f21af84eb05 Wen Gong 2020-08-18 2228 u32 param;
3c45f21af84eb05 Wen Gong 2020-08-18 2229
3c45f21af84eb05 Wen Gong 2020-08-18 2230 ath10k_sdio_read_host_interest_value(ar, HI_ITEM(hi_option_flag2), ¶m);
3c45f21af84eb05 Wen Gong 2020-08-18 2231
3c45f21af84eb05 Wen Gong 2020-08-18 2232 ath10k_dbg(ar, ATH10K_DBG_SDIO, "sdio hi_option_flag2 %x\n", param);
3c45f21af84eb05 Wen Gong 2020-08-18 2233
3c45f21af84eb05 Wen Gong 2020-08-18 @2234 return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
3c45f21af84eb05 Wen Gong 2020-08-18 2235 }
3c45f21af84eb05 Wen Gong 2020-08-18 2236
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2020-11-14 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 18:33 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-16 5:53 drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool kernel test robot
2020-11-16 5:53 ` kernel test robot
2020-11-16 7:53 ` Kalle Valo
2020-11-16 7:53 ` Kalle Valo
2020-11-16 7:53 ` Kalle Valo
2020-11-16 9:33 ` Wen Gong
2020-11-16 9:33 ` Wen Gong
2020-11-16 9:33 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011150237.LSGf9lqL-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.