From: Hui Su <sh_def@163.com>
To: christian.brauner@ubuntu.com, serge@hallyn.com,
avagin@openvz.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Cc: sh_def@163.com
Subject: [PATCH] nsproxy: remove judge of timens_on_fork()'s return val
Date: Mon, 16 Nov 2020 02:14:57 +0800 [thread overview]
Message-ID: <20201115181457.GA376527@rlk> (raw)
timens_on_fork() always return 0, and maybe not
need to judge the return value in copy_namespaces().
Signed-off-by: Hui Su <sh_def@163.com>
---
kernel/nsproxy.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
index 12dd41b39a7f..e2e6c5dc433f 100644
--- a/kernel/nsproxy.c
+++ b/kernel/nsproxy.c
@@ -153,7 +153,6 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
struct nsproxy *old_ns = tsk->nsproxy;
struct user_namespace *user_ns = task_cred_xxx(tsk, user_ns);
struct nsproxy *new_ns;
- int ret;
if (likely(!(flags & (CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWIPC |
CLONE_NEWPID | CLONE_NEWNET |
@@ -180,11 +179,7 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
if (IS_ERR(new_ns))
return PTR_ERR(new_ns);
- ret = timens_on_fork(new_ns, tsk);
- if (ret) {
- free_nsproxy(new_ns);
- return ret;
- }
+ timens_on_fork(new_ns, tsk);
tsk->nsproxy = new_ns;
return 0;
--
2.29.0
next reply other threads:[~2020-11-15 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:14 Hui Su [this message]
2020-11-17 8:30 ` [PATCH] nsproxy: remove judge of timens_on_fork()'s return val Andrey Vagin
2020-11-17 15:35 ` Hui Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115181457.GA376527@rlk \
--to=sh_def@163.com \
--cc=avagin@openvz.org \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.