From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55590C4742C for ; Mon, 16 Nov 2020 10:17:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B91216C4 for ; Mon, 16 Nov 2020 10:17:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B91216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FC8689DA6; Mon, 16 Nov 2020 10:17:41 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0781489DA6 for ; Mon, 16 Nov 2020 10:17:40 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CC65B804C8; Mon, 16 Nov 2020 11:17:35 +0100 (CET) Date: Mon, 16 Nov 2020 11:17:34 +0100 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116101734.GA65688@ravnborg.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> <20201116084023.GL3718728@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201116084023.GL3718728@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=-VAfIpHNAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=uGS4jb_diw1687yx55MA:9 a=QEXdDO2ut3YA:10 a=srlwD-8ojaedGGhPAyx8:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGVlLApPbiBNb24sIE5vdiAxNiwgMjAyMCBhdCAwODo0MDoyM0FNICswMDAwLCBMZWUgSm9u ZXMgd3JvdGU6Cj4gT24gU2F0LCAxNCBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+IAo+ ID4gSGkgTGVlLAo+ID4gT24gRnJpLCBOb3YgMTMsIDIwMjAgYXQgMDE6NDk6MTBQTSArMDAwMCwg TGVlIEpvbmVzIHdyb3RlOgo+ID4gPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVp bGQgd2FybmluZyhzKToKPiA+ID4gCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFf ZGlzcGxheS5jOjM1Njo2OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yIOKAmHBs MTExX2Rpc3BsYXlfZGlzYWJsZeKAmSBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gPiA+IAo+ID4g PiBDYzogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiA+ID4gQ2M6IERhdmlkIEFpcmxp ZSA8YWlybGllZEBsaW51eC5pZT4KPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZnds bC5jaD4KPiA+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gU2ln bmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IAo+ID4gRXJp YydzIHdhcyBub3QgY29waWVkIG9uIHRoaXMgb3IgdGhlIG90aGVyIHBsMTExIHBhdGNoLgo+ID4g QWRkZWQgRXJpYyBzbyBoZSBjYW4gYmUgYXdhcmUgb2YgdGhpcyBmaXguCj4gCj4gRXJpYyBBbmhv bHQ/Cj4gCj4gSGUncyBvbiBDYz8KTm90IG9uIHRoZSBvcmlnaW5hbCBtYWlsIEkgcmVjZWl2ZWQu CgoJU2FtCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9550EC4742C for ; Mon, 16 Nov 2020 10:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C61F20782 for ; Mon, 16 Nov 2020 10:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728543AbgKPKRn (ORCPT ); Mon, 16 Nov 2020 05:17:43 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:38108 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbgKPKRm (ORCPT ); Mon, 16 Nov 2020 05:17:42 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CC65B804C8; Mon, 16 Nov 2020 11:17:35 +0100 (CET) Date: Mon, 16 Nov 2020 11:17:34 +0100 From: Sam Ravnborg To: Lee Jones Cc: Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116101734.GA65688@ravnborg.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> <20201116084023.GL3718728@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201116084023.GL3718728@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=-VAfIpHNAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=uGS4jb_diw1687yx55MA:9 a=QEXdDO2ut3YA:10 a=srlwD-8ojaedGGhPAyx8:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote: > On Sat, 14 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > > > Cc: Eric Anholt > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Lee Jones > > > > Eric's was not copied on this or the other pl111 patch. > > Added Eric so he can be aware of this fix. > > Eric Anholt? > > He's on Cc? Not on the original mail I received. Sam