All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: "Jin, Yao" <yao.jin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-kernel <Linux-kernel@vger.kernel.org>,
	"Liang, Kan" <kan.liang@intel.com>,
	"Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Date: Mon, 16 Nov 2020 06:53:55 -0800	[thread overview]
Message-ID: <20201116145355.GU894261@tassilo.jf.intel.com> (raw)
In-Reply-To: <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>

>    I'd prefer if we could make a copy of these scripts into the kernel tree
>    along with the data files from:
>    https://download.01.org/perfmon/

FWIW I originally tried this to include the raw JSON files, but Ingo objected
and wanted the files to be split up[1] and avoiding redundant headers. 
That's why we ended up with the "compiled" format.

[1] https://lkml.org/lkml/2015/5/28/336

>    Having a generated file that can't be edited, reviewed, .. I also worry
>    that if/when we change the json format then event-converter-for-linux-perf
>    will need to support a multitude of perf versions.

You mean for backports? The assumption was that perf backports would backport
any perf changes for new formats too.

In general I generally discourage any perf tools backport, people should just use
a new version of the perf tool on old kernels.

In principle the scripts could be included, but without the raw files it would
be somewhat pointless.

-andi

  parent reply	other threads:[~2020-11-16 14:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  1:51 [PATCH] perf vendor events: Update Skylake client events to v50 Jin Yao
2020-11-06  3:00 ` Namhyung Kim
2020-11-06  3:11   ` Jin, Yao
2020-11-06  4:21     ` Namhyung Kim
2020-11-13  8:12       ` Jin, Yao
2020-11-15 13:35         ` Andi Kleen
     [not found]           ` <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>
2020-11-16  8:07             ` Jin, Yao
2020-11-16 14:53             ` Andi Kleen [this message]
2020-11-16 17:05       ` Arnaldo Carvalho de Melo
     [not found]         ` <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
2020-11-16 19:24           ` Arnaldo Carvalho de Melo
2020-11-16 21:24             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116145355.GU894261@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.