From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it
Date: Mon, 16 Nov 2020 15:02:16 +0000 [thread overview]
Message-ID: <20201116150216.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201116154552.5a1e4b02@kernel.org>
On Mon, Nov 16, 2020 at 03:45:52PM +0100, Marek Behún wrote:
> Hi Russell,
>
> previously you replied on this patch:
>
> > This'll do as a stop-gap until we have a better way to determine which
> > MACTYPE mode we should be using.
>
> Can we consider this as Acked-by ?
Not really.
The selection of MACTYPE isn't as simple as you make out in this patch.
If we know that the MAC supports 2500BASE-X and/or SGMII, that means
MACTYPES 0, 3, 4, 5 are possible to fit that, all likely will work if
we restrict the PHY to either 2.5G only or 1G..10M only. However, it
only becomes important if the faster speeds are supported at the MAC.
I'm afraid I haven't put much thought into how to solve it, and as I'm
totally demotivated at the moment, that's unlikely to change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-11-16 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 11:15 [PATCH net-next v3 0/5] Support for RollBall 10G copper SFP modules Marek Behún
2020-11-16 11:15 ` [PATCH net-next v3 1/5] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall " Marek Behún
2020-11-16 11:15 ` [PATCH net-next v3 2/5] net: phylink: allow attaching phy for SFP modules on 802.3z mode Marek Behún
2020-11-16 11:15 ` [PATCH net-next v3 3/5] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release Marek Behún
2020-11-16 11:15 ` [PATCH net-next v3 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it Marek Behún
2020-11-16 12:18 ` Marek Behún
2020-11-16 14:45 ` Marek Behún
2020-11-16 15:02 ` Russell King - ARM Linux admin [this message]
2020-11-16 15:56 ` Marek Behún
2020-11-16 11:15 ` [PATCH net-next v3 5/5] net: sfp: add support for multigig RollBall transceivers Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116150216.GK1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.