From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27DEAC4742C for ; Mon, 16 Nov 2020 15:53:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB869207BC for ; Mon, 16 Nov 2020 15:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kLVSs+pZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB869207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oJFKSLh/Ap0PJH2GPiIAGtghdKX9Y18v2U6ZWGWrxxw=; b=kLVSs+pZl7I2Y9EZ0ns7eBu8N ogBIbtLYjWWJW0P2gy2Dq8KSp2i1oefdubjduXrHP1uHvGBWOwGG8vF/LBvBYrJcpFGA53RffBY3q yf2o6H4IuZawjUXJVT44joX9ZbP+SVs5KfPqPya6tMpQmDDu4v405I6z2kn5TfOoeqa8hpHastOi6 A8CC1v1t/EPwZ7FLyDV1Awe+KJPRDYsKwBMDFssP0WOOJ57OS2Ia65e4DP7YsDMCS7dbFMK7/My8Z La7SMQZOu9FfKlwYru4S72oVw1oVosPCZa4gMuGBAngxhR9DamjwUMKPARDbUr77DDx6A5yhpLBfa hJMqAO6vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kego9-0002Eb-1I; Mon, 16 Nov 2020 15:52:45 +0000 Received: from outbound-smtp50.blacknight.com ([46.22.136.234]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kego5-0002Ch-HX for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 15:52:42 +0000 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp50.blacknight.com (Postfix) with ESMTPS id 14BF2FB200 for ; Mon, 16 Nov 2020 15:52:36 +0000 (GMT) Received: (qmail 2698 invoked from network); 16 Nov 2020 15:52:35 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 16 Nov 2020 15:52:35 -0000 Date: Mon, 16 Nov 2020 15:52:32 +0000 From: Mel Gorman To: Peter Zijlstra Subject: Re: Loadavg accounting error on arm64 Message-ID: <20201116155232.GS3371@techsingularity.net> References: <20201116091054.GL3371@techsingularity.net> <20201116131102.GA29992@willie-the-truck> <20201116133721.GQ3371@techsingularity.net> <20201116142005.GE3121392@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201116142005.GE3121392@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_105241_685841_1AF03876 X-CRM114-Status: GOOD ( 28.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Davidlohr Bueso , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 16, 2020 at 03:20:05PM +0100, Peter Zijlstra wrote: > > It used to be at least a WRITE_ONCE until 58877d347b58 ("sched: Better > > document ttwu()") which changed it. Not sure why that is and didn't > > think about it too deep as it didn't appear to be directly related to > > the problem and didn't have ordering consequences. > > I'm confused; that commit didn't change deactivate_task(). Anyway, > ->on_rq should be strictly under rq->lock. That said, since there is a > READ_ONCE() consumer of ->on_rq it makes sense to have the stores as > WRITE_ONCE(). > It didn't change deactivate_task but it did this - WRITE_ONCE(p->on_rq, TASK_ON_RQ_MIGRATING); - dequeue_task(rq, p, DEQUEUE_NOCLOCK); + deactivate_task(rq, p, DEQUEUE_NOCLOCK); which makes that write a p->on_rq = (flags & DEQUEUE_SLEEP) ? 0 : TASK_ON_RQ_MIGRATING; As activate_task is also a plain store and I didn't spot a relevant ordering problem that would impact loadavg, I concluded it was not immediately relevant, just a curiousity. > > > __ttwu_queue_wakelist() we have: > > > > > > p->sched_remote_wakeup = !!(wake_flags & WF_MIGRATED); > > > > > > which can be invoked on the try_to_wake_up() path if p->on_rq is first read > > > as zero and then p->on_cpu is read as 1. Perhaps these non-atomic bitfield > > > updates can race and cause the flags to be corrupted? > > > > > > > I think this is at least one possibility. I think at least that one > > should only be explicitly set on WF_MIGRATED and explicitly cleared in > > sched_ttwu_pending. While I haven't audited it fully, it might be enough > > to avoid a double write outside of the rq lock on the bitfield but I > > still need to think more about the ordering of sched_contributes_to_load > > and whether it's ordered by p->on_cpu or not. > > The scenario you're worried about is something like: > > CPU0 CPU1 > > schedule() > prev->sched_contributes_to_load = X; > deactivate_task(prev); > > try_to_wake_up() > if (p->on_rq &&) // false > if (smp_load_acquire(&p->on_cpu) && // true > ttwu_queue_wakelist()) > p->sched_remote_wakeup = Y; > > smp_store_release(prev->on_cpu, 0); > Yes, mostly because of what memory-barriers.txt warns about for bitfields if they are not protected by the same lock. > And then the stores of X and Y clobber one another.. Hummph, seems > reasonable. One quick thing to test would be something like this: > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 7abbdd7f3884..9844e541c94c 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -775,7 +775,9 @@ struct task_struct { > unsigned sched_reset_on_fork:1; > unsigned sched_contributes_to_load:1; > unsigned sched_migrated:1; > + unsigned :0; > unsigned sched_remote_wakeup:1; > + unsigned :0; > #ifdef CONFIG_PSI > unsigned sched_psi_wake_requeue:1; > #endif I'll test this after the smp_wmb() test completes. While a clobbering may be the issue, I also think the gap between the rq->nr_uninterruptible++ and smp_store_release(prev->on_cpu, 0) is relevant and a better candidate. -- Mel Gorman SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E73EC61DD8 for ; Mon, 16 Nov 2020 15:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0370720A8B for ; Mon, 16 Nov 2020 15:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730226AbgKPPwi (ORCPT ); Mon, 16 Nov 2020 10:52:38 -0500 Received: from outbound-smtp38.blacknight.com ([46.22.139.221]:55389 "EHLO outbound-smtp38.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730557AbgKPPwi (ORCPT ); Mon, 16 Nov 2020 10:52:38 -0500 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp38.blacknight.com (Postfix) with ESMTPS id 1ED321F7B for ; Mon, 16 Nov 2020 15:52:36 +0000 (GMT) Received: (qmail 2698 invoked from network); 16 Nov 2020 15:52:35 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 16 Nov 2020 15:52:35 -0000 Date: Mon, 16 Nov 2020 15:52:32 +0000 From: Mel Gorman To: Peter Zijlstra Cc: Will Deacon , Davidlohr Bueso , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Loadavg accounting error on arm64 Message-ID: <20201116155232.GS3371@techsingularity.net> References: <20201116091054.GL3371@techsingularity.net> <20201116131102.GA29992@willie-the-truck> <20201116133721.GQ3371@techsingularity.net> <20201116142005.GE3121392@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20201116142005.GE3121392@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 03:20:05PM +0100, Peter Zijlstra wrote: > > It used to be at least a WRITE_ONCE until 58877d347b58 ("sched: Better > > document ttwu()") which changed it. Not sure why that is and didn't > > think about it too deep as it didn't appear to be directly related to > > the problem and didn't have ordering consequences. > > I'm confused; that commit didn't change deactivate_task(). Anyway, > ->on_rq should be strictly under rq->lock. That said, since there is a > READ_ONCE() consumer of ->on_rq it makes sense to have the stores as > WRITE_ONCE(). > It didn't change deactivate_task but it did this - WRITE_ONCE(p->on_rq, TASK_ON_RQ_MIGRATING); - dequeue_task(rq, p, DEQUEUE_NOCLOCK); + deactivate_task(rq, p, DEQUEUE_NOCLOCK); which makes that write a p->on_rq = (flags & DEQUEUE_SLEEP) ? 0 : TASK_ON_RQ_MIGRATING; As activate_task is also a plain store and I didn't spot a relevant ordering problem that would impact loadavg, I concluded it was not immediately relevant, just a curiousity. > > > __ttwu_queue_wakelist() we have: > > > > > > p->sched_remote_wakeup = !!(wake_flags & WF_MIGRATED); > > > > > > which can be invoked on the try_to_wake_up() path if p->on_rq is first read > > > as zero and then p->on_cpu is read as 1. Perhaps these non-atomic bitfield > > > updates can race and cause the flags to be corrupted? > > > > > > > I think this is at least one possibility. I think at least that one > > should only be explicitly set on WF_MIGRATED and explicitly cleared in > > sched_ttwu_pending. While I haven't audited it fully, it might be enough > > to avoid a double write outside of the rq lock on the bitfield but I > > still need to think more about the ordering of sched_contributes_to_load > > and whether it's ordered by p->on_cpu or not. > > The scenario you're worried about is something like: > > CPU0 CPU1 > > schedule() > prev->sched_contributes_to_load = X; > deactivate_task(prev); > > try_to_wake_up() > if (p->on_rq &&) // false > if (smp_load_acquire(&p->on_cpu) && // true > ttwu_queue_wakelist()) > p->sched_remote_wakeup = Y; > > smp_store_release(prev->on_cpu, 0); > Yes, mostly because of what memory-barriers.txt warns about for bitfields if they are not protected by the same lock. > And then the stores of X and Y clobber one another.. Hummph, seems > reasonable. One quick thing to test would be something like this: > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 7abbdd7f3884..9844e541c94c 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -775,7 +775,9 @@ struct task_struct { > unsigned sched_reset_on_fork:1; > unsigned sched_contributes_to_load:1; > unsigned sched_migrated:1; > + unsigned :0; > unsigned sched_remote_wakeup:1; > + unsigned :0; > #ifdef CONFIG_PSI > unsigned sched_psi_wake_requeue:1; > #endif I'll test this after the smp_wmb() test completes. While a clobbering may be the issue, I also think the gap between the rq->nr_uninterruptible++ and smp_store_release(prev->on_cpu, 0) is relevant and a better candidate. -- Mel Gorman SUSE Labs