Re: [PATCH] rtc: mxc: Remove unused .id_table support

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

Hello,

On 16/11/2020 12:43:03-0300, Fabio Estevam wrote:
> Since 5.10-rc1 i.MX is a devicetree-only platform and the existing
> .id_table support in this driver was only useful for old non-devicetree
> platforms.
> 
> Get rid of the .id_table since it is no longer used.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/rtc/rtc-mxc.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
> index a8cfbde048f4..78d7fba00895 100644
> --- a/drivers/rtc/rtc-mxc.c
> +++ b/drivers/rtc/rtc-mxc.c
> @@ -70,19 +70,6 @@ struct rtc_plat_data {
>  	enum imx_rtc_type devtype;
>  };
>  
> -static const struct platform_device_id imx_rtc_devtype[] = {
> -	{
> -		.name = "imx1-rtc",
> -		.driver_data = IMX1_RTC,
> -	}, {
> -		.name = "imx21-rtc",
> -		.driver_data = IMX21_RTC,
> -	}, {
> -		/* sentinel */
> -	}
> -};
> -MODULE_DEVICE_TABLE(platform, imx_rtc_devtype);
> -
>  #ifdef CONFIG_OF

Is this #ifdef still necessary?

>  static const struct of_device_id imx_rtc_dt_ids[] = {
>  	{ .compatible = "fsl,imx1-rtc", .data = (const void *)IMX1_RTC },
> @@ -438,7 +425,6 @@ static struct platform_driver mxc_rtc_driver = {
>  		   .name	= "mxc_rtc",
>  		   .of_match_table = of_match_ptr(imx_rtc_dt_ids),
>  	},
> -	.id_table = imx_rtc_devtype,
>  	.probe = mxc_rtc_probe,
>  };
>  
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com