From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A413C2D0E4 for ; Tue, 17 Nov 2020 07:38:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A031724656 for ; Tue, 17 Nov 2020 07:38:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MNQfqLQn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A031724656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10C4A1742; Tue, 17 Nov 2020 08:38:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10C4A1742 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605598735; bh=4lIS54VdGuqsiQB1gaz1o21sUiH6v8Utz8nnKKLAbCo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MNQfqLQntAWqRR6VVFtYjnbmAiyYrUEtrDxBQct159sSGAl1fhvixqWS8VBmQqLOc S1oknqzx5nm/Z/SzCxdWv7DTilUWpeizyz7FZrOAnOV6rejNqWojsAAvaG0xCHxTXL aEJRr8uPAp9AV9V/6qtzLKlC8628dJVj7M26Bs8k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 824AEF801ED; Tue, 17 Nov 2020 08:38:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 05801F801F5; Tue, 17 Nov 2020 08:38:02 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D6B96F800FE for ; Tue, 17 Nov 2020 08:37:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D6B96F800FE Received: by mail-wm1-f67.google.com with SMTP id 19so2276164wmf.1 for ; Mon, 16 Nov 2020 23:37:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=18xGlNNpDhvVYVdS8rF0z2fNATOQumPp5b7l5cZcXvw=; b=K1kin1o9dk45aq/uxQU+DD6vI4VZJnJCXduK9CR2tatPbjGRjiGtnJWhlbboUK7kKK sMAEmdtagAMu25G6Di1ujW3iTj6DwolULXKmF5UrABbNzhqBywrs6B2OfdygYfAzSxlH WBnThWV4J+JF29zWAjaw1gn3aguaTVkQo83O5ttfR3H0Qwjgi5k+rVLas5Gz+9wlreb8 ZS3zGghN3nhZhXI/X2auZl9Tw7bUTup2JOV2aamfwvqiO5pxEraSBcWc5JNIxuSVIcjN /GDRx2pIgmlEMlkb6WPeRp4HMO3zE4v/HnuBPmE+Nm7s6w1rZuNi0iKKlTVmAmOqllZl KQ4A== X-Gm-Message-State: AOAM530eyLgsmFN3jb2yPndmAN5Xv401X7Eq77F6zxVgywvg++4hM4oV iuWAQnOpAZ6o+24fWghG7q4= X-Google-Smtp-Source: ABdhPJyHbqmcdYgBsSt4If51dziBJ4uOp+0GJRgB5sF5O5WZ7vgFMBLSfMpTds+fFwooZbU/Vhir4w== X-Received: by 2002:a1c:7704:: with SMTP id t4mr2234501wmi.48.1605598666215; Mon, 16 Nov 2020 23:37:46 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t23sm2151117wmn.4.2020.11.16.23.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 23:37:44 -0800 (PST) Date: Tue, 17 Nov 2020 08:37:43 +0100 From: Krzysztof Kozlowski To: Samuel Holland Subject: Re: [RFC 2/3] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201117073743.GB3436@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Cc: devel@driverdev.osuosl.org, Jernej Skrabec , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Takashi Iwai , Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , Mark Brown , Sakari Ailus , Mauro Carvalho Chehab , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Nov 16, 2020 at 10:36:12PM -0600, Samuel Holland wrote: > On 11/15/20 11:09 AM, Krzysztof Kozlowski wrote: > > COMMON_CLK is a user-selectable option with its own dependencies. The > > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > > should not select COMMON_CLK because they will create a dependency cycle > > and build failures. For example on MIPS a configuration with COMMON_CLK > > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > > SOC_RT305X) is possible: > > Ah, that makes sense. > > > > > WARNING: unmet direct dependencies detected for COMMON_CLK > > Depends on [n]: !HAVE_LEGACY_CLK [=y] > > Selected by [y]: > > - SND_SUN8I_CODEC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && > > (ARCH_SUNXI || COMPILE_TEST [=y]) && OF [=y] && (MACH_SUN8I || ARM64 && ARCH_SUNXI || COMPILE_TEST [=y]) > > > > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_rate': > > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/ralink/clk.o:(.text+0x88): first defined here > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/mach-sunxi/Kconfig | 1 + > > sound/soc/sunxi/Kconfig | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index eeadb1a4dcfe..4d9f9b6d329d 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -4,6 +4,7 @@ menuconfig ARCH_SUNXI > > depends on ARCH_MULTI_V5 || ARCH_MULTI_V7 > > select ARCH_HAS_RESET_CONTROLLER > > select CLKSRC_MMIO > > + select COMMON_CLK > > This is not necessary, since ARCH_SUNXI depends (through ARCH_MULTI_V{5,7}) on > ARCH_MULTIPLATFORM, which selects COMMON_CLK already. Thanks. I'll send a v2 with changes and your review. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F07C63798 for ; Tue, 17 Nov 2020 07:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 808AA24695 for ; Tue, 17 Nov 2020 07:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbgKQHht (ORCPT ); Tue, 17 Nov 2020 02:37:49 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40552 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgKQHhs (ORCPT ); Tue, 17 Nov 2020 02:37:48 -0500 Received: by mail-wm1-f68.google.com with SMTP id a3so2252983wmb.5; Mon, 16 Nov 2020 23:37:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=18xGlNNpDhvVYVdS8rF0z2fNATOQumPp5b7l5cZcXvw=; b=CSNmmPC7k6ZZOHklso9+ocCSYl0FCaFqkP3EFEnfNpIPkoqZw2ltXaAg3mVcNgAEnU TPTmEdR2btv2XIW6Fkk6Ms+UMSlEFoTf1ZAahGUhnzew09XIPQkLUAt4rfYFBjb8p7Ys aE45GumT3HngdvhYE/Yq8PRnA4CRTsx10o/ej7065Bp9MlsI6QNEe5XM9AZYJ8sPpj/S LFxyCz3H1nKovjQ8+L9Ohg8GiWfeUzgje/yXLYmZhbzxJdbQa1XndxNCJN307l2hwEwJ 1Pyfy0qZm7OimuoW2lP+6dY0RKWbpZltQQjO3h+WK1Wy0cyq91ZcJUoucRKhudHQU8Yt 7zyA== X-Gm-Message-State: AOAM533iXoLvPf1T8zdP1/h0LyBBn2ftN4rJj9Ft+MeeK+XWkPDjQFVm UWVdbsCnHMBau3oqMNdQdtk= X-Google-Smtp-Source: ABdhPJyHbqmcdYgBsSt4If51dziBJ4uOp+0GJRgB5sF5O5WZ7vgFMBLSfMpTds+fFwooZbU/Vhir4w== X-Received: by 2002:a1c:7704:: with SMTP id t4mr2234501wmi.48.1605598666215; Mon, 16 Nov 2020 23:37:46 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t23sm2151117wmn.4.2020.11.16.23.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 23:37:44 -0800 (PST) Date: Tue, 17 Nov 2020 08:37:43 +0100 From: Krzysztof Kozlowski To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org Subject: Re: [RFC 2/3] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201117073743.GB3436@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, Nov 16, 2020 at 10:36:12PM -0600, Samuel Holland wrote: > On 11/15/20 11:09 AM, Krzysztof Kozlowski wrote: > > COMMON_CLK is a user-selectable option with its own dependencies. The > > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > > should not select COMMON_CLK because they will create a dependency cycle > > and build failures. For example on MIPS a configuration with COMMON_CLK > > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > > SOC_RT305X) is possible: > > Ah, that makes sense. > > > > > WARNING: unmet direct dependencies detected for COMMON_CLK > > Depends on [n]: !HAVE_LEGACY_CLK [=y] > > Selected by [y]: > > - SND_SUN8I_CODEC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && > > (ARCH_SUNXI || COMPILE_TEST [=y]) && OF [=y] && (MACH_SUN8I || ARM64 && ARCH_SUNXI || COMPILE_TEST [=y]) > > > > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_rate': > > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/ralink/clk.o:(.text+0x88): first defined here > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/mach-sunxi/Kconfig | 1 + > > sound/soc/sunxi/Kconfig | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index eeadb1a4dcfe..4d9f9b6d329d 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -4,6 +4,7 @@ menuconfig ARCH_SUNXI > > depends on ARCH_MULTI_V5 || ARCH_MULTI_V7 > > select ARCH_HAS_RESET_CONTROLLER > > select CLKSRC_MMIO > > + select COMMON_CLK > > This is not necessary, since ARCH_SUNXI depends (through ARCH_MULTI_V{5,7}) on > ARCH_MULTIPLATFORM, which selects COMMON_CLK already. Thanks. I'll send a v2 with changes and your review. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CAD9C2D0E4 for ; Tue, 17 Nov 2020 07:38:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 910BF2463C for ; Tue, 17 Nov 2020 07:38:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gjAA3wsQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 910BF2463C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aHS86Z8vmozeGkA5fmh1mV6JIc8ZLf0FfmpgBmX7cxY=; b=gjAA3wsQNgCZC1hyE7Edz0IFb tGIcjLtPIhJKgCvTqAMubZ95GgbNBBtLKvrrhmdnnZ1wKvj29Gyk+AkjrbS0rL+xS9XpRuGwuDKDW 2F0Xve+A04ZbaVPp4kAXzx+O/dezQnJ4a+25Mhwo/v+KYRquDxqsSsWz4kHWCPp4ouMNeWN1g1chH uVkC4kF6VlV8pdioca14HVslAy2nYu6X9YuF6hQPX3yKRB9TVlFLZoSEwbyuTypkCi+L6ZeKRZtMV dIjXqR8KEVVvCionnF/hC0J9u7HzChafCPGGj1b53fUo1e/oNDe5wS1TaKERTbVUWwKBGhMiRkRa0 I+HPBTGgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kevYj-0003ih-Ck; Tue, 17 Nov 2020 07:37:49 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kevYh-0003i2-5T for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 07:37:47 +0000 Received: by mail-wm1-f66.google.com with SMTP id s13so2264194wmh.4 for ; Mon, 16 Nov 2020 23:37:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=18xGlNNpDhvVYVdS8rF0z2fNATOQumPp5b7l5cZcXvw=; b=Ui8ZC1PsXWMSiKebHtCiAk2/CwWLbOzO9hnOqe1iC9om+k+qUMK+tmUQ+OFMbj749a 6E44KLV9YX1YvNK/GWNd4BoEo3Qn8zPVuqDLU83jEFLfmVdmJwMcYwdXPQJPwnlWDsI/ eaz5zAQ7Icc1qhYg5pw1sREasAKas3cb0LjeTMgce5y9h1iWekwana7Hv8lgd04gD/3t RM7dEn3IBmJaS9wc/v8IhIAwmoCodZCpAg+lp1+HqeA8P46C0gupo/t+YHFNXBjQuIbz TJXRT5XaW1+BXXHTV7Hz9E+5Vx09ebuG2d8XWluhWB8CoSyswlT8dWCvttjOThrQz+0+ mTXw== X-Gm-Message-State: AOAM5322xRRhi1w3II2/d3k5DnYc0YkLVi2BmXGUmpdDWnOe4pDyT7WK dsbfmOUSyAjiRHcJcd4wbX0= X-Google-Smtp-Source: ABdhPJyHbqmcdYgBsSt4If51dziBJ4uOp+0GJRgB5sF5O5WZ7vgFMBLSfMpTds+fFwooZbU/Vhir4w== X-Received: by 2002:a1c:7704:: with SMTP id t4mr2234501wmi.48.1605598666215; Mon, 16 Nov 2020 23:37:46 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t23sm2151117wmn.4.2020.11.16.23.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 23:37:44 -0800 (PST) Date: Tue, 17 Nov 2020 08:37:43 +0100 From: Krzysztof Kozlowski To: Samuel Holland Subject: Re: [RFC 2/3] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201117073743.GB3436@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_023747_227844_B11D10D2 X-CRM114-Status: GOOD ( 22.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jernej Skrabec , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Mark Brown , Sakari Ailus , Mauro Carvalho Chehab , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 16, 2020 at 10:36:12PM -0600, Samuel Holland wrote: > On 11/15/20 11:09 AM, Krzysztof Kozlowski wrote: > > COMMON_CLK is a user-selectable option with its own dependencies. The > > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > > should not select COMMON_CLK because they will create a dependency cycle > > and build failures. For example on MIPS a configuration with COMMON_CLK > > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > > SOC_RT305X) is possible: > > Ah, that makes sense. > > > > > WARNING: unmet direct dependencies detected for COMMON_CLK > > Depends on [n]: !HAVE_LEGACY_CLK [=y] > > Selected by [y]: > > - SND_SUN8I_CODEC [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && > > (ARCH_SUNXI || COMPILE_TEST [=y]) && OF [=y] && (MACH_SUN8I || ARM64 && ARCH_SUNXI || COMPILE_TEST [=y]) > > > > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_rate': > > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/ralink/clk.o:(.text+0x88): first defined here > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/mach-sunxi/Kconfig | 1 + > > sound/soc/sunxi/Kconfig | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > > index eeadb1a4dcfe..4d9f9b6d329d 100644 > > --- a/arch/arm/mach-sunxi/Kconfig > > +++ b/arch/arm/mach-sunxi/Kconfig > > @@ -4,6 +4,7 @@ menuconfig ARCH_SUNXI > > depends on ARCH_MULTI_V5 || ARCH_MULTI_V7 > > select ARCH_HAS_RESET_CONTROLLER > > select CLKSRC_MMIO > > + select COMMON_CLK > > This is not necessary, since ARCH_SUNXI depends (through ARCH_MULTI_V{5,7}) on > ARCH_MULTIPLATFORM, which selects COMMON_CLK already. Thanks. I'll send a v2 with changes and your review. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel