From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC32C2D0E4 for ; Tue, 17 Nov 2020 08:30:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FCD024655 for ; Tue, 17 Nov 2020 08:30:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ouKgk1ya" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FCD024655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60C196E12C; Tue, 17 Nov 2020 08:30:00 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id D927E6E12C for ; Tue, 17 Nov 2020 08:29:58 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id h2so2401019wmm.0 for ; Tue, 17 Nov 2020 00:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0AoYHW7lMZzkTQ6BnvkiA74s9JiSHbIiy02gKpfefxk=; b=ouKgk1yasb8tfHmx4anuX+qm2kqIPUj4/8c6jf4bkP4LeF8hOAvtGE5WWDQ65ml129 5YMClxsCnewFUtABCONGd/7eKMO8g3PiQ2HohthbTvxswPTMcDHfLEL74D9m0CrkFybr gOx9fKxx1G+L2v/9x109RHOMtbc3oJrwlrHhRCJxMJ7H8RRB5XTdzrGFz0YEBvWXeqQf /uFQItOjN4UEbjdZltBmKVkBR/Y9/cwCWMdOpecekpZ4yyhYQKDNlOg6tK3Y0xENxPOX bGyHTV4zLQ5SMeA7PrCG7lpTopRg9YGWRN9EDgIq2P37DduwtmnXsMMl9wrZZCd57g3I QE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0AoYHW7lMZzkTQ6BnvkiA74s9JiSHbIiy02gKpfefxk=; b=bmyv5VRUJcdkcaQ8DTCBmt0r33cZS8pVvZBZdJr8UsVvR0rRzTwScSL4A2+MwomQYe 5VMPaOoefLiZlzJ9z9DoPuvdGckIUKhK2soSVQRBqZ0zyXJqGoSX9xkypuw30fmyzzxv HdgIrq4ZHLgwjjXsIv1JW6OLErBsUGKjgYDJb++z1G29eFQsTXhAKJn+cLRpNzyIcNqx SCHiRiQvy0Xyi/UAck153cL4HPPQwQIijUSXlKfSpYVgk4rw+1paHyK8xx9fdirxazy+ iZUzJH0pJOPCY/dZGG0oqAn0KYgOgm1rIhVvxP15c4Xj8xHmcUJR40pWNL596UKLG0u7 PDBg== X-Gm-Message-State: AOAM531GmQBTBjj8CDb3iy6q74zWoH/WTrYxPTNXq7HFMu5JYJn1ToXG Ic6snxWRIrXK1bVtQ8nWEDEZJA== X-Google-Smtp-Source: ABdhPJw8DTAOsUr5WU8Vpd+v0a+yBmTCtwLVBO7SW0hLGXW07nvSR0O4uxCMpwl6vZZg8UEpdLJJzQ== X-Received: by 2002:a1c:bac1:: with SMTP id k184mr2938223wmf.76.1605601797569; Tue, 17 Nov 2020 00:29:57 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t74sm2523552wmt.8.2020.11.17.00.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 00:29:56 -0800 (PST) Date: Tue, 17 Nov 2020 08:29:55 +0000 From: Lee Jones To: Lyude Paul Subject: Re: [PATCH 29/42] drm/selftests/test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201117082955.GA1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-30-lee.jones@linaro.org> <2dad68f011c7cd8a7c3754457c192f9dc2f504ed.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2dad68f011c7cd8a7c3754457c192f9dc2f504ed.camel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAxNiBOb3YgMjAyMCwgTHl1ZGUgUGF1bCB3cm90ZToKCj4gSHVoLWNvdWxkIGhhdmUg c3dvcm4gSSBoYWQgcmV2aWV3ZWQgdGhpcyBvbmUgYWxyZWFkeS4KPiAKPiBSZXZpZXdlZC1ieTog THl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KClllcywgeW91J3JlIHJpZ2h0LgoKSXQgd2Fz IG1hc2tlZCBieSB0aGUgZGlzY3Vzc2lvbiB3aXRoIFZpbGxlLiAgQXBvbG9naWVzLgoKPiBPbiBN b24sIDIwMjAtMTEtMTYgYXQgMTc6NDAgKzAwMDAsIExlZSBKb25lcyB3cm90ZTpWCj4gPiBUaGUg c3RhY2sgaXMgdG9vIGZ1bGwuCj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5l bCBidWlsZCB3YXJuaW5nKHMpOgo+ID4gCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMv dGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jOiBJbiBmdW5jdGlvbgo+ID4g4oCYc2lkZWJhbmRfbXNn X3JlcV9lbmNvZGVfZGVjb2Rl4oCZOgo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rl c3QtZHJtX2RwX21zdF9oZWxwZXIuYzoxNjE6MTogd2FybmluZzogdGhlCj4gPiBmcmFtZSBzaXpl IG9mIDExNzYgYnl0ZXMgaXMgbGFyZ2VyIHRoYW4gMTAyNCBieXRlcyBbLVdmcmFtZS1sYXJnZXIt dGhhbj1dCj4gPiAKPiA+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiBD YzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+ID4gQ2M6IEx5dWRlIFBhdWwgPGx5 dWRlQHJlZGhhdC5jb20+Cj4gPiBDYzogRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQu Y29tPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IFNpZ25lZC1v ZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+IMKgLi4u L2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jwqDCoMKgIHwgMzEgKysrKysr KysrKysrLS0tLS0tLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTEg ZGVsZXRpb25zKC0pCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwg TGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0 d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxv ZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D05C4C2D0E4 for ; Tue, 17 Nov 2020 08:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 716FF24655 for ; Tue, 17 Nov 2020 08:30:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ouKgk1ya" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726251AbgKQI37 (ORCPT ); Tue, 17 Nov 2020 03:29:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgKQI37 (ORCPT ); Tue, 17 Nov 2020 03:29:59 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4483C0613CF for ; Tue, 17 Nov 2020 00:29:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h21so2396091wmb.2 for ; Tue, 17 Nov 2020 00:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0AoYHW7lMZzkTQ6BnvkiA74s9JiSHbIiy02gKpfefxk=; b=ouKgk1yasb8tfHmx4anuX+qm2kqIPUj4/8c6jf4bkP4LeF8hOAvtGE5WWDQ65ml129 5YMClxsCnewFUtABCONGd/7eKMO8g3PiQ2HohthbTvxswPTMcDHfLEL74D9m0CrkFybr gOx9fKxx1G+L2v/9x109RHOMtbc3oJrwlrHhRCJxMJ7H8RRB5XTdzrGFz0YEBvWXeqQf /uFQItOjN4UEbjdZltBmKVkBR/Y9/cwCWMdOpecekpZ4yyhYQKDNlOg6tK3Y0xENxPOX bGyHTV4zLQ5SMeA7PrCG7lpTopRg9YGWRN9EDgIq2P37DduwtmnXsMMl9wrZZCd57g3I QE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0AoYHW7lMZzkTQ6BnvkiA74s9JiSHbIiy02gKpfefxk=; b=OfyoX656CB2vLoSoHT5g4N/YrHlAenhpAlKrTWtJ09Dmone2Dy8Ib/erfq8lQPwpQn /oJzPnpz1V4viwCfB0zNtgMQb4KkwfaqOvp1+tX+elGENdt1+A3J+LMbheQr3LGSmfFP GvypFS28kXzF7w1/GZzQdiUSd6f+/3n49H9u6UgfOY1KSovrIEEesBgIW5VFsUEDgCxS /TjRARCiDnTNd/iYEBB6WvsfDzFWsNHxWqqtf8x4+XF75x9d+cxL1+3NiDUXdJ0yt/q5 WGyaxDQs1GRFzQbdK7lqQrns+JCpScq6i+q89af7hWD+GRNKRuflERGuszRvoLHhH660 vITg== X-Gm-Message-State: AOAM531qJh/kZq2H4H3q3WmzO14ER5HvlFb+MEDReFfwkP4Pibjos1Ol I9iKkxdIJU+VbAZJ7sDJrHk5gw== X-Google-Smtp-Source: ABdhPJw8DTAOsUr5WU8Vpd+v0a+yBmTCtwLVBO7SW0hLGXW07nvSR0O4uxCMpwl6vZZg8UEpdLJJzQ== X-Received: by 2002:a1c:bac1:: with SMTP id k184mr2938223wmf.76.1605601797569; Tue, 17 Nov 2020 00:29:57 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t74sm2523552wmt.8.2020.11.17.00.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 00:29:56 -0800 (PST) Date: Tue, 17 Nov 2020 08:29:55 +0000 From: Lee Jones To: Lyude Paul Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , David Francis , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 29/42] drm/selftests/test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201117082955.GA1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-30-lee.jones@linaro.org> <2dad68f011c7cd8a7c3754457c192f9dc2f504ed.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2dad68f011c7cd8a7c3754457c192f9dc2f504ed.camel@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2020, Lyude Paul wrote: > Huh-could have sworn I had reviewed this one already. > > Reviewed-by: Lyude Paul Yes, you're right. It was masked by the discussion with Ville. Apologies. > On Mon, 2020-11-16 at 17:40 +0000, Lee Jones wrote:V > > The stack is too full. > > > > Fixes the following W=1 kernel build warning(s): > > > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function > > ‘sideband_msg_req_encode_decode’: > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the > > frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Lyude Paul > > Cc: David Francis > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > --- > >  .../drm/selftests/test-drm_dp_mst_helper.c    | 31 ++++++++++++------- > >  1 file changed, 20 insertions(+), 11 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog