From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion
Date: Tue, 17 Nov 2020 10:13:56 +0100 [thread overview]
Message-ID: <20201117091356.GA7572@alpha.franken.de> (raw)
In-Reply-To: <20201117080518.GH370813@kernel.org>
On Tue, Nov 17, 2020 at 10:05:18AM +0200, Mike Rapoport wrote:
> On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote:
> > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote:
> > > The loop over all memblocks works with PFN numbers and not physical
> > > addresses, so we need for_each_mem_pfn_range().
> >
> > Great catch! Don't know how that has been working so far. Anyway
>
> The loop is relevant only for systems with highmem, apparently there are
> not many highmem users out there.
I found the bug on a SGI IP22 probably because PHYS_OFFSET is != 0.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-11-17 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:45 [PATCH] MIPS: kernel: Fix for_each_memblock conversion Thomas Bogendoerfer
2020-11-16 18:49 ` Mike Rapoport
2020-11-16 20:05 ` Serge Semin
2020-11-17 8:05 ` Mike Rapoport
2020-11-17 9:12 ` Serge Semin
2020-11-17 9:13 ` Thomas Bogendoerfer [this message]
2020-11-17 11:47 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117091356.GA7572@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=akpm@linux-foundation.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.