From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123F6C56202 for ; Tue, 17 Nov 2020 11:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B36A8207BC for ; Tue, 17 Nov 2020 11:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727960AbgKQLH3 (ORCPT ); Tue, 17 Nov 2020 06:07:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbgKQLH3 (ORCPT ); Tue, 17 Nov 2020 06:07:29 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5F17C0613CF for ; Tue, 17 Nov 2020 03:07:28 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1keypZ-0004AU-CE; Tue, 17 Nov 2020 12:07:25 +0100 Date: Tue, 17 Nov 2020 12:07:25 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] ebtables: Fix for broken chain renaming Message-ID: <20201117110725.GH22792@breakpoint.cc> References: <20201117105114.5083-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117105114.5083-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > Loading extensions pollutes 'errno' value, hence before using it to > indicate failure it should be sanitized. This was done by the called > function before the parsing/netlink split and not migrated by accident. > Move it into calling code to clarify the connection. > > Fixes: a7f1e208cdf9c ("nft: split parsing from netlink commands") > Signed-off-by: Phil Sutter Heh. Thanks for adding a test -- LGTM, feel free to push this.