From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9CEC56202 for ; Tue, 17 Nov 2020 11:08:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1BC6207BC for ; Tue, 17 Nov 2020 11:08:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wm7D0wAE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1BC6207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F250989F27; Tue, 17 Nov 2020 11:08:11 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9EF589F27 for ; Tue, 17 Nov 2020 11:08:10 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id s8so22722553wrw.10 for ; Tue, 17 Nov 2020 03:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=n6eCU59I1t0nmoUX/JMABtcH5UW5JkFeV2XR6hvO1PI=; b=wm7D0wAEo/rWM9cDVPNP5RJ17YGDvBs3Tv2wZAk+20keQeqxp782e2psf5adEkIAJw sBzqmKCyhVS9E/+1ZFLwEgN3IGBwv06ht4IKnvs3OdAZ/BSIrESIv6+YNUhFSivZUN3g bHTUf04wf+adxGk6uiLU0VYv/h2+FF9fe1ba7+XebaHBxy+Fwklt8xJiqTkqh/rgccdz 6mvX0bJM9e0n3niU4ktFpOUEYcqJZuH1a5cjr8asHLStTp15n0noMZqXMOwpawMzLk34 UHtHlyUEZlJTjy0VxYitue+UMwBcb7116/uy9rSHCJ7jaNkAygkvzsjFAdahI5uualMJ teFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=n6eCU59I1t0nmoUX/JMABtcH5UW5JkFeV2XR6hvO1PI=; b=AnLlcldtIVZd+LSroMvzw3dWjkKzU5gwUePgqgPrqaR/LS7uaszKpyeCWTvdaw8utM 40DylTX0i5Nsn/ndWgLVlIn6Mh6AnEwcwEWeKEYVNe7T6dT6Yu+oubWLG/LtOw7FvU3F C62eoH7+uxwCbidKZLoNm/njc78jWb+g7oZQkND0Ks1sFYIWaoSp4lDlXXjiOBPXagwu 84QbRMqoUZFwwHCxuwMspUWmYlTGtOo62pJRFPw26IWpFhbg4/iCuirWcALGf6DwVsSO Kl78IPMO89T6LGDFxptcIzZ1yNSNiQKsFvCWoZ27ZctMP0/hpTIfLKF2GWeDsEkYCT1I 2Ufg== X-Gm-Message-State: AOAM530M1vy0d6GlyVYOfjXzVkcH3ECKcvOqeXHhHA5Zsw0s5TWdPa+Q a/6PWFZWzwpz0Wnj8XDASxNNhYB0SBl26qgD X-Google-Smtp-Source: ABdhPJyt5w/xfOns8zFWyU7ejsnKVtooG6J4Era6ZK54EsNK4dAphhyhJTCzhXH1vwllX5WPUSGCyQ== X-Received: by 2002:adf:d0c8:: with SMTP id z8mr25144803wrh.288.1605611289487; Tue, 17 Nov 2020 03:08:09 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm2919301wmf.35.2020.11.17.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:08:08 -0800 (PST) Date: Tue, 17 Nov 2020 11:08:07 +0000 From: Lee Jones To: Sam Ravnborg , David Airlie , Thomas Zimmermann , Linux Kernel Mailing List , dri-devel , Daniel Vetter Subject: Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Message-ID: <20201117110807.GG1869941@dell> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-3-lee.jones@linaro.org> <20201112202516.GA3340631@ravnborg.org> <20201113204959.GW401619@phenom.ffwll.local> <20201117100509.GJ401619@phenom.ffwll.local> <20201117103404.GF1869941@dell> <20201117104311.GK401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201117104311.GK401619@phenom.ffwll.local> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAxNyBOb3YgMjAyMCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gVHVlLCBOb3Yg MTcsIDIwMjAgYXQgMTA6MzQ6MDRBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gRGFuaWVs LAo+ID4gCj4gPiBGb3Igc29tZSByZWFzb24sIHlvdSdyZSBub3QgYXBwZWFyaW5nIGluIHRoZSBy ZWNpcGVudHMgbGlzdCB3aGVuIEkKPiA+IHJlcGx5IHRvIGFsbC4gIFlvdSdyZSBub3QgaW4gdGhl IE1haWwtRm9sbG93dXAtVG8gaGVhZGVyLiAgQW55IGlkZWEKPiA+IHdoeSB0aGlzIG1pZ2h0IGJl Pwo+IAo+IE5vIGlkZWEgZWl0aGVyLCBjb3VsZCBiZSBteSBtdXR0IG5vdCBzZXR0aW5nIHRoZSBy ZXBseSBoZWFkZXJzIGxpa2UgaXQKPiBzaG91bGQuIEknbSBnZW5lcmFsbHkgY29uZnVzZWQgd2l0 aCBob3cgZW1haWwgd29ya3MgLi4uCgpZZXMsIGVtYWlsIGlzIGEgbXlzdGVyeSEKCj4gPiBBbnl3 YXksIHBsZWFzZSBzZWUgYmVsb3c6Cj4gPiAKPiA+IE9uIFR1ZSwgMTcgTm92IDIwMjAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgTm92IDEzLCAyMDIwIGF0IDEwOjAxOjU3UE0g KzAwMDAsIExlZSBKb25lcyB3cm90ZToKPiA+ID4gPiBPbiBGcmksIDEzIE5vdiAyMDIwLCAyMToz MSBEYW5pZWwgVmV0dGVyLCA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+ID4gPiAKPiA+ID4g PiA+IE9uIEZyaSwgTm92IDEzLCAyMDIwIGF0IDk6NTMgUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNA bGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+IE9uIEZyaSwgMTMgTm92IDIwMjAsIDIwOjUwIERhbmllbCBWZXR0ZXIsIDxkYW5p ZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4gPiA+ID4gPj4KPiA+ID4gPiA+ID4+IE9uIFRodSwgTm92 IDEyLCAyMDIwIGF0IDA5OjI1OjE2UE0gKzAxMDAsIFNhbSBSYXZuYm9yZyB3cm90ZToKPiA+ID4g PiA+ID4+ID4gSGkgTGVlLAo+ID4gPiA+ID4gPj4gPgo+ID4gPiA+ID4gPj4gPiBPbiBUaHUsIE5v diAxMiwgMjAyMCBhdCAwNzowMDoxMVBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+ID4g PiA+PiA+ID4gVGhlIHByZWNlZGVudCBoYXMgYWxyZWFkeSBiZWVuIHNldCBieSBvdGhlciBtYWNy b3MgaW4gdGhlIHNhbWUgZmlsZS4KPiA+ID4gPiA+ID4+ID4gPgo+ID4gPiA+ID4gPj4gPiA+IEZp eGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+ID4gPiA+ID4g Pj4gPiA+Cj4gPiA+ID4gPiA+PiA+ID4gIGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmM6 NTU6MTk6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmGNydGPigJkKPiA+ID4gPiA+IHNldCBidXQgbm90 IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gPiA+ID4gPiA+PiA+ID4gIDU1IHwg c3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gPiA+ID4gPj4gPiA+ICB8IF5+fn4KPiA+ID4gPiA+ ID4+ID4gPgo+ID4gPiA+ID4gPj4gPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gPiA+ID4gPj4gPiA+IENjOiBNYXhpbWUgUmlw YXJkIDxtcmlwYXJkQGtlcm5lbC5vcmc+Cj4gPiA+ID4gPiA+PiA+ID4gQ2M6IFRob21hcyBaaW1t ZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPgo+ID4gPiA+ID4gPj4gPiA+IENjOiBEYXZpZCBB aXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiA+ID4gPiA+PiA+ID4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+ID4gPiA+ID4+ID4gPiBDYzogUm9iIENsYXJrIDxyb2Jk Y2xhcmtAZ21haWwuY29tPgo+ID4gPiA+ID4gPj4gPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gPiA+ID4gPiA+PiA+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+ID4gPiA+ID4+ID4KPiA+ID4gPiA+ID4+ID4gQWxzbyBh cHBsaWVkIHRvIGRybS1taXNjLW5leHQuCj4gPiA+ID4gPiA+PiA+IFRoaXMgd2FzIHRoZSBsYXN0 IHBhdGNoIGZyb20gdGhpcyBiYXRjaCBJIHdpbGwgcHJvY2Vzcy4KPiA+ID4gPiA+ID4+ID4gVGhl IG90aGVycyBhcmUgbGVmdCBmb3IgdGhlIG1haW50YWluZXJzIHRvIHBpY2sgdXAuCj4gPiA+ID4g PiA+Pgo+ID4gPiA+ID4gPj4gYnR3IGZvciBwYXRjaGVzIHRoYXQgbWFpbnRhaW5lcnMgZG9uJ3Qg cGljayB1cCwgdGhlIHVzdWFsIHByb2Nlc3MgaXMKPiA+ID4gPiA+IHRoYXQKPiA+ID4gPiA+ID4+ IHdlIGdpdmUgdGhlbSAyIHdlZWtzLCB0aGVuIGp1c3QgbWFzcyBhcHBseS4gTm93IHlvdSdyZSBw cm9kdWNpbmcgYSBsb3QKPiA+ID4gPiA+IG9mCj4gPiA+ID4gPiA+PiBwYXRjaGVzLCB0b28gbXVj aCBmb3IgbWUgdG8ga2VlcCB0cmFjaywgc28gcGxlYXNlIGp1c3QgcGluZyBtZSB3aXRoIGEKPiA+ ID4gPiA+ID4+IHJlc2VuZCBmb3IgdGhvc2UgdGhhdCBleHBpcmVkIGFuZCBJJ2xsIGdvIHRocm91 Z2ggYW5kIHBpY2sgdGhlbSBhbGwgdXAuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+IFRoYXQncyBncmVhdCBEYW5pZWwuIFRoYW5rcyBmb3IgeW91ciBzdXBwb3J0Lgo+ID4gPiA+ ID4gPgo+ID4gPiA+ID4gPiBJIGNhbiBkbyBvbmUgYmV0dGVyIHRoYW4gdGhhdC4KPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gV291bGQgYSBwdWxsLXJlcXVlc3Qgc3VpdCB5b3U/Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gV2UgaGF2ZSBhIGZldyB0cmVlcyBnb2luZyBvbiwgYW5kIHlvdXIgcGF0Y2hlcyBh cmUgbGFuZGluZyB0aHJvdWdoIGFsbAo+ID4gPiA+ID4ga2luZHMgb2YgdGhlbS4gU28gdGhpcyBt aWdodCBiZSBtb3JlIGNvb3JkaW5hdGlvbiBwYWluLiBJZiB5b3UgY2FuCj4gPiA+ID4gPiBleGNs dWRlIHBhdGNoZXMgZm9yIHRoZSBzZXBhcmF0ZWx5IGFuZCB1c3VhbGx5IGZhaXJseSB3ZWxsIG1h aW50YWluZWQKPiA+ID4gPiA+IGRyaXZlcnMgb3V0IG9mIHRoZSBwdWxsIGl0IHNob3VsZCB3b3Jr IChkcm0vYW1kLCBkcm0vcmFkZW9uLCBkcm0vaTkxNSwKPiA+ID4gPiA+IGRybS9ub3V2ZWF1LCBk cm0vbXNtIGFuZCBkcm0vb21hcGRybSBwcm9iYWJseSB0aGUgdXN1YWwgb25lcykuCj4gPiA+ID4g Pgo+ID4gPiA+ID4gT3IgeW91IGp1c3Qgc2VuZCB0aGUgbmV4dCBwaWxlIGFuZCB3ZSdsbCBzZWUu Cj4gPiA+ID4gPgo+ID4gPiA+ID4gQWxzbyBJIGd1ZXNzIEkgY2FuJ3QgcmVhbGx5IGludGVyZXN0 IHlvdSBpbiBjb21taXQgcmlnaHRzIHNvIHRoaXMKPiA+ID4gPiA+IHBhdGNoIGJvbWJzIGdldCBv ZmYgbXkgYmFjayBhZ2Fpbj8gOi0pCj4gPiA+ID4gPgo+ID4gPiA+IAo+ID4gPiA+IFdoYXQgZG9l cyB0aGF0IG1lYW4/IE1lcmdlIG15IG93biBwYXRjaGVzPwo+ID4gPiA+IAo+ID4gPiA+IE5vdCBz dXJlIGhvdyB0aGF0IHdvcmtzIHdpdGggeW91ciBncm91cCBtYWludGVuYW5jZSBzZXR1cC4KPiA+ ID4gPiAKPiA+ID4gPiBJcyBpdCBqdXN0IGEgYGdpdCBwdXNoYD8KPiA+ID4gCj4gPiA+IEl0J3Mg YSBidW5jaCBvZiBzY3JpcHRpbmcgYW5kIHNldHVwLCBtaWdodCBub3QgYmUgd29ydGggaXQgZm9y IGp1c3Qgb25lCj4gPiA+IG9mLiBQbHVzIHdlIHN0aWxsIHRha2UgcHVsbCByZXF1ZXN0cyBmcm9t IHN1Ym1haW50YWluZXJzIHNvIGl0J3MgYWxsIGp1c3QKPiA+ID4gaWYgeW91IGZlZWwgbGlrZSBp dC4gU29tZSBkb2NzIGlmIHlvdSdyZSBjdXJpb3VzOgo+ID4gPiAKPiA+ID4gaHR0cHM6Ly9kcm0u cGFnZXMuZnJlZWRlc2t0b3Aub3JnL21haW50YWluZXItdG9vbHMvZ2V0dGluZy1zdGFydGVkLmh0 bWwKPiA+IAo+ID4gQXMgKmZ1biogYXMgdGhhdCBsb29rcywgSSB0aGluayBJJ2xsIGdpdmUgaXQg YSBtaXNzLCB0aGFua3MuIDopCj4gPiAKPiA+IFNvIGZvciB0aGUgZmluYWwgbWVyZ2Ugb2YgdGhl IG5vbi1SYWRlb24gc2V0IFswXSB0byBkYXRlIChBbGV4IGp1c3QKPiA+IHB1bGxlZCBpbiBhbGwg b2YgdGhlIG91dHN0YW5kaW5nIFJhZGVvbiBwYXRjaGVzKSwgd2UgaGF2ZSBhIGZldwo+ID4gb3B0 aW9uczoKPiA+IAo+ID4gIDEuIFRha2UgdGhlbSBkaXJlY3RseSBmcm9tIHRoZSBtb3N0IHJlY2Vu dCBzZXQgWzBdCj4gPiAgMi4gSSBjYW4gcmViYXNlIGFuZCByZXN1Ym1pdCBhZ2FpbiBpbiBhIGZl dyBkYXlzCj4gPiAgMy4gSSBjYW4gc3VibWl0IGEgUFIKPiA+IAo+ID4gV2hhdGV2ZXIgd29ya3Mg Zm9yIHlvdS4KPiA+IAo+ID4gWzBdICJbUEFUQ0ggdjIgMDAvNDJdIFJpZCBXPTEgd2FybmluZ3Mg ZnJvbSBHUFUgKG5vbi1SYWRlb24pIgo+IAo+IEkgcGxhbm5lZCB0byBnbyB0aHJvdWdoIHRoYXQg dG9kYXkgYW5kIGFwcGx5IGl0IGFsbC4gV2FudGVkIHRvIHBpbmcgYSBmZXcKPiBtYWludGFpbmVy cyBmaXJzdCB3aGV0aGVyIHRoZXkgcGljayBhbnl0aGluZyB1cCwgYnV0IGFzaWRlIGZyb20gQWxl eAo+IHRoZXkncmUgbm9uLWNvbW1pdHRhbCBzbyBJIHRoaW5rIEkganVzdCB2YWN1dW0gdGhlbSBh bGwgdXAgc28gaXQncyBkb25lLgoKT2theSwgcGVyZmVjdC4gIFRoYW5rcyBhIGJ1bmNoLgoKLS0g CkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIg U2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0Nz CkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BAAC5519F for ; Tue, 17 Nov 2020 11:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEECB207BC for ; Tue, 17 Nov 2020 11:08:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wm7D0wAE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728208AbgKQLIN (ORCPT ); Tue, 17 Nov 2020 06:08:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgKQLIM (ORCPT ); Tue, 17 Nov 2020 06:08:12 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32DB9C0613CF for ; Tue, 17 Nov 2020 03:08:11 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id m6so5559240wrg.7 for ; Tue, 17 Nov 2020 03:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=n6eCU59I1t0nmoUX/JMABtcH5UW5JkFeV2XR6hvO1PI=; b=wm7D0wAEo/rWM9cDVPNP5RJ17YGDvBs3Tv2wZAk+20keQeqxp782e2psf5adEkIAJw sBzqmKCyhVS9E/+1ZFLwEgN3IGBwv06ht4IKnvs3OdAZ/BSIrESIv6+YNUhFSivZUN3g bHTUf04wf+adxGk6uiLU0VYv/h2+FF9fe1ba7+XebaHBxy+Fwklt8xJiqTkqh/rgccdz 6mvX0bJM9e0n3niU4ktFpOUEYcqJZuH1a5cjr8asHLStTp15n0noMZqXMOwpawMzLk34 UHtHlyUEZlJTjy0VxYitue+UMwBcb7116/uy9rSHCJ7jaNkAygkvzsjFAdahI5uualMJ teFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=n6eCU59I1t0nmoUX/JMABtcH5UW5JkFeV2XR6hvO1PI=; b=Oo+LeSPW68W1dBoJd0pifnICWX36xErrMa3DwlLtKd6nLhjqfzZS9FdyTRj9Gm1+pQ +9Kv2AMnOMUgcjcVa/a9UejDm0s3vv4H2YN5QSDs7TIeZEhhZGTcb8GnZJejyp3w9giN BLmky85r6N+anPfCYX1a6dEEMgnJb1h4NftO3oKsjZIodZ8q6H6YeDjcvZQzjUKoK7c5 m2zBYwt0LWTu5ycfaoJ4UXb1PNU8wVLwBZrde2GTGlBurhxpvD6O26OmrHgcx8UifCp8 aCy9/yqJcqS+XBUcoUncaeO9HDHH9cdwKT71cvUN610vN84YwpW7rCQJSq9WdH5k+UvH YCOA== X-Gm-Message-State: AOAM530GuoG6SqU3f/UCQOqIFJFz3fxahw9lb8MFejqSs22Le2A8yQg+ LQNUCELgMY2UOShoa2X7kEm9tw== X-Google-Smtp-Source: ABdhPJyt5w/xfOns8zFWyU7ejsnKVtooG6J4Era6ZK54EsNK4dAphhyhJTCzhXH1vwllX5WPUSGCyQ== X-Received: by 2002:adf:d0c8:: with SMTP id z8mr25144803wrh.288.1605611289487; Tue, 17 Nov 2020 03:08:09 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm2919301wmf.35.2020.11.17.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:08:08 -0800 (PST) Date: Tue, 17 Nov 2020 11:08:07 +0000 From: Lee Jones To: Sam Ravnborg , David Airlie , Thomas Zimmermann , Linux Kernel Mailing List , dri-devel , Daniel Vetter Subject: Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Message-ID: <20201117110807.GG1869941@dell> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-3-lee.jones@linaro.org> <20201112202516.GA3340631@ravnborg.org> <20201113204959.GW401619@phenom.ffwll.local> <20201117100509.GJ401619@phenom.ffwll.local> <20201117103404.GF1869941@dell> <20201117104311.GK401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201117104311.GK401619@phenom.ffwll.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Tue, Nov 17, 2020 at 10:34:04AM +0000, Lee Jones wrote: > > Daniel, > > > > For some reason, you're not appearing in the recipents list when I > > reply to all. You're not in the Mail-Followup-To header. Any idea > > why this might be? > > No idea either, could be my mutt not setting the reply headers like it > should. I'm generally confused with how email works ... Yes, email is a mystery! > > Anyway, please see below: > > > > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > > On Fri, Nov 13, 2020 at 10:01:57PM +0000, Lee Jones wrote: > > > > On Fri, 13 Nov 2020, 21:31 Daniel Vetter, wrote: > > > > > > > > > On Fri, Nov 13, 2020 at 9:53 PM Lee Jones wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 13 Nov 2020, 20:50 Daniel Vetter, wrote: > > > > > >> > > > > > >> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > > > > > >> > Hi Lee, > > > > > >> > > > > > > >> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > > > > >> > > The precedent has already been set by other macros in the same file. > > > > > >> > > > > > > > >> > > Fixes the following W=1 kernel build warning(s): > > > > > >> > > > > > > > >> > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ > > > > > set but not used [-Wunused-but-set-variable] > > > > > >> > > 55 | struct drm_crtc *crtc; > > > > > >> > > | ^~~~ > > > > > >> > > > > > > > >> > > Cc: Maarten Lankhorst > > > > > >> > > Cc: Maxime Ripard > > > > > >> > > Cc: Thomas Zimmermann > > > > > >> > > Cc: David Airlie > > > > > >> > > Cc: Daniel Vetter > > > > > >> > > Cc: Rob Clark > > > > > >> > > Cc: dri-devel@lists.freedesktop.org > > > > > >> > > Signed-off-by: Lee Jones > > > > > >> > > > > > > >> > Also applied to drm-misc-next. > > > > > >> > This was the last patch from this batch I will process. > > > > > >> > The others are left for the maintainers to pick up. > > > > > >> > > > > > >> btw for patches that maintainers don't pick up, the usual process is > > > > > that > > > > > >> we give them 2 weeks, then just mass apply. Now you're producing a lot > > > > > of > > > > > >> patches, too much for me to keep track, so please just ping me with a > > > > > >> resend for those that expired and I'll go through and pick them all up. > > > > > > > > > > > > > > > > > > That's great Daniel. Thanks for your support. > > > > > > > > > > > > I can do one better than that. > > > > > > > > > > > > Would a pull-request suit you? > > > > > > > > > > We have a few trees going on, and your patches are landing through all > > > > > kinds of them. So this might be more coordination pain. If you can > > > > > exclude patches for the separately and usually fairly well maintained > > > > > drivers out of the pull it should work (drm/amd, drm/radeon, drm/i915, > > > > > drm/nouveau, drm/msm and drm/omapdrm probably the usual ones). > > > > > > > > > > Or you just send the next pile and we'll see. > > > > > > > > > > Also I guess I can't really interest you in commit rights so this > > > > > patch bombs get off my back again? :-) > > > > > > > > > > > > > What does that mean? Merge my own patches? > > > > > > > > Not sure how that works with your group maintenance setup. > > > > > > > > Is it just a `git push`? > > > > > > It's a bunch of scripting and setup, might not be worth it for just one > > > of. Plus we still take pull requests from submaintainers so it's all just > > > if you feel like it. Some docs if you're curious: > > > > > > https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html > > > > As *fun* as that looks, I think I'll give it a miss, thanks. :) > > > > So for the final merge of the non-Radeon set [0] to date (Alex just > > pulled in all of the outstanding Radeon patches), we have a few > > options: > > > > 1. Take them directly from the most recent set [0] > > 2. I can rebase and resubmit again in a few days > > 3. I can submit a PR > > > > Whatever works for you. > > > > [0] "[PATCH v2 00/42] Rid W=1 warnings from GPU (non-Radeon)" > > I planned to go through that today and apply it all. Wanted to ping a few > maintainers first whether they pick anything up, but aside from Alex > they're non-committal so I think I just vacuum them all up so it's done. Okay, perfect. Thanks a bunch. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog