From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3D7C2D0E4 for ; Tue, 17 Nov 2020 21:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F4DA2463D for ; Tue, 17 Nov 2020 21:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dZSJWDKn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbgKQVvq (ORCPT ); Tue, 17 Nov 2020 16:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbgKQVvq (ORCPT ); Tue, 17 Nov 2020 16:51:46 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A1D9C0617A6 for ; Tue, 17 Nov 2020 13:51:46 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id j19so10122998pgg.5 for ; Tue, 17 Nov 2020 13:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=dZSJWDKnArBdBXCgAIPNiaxvh5LCZwCDL6Ymkj44p0R8yL+KgQAfKZKf1lt2KfdnvV bLD1xeFdcoEmB+Z3tmSxV7RnFUrRITgkpS48Ri05VZa2xyqn5gWggufKXfTSH6J5m6de NMkUQrd2oc7jz3d1V4DoMoucn5sXNnsH3BN6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=MT2ZR53bXVt6SO0Cjb5mHkZtaHnuKPmUz50DjlwLF/9FCH9aW1Mv6FljG5ptssrsfU eHdfYhLuKtFUSkEQHBq9B+WpMRIVWR6rzI4qEtv1T76OIM9IPQGBuh0X2OXkLfcDg0zz CKenEL83EFEPmqbaGbJW5XqIhozZwewhnCvCodPt10LDRCIA1KiEcv+ofz00h45Z/3SI Gqg0eE/zlfe4b7mYInUxLSrdG1/RJ9dZbK4Q6mcWZqDnZzcnz9k/NNDZhZUMR+4xBVtk QEGQv4oqaG9/demulxsRonfrU+Nm4Au81WOc4YsnGCwV/B4bExajegfS4cICKpmfSXR5 duiA== X-Gm-Message-State: AOAM530Bm0F0Zab2bKixt3QP3Y8+RUNGC0EJwg0RdUhiyjKnDXMhe/Da oISQ/eAKt1Tccv0hpDTjq0VeHw== X-Google-Smtp-Source: ABdhPJxqggVKuH8HMTgHzwSVLvkZKhOmwN0EoIzciqR8uEi7NDnZHbJFTVTL+MdWrPbHDgwOP+UNwA== X-Received: by 2002:a63:7847:: with SMTP id t68mr5290408pgc.422.1605649905676; Tue, 17 Nov 2020 13:51:45 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m9sm42912pjf.20.2020.11.17.13.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:51:44 -0800 (PST) Date: Tue, 17 Nov 2020 13:51:43 -0800 From: Kees Cook To: Nathan Chancellor Cc: Masahiro Yamada , Michal Marek , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Nick Desaulniers , Arvind Sankar , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, clang-built-linux@googlegroups.com, "kernelci . org bot" , Mark Brown Subject: Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Message-ID: <202011171350.F95127F@keescook> References: <20201113195553.1487659-1-natechancellor@gmail.com> <20201113195553.1487659-2-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113195553.1487659-2-natechancellor@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > config LD_ORPHAN_WARN > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > + def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) && (!LD_IS_LLD || LLD_VERSION >= 110000) Readability nit-pick... I prefer separate "depends" lines to make things a little easier to parse, change, etc: config LD_ORPHAN_WARN def_bool y depends on ARCH_WANT_LD_ORPHAN_WARN depends on !LD_IS_LLD || LLD_VERSION >= 110000 depends on $(ld-option,--orphan-handling=warn) Otherwise, yeah, looks good to me. With this and the other suggestions, please consider it: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ACCFC2D0E4 for ; Tue, 17 Nov 2020 21:53:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8792E241A7 for ; Tue, 17 Nov 2020 21:53:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dZSJWDKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8792E241A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CbKSw63HrzDqZ2 for ; Wed, 18 Nov 2020 08:53:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=dZSJWDKn; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CbKQw2rG7zDqW8 for ; Wed, 18 Nov 2020 08:51:48 +1100 (AEDT) Received: by mail-pf1-x441.google.com with SMTP id v12so16527pfm.13 for ; Tue, 17 Nov 2020 13:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=dZSJWDKnArBdBXCgAIPNiaxvh5LCZwCDL6Ymkj44p0R8yL+KgQAfKZKf1lt2KfdnvV bLD1xeFdcoEmB+Z3tmSxV7RnFUrRITgkpS48Ri05VZa2xyqn5gWggufKXfTSH6J5m6de NMkUQrd2oc7jz3d1V4DoMoucn5sXNnsH3BN6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=BCU3T6HQQGET2rBntqCt+hwlbbVbHM2RVTxHkg58ncap/f6r1uWp8ExqHeeXUEvtgk Ax+RPqDL5rcx8i7eopXTzoUEuxfcoZmacdEOXUAK1TEsPAyPIgxZJRp6brEqi4R6Gs/S pUetngcias5UndXDrCCgOUtjIGzqVB0ma2GwIfa1YvU30KPUo20LzYMn5TmlrRJZzy2N TrlwsLuyPSpcs/fyuKcmjVJt1i0o6ZNiVnoZgHFdymaMavw5Bs1GR/aFfanhDlvtl9oX cOontt4f4HgOjpUPn5zw9YA/0m/I6goWCBTqi+OuFfMF2DNVEDulvmhFH4vLAm7A38o2 3LiQ== X-Gm-Message-State: AOAM532GGZHGT/uXjqZyqhzEoN0Izi2ka1wOxy3Hw1EC2XzSYUwD7Y9y xxDItFQ8JoqrlL1F/gTGO55q4w== X-Google-Smtp-Source: ABdhPJxqggVKuH8HMTgHzwSVLvkZKhOmwN0EoIzciqR8uEi7NDnZHbJFTVTL+MdWrPbHDgwOP+UNwA== X-Received: by 2002:a63:7847:: with SMTP id t68mr5290408pgc.422.1605649905676; Tue, 17 Nov 2020 13:51:45 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m9sm42912pjf.20.2020.11.17.13.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:51:44 -0800 (PST) Date: Tue, 17 Nov 2020 13:51:43 -0800 From: Kees Cook To: Nathan Chancellor Subject: Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Message-ID: <202011171350.F95127F@keescook> References: <20201113195553.1487659-1-natechancellor@gmail.com> <20201113195553.1487659-2-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113195553.1487659-2-natechancellor@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Marek , "kernelci . org bot" , linux-kbuild@vger.kernel.org, Mark Brown , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Arvind Sankar , Ingo Molnar , Borislav Petkov , clang-built-linux@googlegroups.com, Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > config LD_ORPHAN_WARN > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > + def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) && (!LD_IS_LLD || LLD_VERSION >= 110000) Readability nit-pick... I prefer separate "depends" lines to make things a little easier to parse, change, etc: config LD_ORPHAN_WARN def_bool y depends on ARCH_WANT_LD_ORPHAN_WARN depends on !LD_IS_LLD || LLD_VERSION >= 110000 depends on $(ld-option,--orphan-handling=warn) Otherwise, yeah, looks good to me. With this and the other suggestions, please consider it: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8110C63697 for ; Tue, 17 Nov 2020 21:53:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C14241A7 for ; Tue, 17 Nov 2020 21:53:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1pj7SsMv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dZSJWDKn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C14241A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KdWev2QQLvDwUywAjoRcXRZdFnpQCHenrFuQyIolR8I=; b=1pj7SsMv075V8jtB9wlbv+VJ/ n1ZEPvo23C0c3ZmUH5CK71ZzW7aejVKw5rD+I08B3Fzz1R9J+57VSH9YpnUl7hzvhZ7Ofur8k0M4C CEssWbPCRkwRjfvsOaVoxBT2I33/oCH9ds0q3enB8J8V4bFvihyOHgXrU2idGWJmFHNSSZKmUBxuh ViIPYAMoBKN33cXqYybWbJgK0xqMftlQ0XxfOFjuefeRJ0Q+AAR5k2fa+0GpQd/qkJmzc7MIOI2Z3 a9eOS4go/MZFxkdt2i+sRq5xutU29m93BD5hP4Z5aDnPvRAijmvas9yhJqb43UgWFl0HwlmH0YhTZ Xyt5MBD4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf8tG-0008W4-9s; Tue, 17 Nov 2020 21:51:54 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf8tD-0008Uh-L3 for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 21:51:52 +0000 Received: by mail-pg1-x544.google.com with SMTP id q34so724067pgb.11 for ; Tue, 17 Nov 2020 13:51:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=dZSJWDKnArBdBXCgAIPNiaxvh5LCZwCDL6Ymkj44p0R8yL+KgQAfKZKf1lt2KfdnvV bLD1xeFdcoEmB+Z3tmSxV7RnFUrRITgkpS48Ri05VZa2xyqn5gWggufKXfTSH6J5m6de NMkUQrd2oc7jz3d1V4DoMoucn5sXNnsH3BN6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=XjiXBh70ijSoO7cEZ8Aubm7Sr/wr96WOjT/KlveGFF7K8kS49N0JlkeNNj6IjE5Dwn p4wU7lHP8et04QjXbzhlUzh3uoCyyq+CSFjaOMdN2Ev8y6HAiaGomxcb5GW4LCLPllev fghPwdb5l6CAgk/8qPzujPp0o8hCuPjEbEgnli1KOt2oB/Qwbcdx4sGUP3c4aVo21VS1 Uofsi5ZMIccrui1qQ/34Mweys9jys1x9aXB5WrXAKiXExIQUDijgm4QDhJPIkUzfHyvl GiZTqor+TVlecBhZQy7ONUNJJgEeHTjoFEx2xejQZM5uh9e/LEmcDLYBMQ3wz2DNKFXt 8vbg== X-Gm-Message-State: AOAM5311DXNCdoGwiM0vCR/lljFxk6qwMBLyeca1TYYZqOlQhVo3iPAP aBrH7d5CY3g5UxQ5F7fZFzgMMA== X-Google-Smtp-Source: ABdhPJxqggVKuH8HMTgHzwSVLvkZKhOmwN0EoIzciqR8uEi7NDnZHbJFTVTL+MdWrPbHDgwOP+UNwA== X-Received: by 2002:a63:7847:: with SMTP id t68mr5290408pgc.422.1605649905676; Tue, 17 Nov 2020 13:51:45 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m9sm42912pjf.20.2020.11.17.13.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:51:44 -0800 (PST) Date: Tue, 17 Nov 2020 13:51:43 -0800 From: Kees Cook To: Nathan Chancellor Subject: Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Message-ID: <202011171350.F95127F@keescook> References: <20201113195553.1487659-1-natechancellor@gmail.com> <20201113195553.1487659-2-natechancellor@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113195553.1487659-2-natechancellor@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_165151_713685_7CD0EDD1 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Marek , "kernelci . org bot" , linux-kbuild@vger.kernel.org, Mark Brown , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Arvind Sankar , Ingo Molnar , Borislav Petkov , clang-built-linux@googlegroups.com, Michael Ellerman , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > config LD_ORPHAN_WARN > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > + def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) && (!LD_IS_LLD || LLD_VERSION >= 110000) Readability nit-pick... I prefer separate "depends" lines to make things a little easier to parse, change, etc: config LD_ORPHAN_WARN def_bool y depends on ARCH_WANT_LD_ORPHAN_WARN depends on !LD_IS_LLD || LLD_VERSION >= 110000 depends on $(ld-option,--orphan-handling=warn) Otherwise, yeah, looks good to me. With this and the other suggestions, please consider it: Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel