From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99ADC2D0E4 for ; Tue, 17 Nov 2020 17:03:06 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 517E824654 for ; Tue, 17 Nov 2020 17:03:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eMcaQ3Zq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 517E824654 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605632585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ue3zC7T8fmQuCaDXGubGJRGPv3cmkNzMcgCnlGDArDU=; b=eMcaQ3ZqFcK5w4FsZyMSuU/Bgcnii4lEuqW9Q+T/awyOXyB7ca6zRex5r3bZMEPN9owKdK V9to72pYYMNjflZL0Dju7JH5ZXQvZGZBppwzLcK/nXtIKmCXZrrJPPLQ7C98muucA/3F71 UAwgm7h4rhO6SPoS+pgSXa33cg8ppmg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-4LP8uQu_NDOUTmiiwjCIqg-1; Tue, 17 Nov 2020 12:03:01 -0500 X-MC-Unique: 4LP8uQu_NDOUTmiiwjCIqg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F35581882FA5; Tue, 17 Nov 2020 17:02:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2C9C196FE; Tue, 17 Nov 2020 17:02:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9E6E21832FFC; Tue, 17 Nov 2020 17:02:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AHGB3N3028114 for ; Tue, 17 Nov 2020 11:11:03 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6B83C10013BD; Tue, 17 Nov 2020 16:11:03 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01E091001901; Tue, 17 Nov 2020 16:10:59 +0000 (UTC) Date: Tue, 17 Nov 2020 11:10:59 -0500 From: Mike Snitzer To: Christoph Hellwig Message-ID: <20201117161059.GA27209@redhat.com> References: <20201116212020.1099154-1-hch@lst.de> <20201116212020.1099154-6-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20201116212020.1099154-6-hch@lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Minchan Kim , dm-devel@redhat.com, linux-block@vger.kernel.org Subject: Re: [dm-devel] [PATCH 5/6] dm: simplify flush_bio initialization in __send_empty_flush X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 16 2020 at 4:20pm -0500, Christoph Hellwig wrote: > We don't really need the struct block_device to initialize a bio. So > switch from using bio_set_dev to manually setting up bi_disk (bi_partno > will always be zero and has been cleared by bio_init already). > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F37BAC2D0E4 for ; Tue, 17 Nov 2020 16:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A57ED221F8 for ; Tue, 17 Nov 2020 16:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VN4pFUyX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbgKQQLK (ORCPT ); Tue, 17 Nov 2020 11:11:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49075 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgKQQLJ (ORCPT ); Tue, 17 Nov 2020 11:11:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605629468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ty0piOqP3uWEyX4doTunEiMBz0nVw//TvJV0Jd8m6io=; b=VN4pFUyX4cWbMVbPjFZSLnd+23MElbDzS7vPdmuWOljrgV5S9cnrONxzVqflBZorutNBXo TW/R5vGbcG0yy5ksLNGOBdkeVQw6+Qie397A4Ov3YVVoI8OC/YSZ1urbeXZhcqgvT5tZzw +DA5XiG0QBtFkDp2XKkW0ylsbKTe9CI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-6WDa9stpNEeWZxsCn66_Yw-1; Tue, 17 Nov 2020 11:11:04 -0500 X-MC-Unique: 6WDa9stpNEeWZxsCn66_Yw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6CD841054F8A; Tue, 17 Nov 2020 16:11:03 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01E091001901; Tue, 17 Nov 2020 16:10:59 +0000 (UTC) Date: Tue, 17 Nov 2020 11:10:59 -0500 From: Mike Snitzer To: Christoph Hellwig Cc: Jens Axboe , Minchan Kim , dm-devel@redhat.com, linux-block@vger.kernel.org Subject: Re: [PATCH 5/6] dm: simplify flush_bio initialization in __send_empty_flush Message-ID: <20201117161059.GA27209@redhat.com> References: <20201116212020.1099154-1-hch@lst.de> <20201116212020.1099154-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116212020.1099154-6-hch@lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Nov 16 2020 at 4:20pm -0500, Christoph Hellwig wrote: > We don't really need the struct block_device to initialize a bio. So > switch from using bio_set_dev to manually setting up bi_disk (bi_partno > will always be zero and has been cleared by bio_init already). > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer