From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA4AC2D0E4 for ; Tue, 17 Nov 2020 18:13:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B1292467A for ; Tue, 17 Nov 2020 18:13:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pX+RHuLM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B1292467A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E24789316; Tue, 17 Nov 2020 18:13:45 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B99489316 for ; Tue, 17 Nov 2020 18:13:44 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id k2so24187649wrx.2 for ; Tue, 17 Nov 2020 10:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XUZThx36p3R01Q+OVZgC7ap+liimQUklKkO3YYLInjI=; b=pX+RHuLMITy1MSvnEX1opAwiuvv2Np3vNifM0kwC8d6WVZyNg+AdihEsvkn3hXp8Re 3nBbUAVATInJR21EJkc3p2bhareTwPXUWAqpw3/ekms5J0snEHbv1p3d8Pf4tG9SibXa 3xGqQ+c/ywhiljpumUxG/N0OvVpjKfnVfY+PDKgNl9bkbp7LXGKyQpU+UPGAbZKmftbs Xdg0s+53b/b0+soH3/rDaMDGMfoxhU1m+5HRXA/7rJ+DW6UpwiJ5JID0XfGZUu6vvv37 z5/KEC+pCxOXh0K1GaG0zl8YJUUco+0GjP+hYtzEoOriVXLN1y84GdGqcVaBQwmm7vDq kAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XUZThx36p3R01Q+OVZgC7ap+liimQUklKkO3YYLInjI=; b=F+ZSmZU+87lI9ixvXogqYy3QhfOnw4xZ6ssgmIk6roiYtjcyaRjExYPDPVtEtZv4H8 8WRw7U0MRGN0lxkqMH8tMZaJx+ZUkEnURYzz4fEh9s+lDGDoAtCerYdaseGYZdXeWIJ7 jS/pW4tddiTxdrXvd0O1uyrN9eslXx2lCZpXQyrBIxP2TjN2g8QqN8ott2xMiZC004Gv FQ8Du/WJcvwBhon1yXipXPwG9pmCpK5gGTSzULB4cCNW30O+Qyb2R8kavb63c6alwFyf G4G8v7QcCcqFv4eLmKHPgBJJEf+QY/A8KtP6uyjNZ68hhVA9slOCBGvxHWtF9hSeM+Cj fLtw== X-Gm-Message-State: AOAM532FMtWI7wlI6g/+h7GJcui6hZaTiAHw0vSzMAMBOMeoLmV/WBX1 Zocn/XmJqLnRTo9YFVCJrCWlq9Z4TjlDYi2B X-Google-Smtp-Source: ABdhPJzdDhitlcjhywQsflVnI9g5fvH8tJ02VlY73QUwKH2fOOZiML4WaajFIWJsxc97BVGkQwFU0Q== X-Received: by 2002:a5d:6050:: with SMTP id j16mr897945wrt.158.1605636822648; Tue, 17 Nov 2020 10:13:42 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x6sm4815167wmc.48.2020.11.17.10.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 10:13:41 -0800 (PST) Date: Tue, 17 Nov 2020 18:13:40 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, daniel@ffwll.ch Subject: Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Message-ID: <20201117181340.GM1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-4-lee.jones@linaro.org> <20201117172925.GN401619@phenom.ffwll.local> <20201117181250.GL1869941@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201117181250.GL1869941@dell> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAxNyBOb3YgMjAyMCwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBUdWUsIDE3IE5vdiAy MDIwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IAo+ID4gT24gTW9uLCBOb3YgMTYsIDIwMjAgYXQg MDU6NDA6MzNQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiBGaXhlcyB0aGUgZm9sbG93 aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiA+ID4gCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jOiBJbiBmdW5jdGlvbiDigJhkcm1fZHBfc2VuZF9x dWVyeV9zdHJlYW1fZW5jX3N0YXR1c+KAmToKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHBf bXN0X3RvcG9sb2d5LmM6MzI2Mzo2OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhsZW7igJkgc2V0IGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiA+ID4gCj4gPiA+IENjOiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4g PiBDYzogTWF4aW1lIFJpcGFyZCA8bXJpcGFyZEBrZXJuZWwub3JnPgo+ID4gPiBDYzogVGhvbWFz IFppbW1lcm1hbm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+Cj4gPiA+IENjOiBEYXZpZCBBaXJsaWUg PGFpcmxpZWRAbGludXguaWU+Cj4gPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IFNpZ25l ZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAKPiA+IEdvaW5n IHRvIGFwcGx5IHRoaXMsIGJ1dCBJIG5vdGljZWQgdGhhdCB0aGUgcmV0dXJuIHZhbHVlIG9mIHRo ZQo+ID4gYnVpbGRfcXVlcnlfc3RyZWFtX2VuY19zdGF0dXMoKSBpcyBwb2ludGxlc3MuIENhbiB5 b3UgcGxzIGZvbGxvdyB1cCB3aXRoCj4gPiBhbiBhZGRpdGlvbmFsIHBhdGNoIHRvIGNoYW5nZSB0 aGF0IHRvIHZvaWQ/Cj4gCj4gSSBjYW4uCgpMb29rcyBsaWtlIHlvdSdyZSBnZXR0aW5nIGRyb3Bw ZWQgYWdhaW4hCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9D7C5519F for ; Tue, 17 Nov 2020 18:13:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7D1D2462E for ; Tue, 17 Nov 2020 18:13:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pX+RHuLM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730318AbgKQSNp (ORCPT ); Tue, 17 Nov 2020 13:13:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgKQSNo (ORCPT ); Tue, 17 Nov 2020 13:13:44 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A031C0613CF for ; Tue, 17 Nov 2020 10:13:44 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id 23so24112202wrc.8 for ; Tue, 17 Nov 2020 10:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XUZThx36p3R01Q+OVZgC7ap+liimQUklKkO3YYLInjI=; b=pX+RHuLMITy1MSvnEX1opAwiuvv2Np3vNifM0kwC8d6WVZyNg+AdihEsvkn3hXp8Re 3nBbUAVATInJR21EJkc3p2bhareTwPXUWAqpw3/ekms5J0snEHbv1p3d8Pf4tG9SibXa 3xGqQ+c/ywhiljpumUxG/N0OvVpjKfnVfY+PDKgNl9bkbp7LXGKyQpU+UPGAbZKmftbs Xdg0s+53b/b0+soH3/rDaMDGMfoxhU1m+5HRXA/7rJ+DW6UpwiJ5JID0XfGZUu6vvv37 z5/KEC+pCxOXh0K1GaG0zl8YJUUco+0GjP+hYtzEoOriVXLN1y84GdGqcVaBQwmm7vDq kAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XUZThx36p3R01Q+OVZgC7ap+liimQUklKkO3YYLInjI=; b=h55SvTleW/MjgaauF7umQZedkhh8/y1IERT0+yKoOXv9cnNX3pd/rQAQwRYyRBOjky +D5hxL1HBQUPr/8uYPxmk+0IQrBimFSGJyG/hzTF70Lb2D4uMYp8BRljsjJkoRdHowV+ 3zJMf9+lIWoGFEPn2Iz+P6Akep5bqiaUdyP9bj1xVFxt0OfK4/erVAscBH6vvdFYc68h GX6j7Z91e9BK0UnaIy1a6deNspL1540d9/cRcpURAFHmjiBLEYn4z0IcIlcCABZBkhcY UJqJQLzPuyqobTspXBFsIQotijYl8j2GNR74mj+30k5yNqSPUxXY+cKkInVKcKhAMiUk byPQ== X-Gm-Message-State: AOAM533WgPMN3TFEYlZnTZf+R7hH6egxEGnUFmxdeG4vt9txqNUQy0ds qfjnwI/IRmOIdPAi+ZLZkPJjFygxAg/qLn0y X-Google-Smtp-Source: ABdhPJzdDhitlcjhywQsflVnI9g5fvH8tJ02VlY73QUwKH2fOOZiML4WaajFIWJsxc97BVGkQwFU0Q== X-Received: by 2002:a5d:6050:: with SMTP id j16mr897945wrt.158.1605636822648; Tue, 17 Nov 2020 10:13:42 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x6sm4815167wmc.48.2020.11.17.10.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 10:13:41 -0800 (PST) Date: Tue, 17 Nov 2020 18:13:40 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, daniel@ffwll.ch Subject: Re: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Message-ID: <20201117181340.GM1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-4-lee.jones@linaro.org> <20201117172925.GN401619@phenom.ffwll.local> <20201117181250.GL1869941@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201117181250.GL1869941@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020, Lee Jones wrote: > On Tue, 17 Nov 2020, Daniel Vetter wrote: > > > On Mon, Nov 16, 2020 at 05:40:33PM +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_dp_send_query_stream_enc_status’: > > > drivers/gpu/drm/drm_dp_mst_topology.c:3263:6: warning: variable ‘len’ set but not used [-Wunused-but-set-variable] > > > > > > Cc: Maarten Lankhorst > > > Cc: Maxime Ripard > > > Cc: Thomas Zimmermann > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Lee Jones > > > > Going to apply this, but I noticed that the return value of the > > build_query_stream_enc_status() is pointless. Can you pls follow up with > > an additional patch to change that to void? > > I can. Looks like you're getting dropped again! -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog