From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4764FC5519F for ; Wed, 18 Nov 2020 07:49:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7624D223C7 for ; Wed, 18 Nov 2020 07:49:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YTUwVv5F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7624D223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 99D7316E3; Wed, 18 Nov 2020 08:48:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 99D7316E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605685758; bh=W53kf0sA41Ui3hAkoYQedLbVIY4mvBoFp7NgHyqXuVQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YTUwVv5FzO9l8L8a259AL2Br0/1aAFuHNPPZSMqI0o4ZToWebJ76HPtugypDca697 fkCGwLQ5M7C/vOL3w865oR9KDT6n3PDAOuAE9pUS50ML7JmhYmHnZiyAT7/Zb1j53J nHHNf1h4ivlqFLhw7cZ4G5Iz3j23u3zo7mPevQuo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 19259F800EE; Wed, 18 Nov 2020 08:48:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AF86EF8016C; Wed, 18 Nov 2020 08:48:26 +0100 (CET) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5008AF800EE for ; Wed, 18 Nov 2020 08:48:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5008AF800EE Received: by mail-ed1-f68.google.com with SMTP id e18so949967edy.6 for ; Tue, 17 Nov 2020 23:48:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/VBymVKVFuIaMs6diTaKJdglBbHoKWE5HN40ZxS82fM=; b=AwGWII9Nj+6srSpXHgxvvl/fhJVvWnIN+IoIUbaCVx6VT9scYEpWH5Nj9d+B4XmSOr QHUcEZWZfsZihCAEytupimpy6x4nCk9S+E/vVELZi7Tv6KfrkzIGGKXgROZOHO8E9O33 bguLXscqQ1JydhjaAOo0LpC6gOgiVPABU1aGWrU1LxVPOd/IUpPzlZga3csKk34OjoJC DAuIqzsgYjOerncaBNf1y3gI6afsXXwbfyXIAMwNp108cnY7aavsWwNYrIAhvEHNKDLB vzGQlOxBpzKCKsFrwHyn4DdV7JRwmLuMmU4YgVnlUZGFPv7RhH0TOzTQWhL3SoM+E2ZH w1fw== X-Gm-Message-State: AOAM530WEctUPFdKFvwnZIFDirAbOSCV+tPSBnd6grTx4FmAzq5nR9Yn gT5nX5LtEWmcc5oqUMZPuPQ= X-Google-Smtp-Source: ABdhPJx+aZjGIA58JBNNsU2EYJuORCMi9eVDKQ3IfVQdHZjH8ummbU4/k0jvYclGpHK/bGP8ytcepg== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr24597168edp.361.1605685694599; Tue, 17 Nov 2020 23:48:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g7sm13224731edl.5.2020.11.17.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 23:48:13 -0800 (PST) Date: Wed, 18 Nov 2020 08:48:12 +0100 From: Krzysztof Kozlowski To: Stephen Boyd Subject: Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK Message-ID: <20201118074812.GA5803@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-2-krzk@kernel.org> <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> Cc: devel@driverdev.osuosl.org, Jernej Skrabec , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Greg Kroah-Hartman , Michael Turquette , Takashi Iwai , Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , Mark Brown , Sakari Ailus , Mauro Carvalho Chehab , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legacy clocks are provided by architecture, so it correctly depends on > > !HAVE_LEGACY_CLK. > > > > However it is possible to create a config which selects both COMMON_CLK > > (by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (by SOC_RT305X) which leads to > > Why is SND_SUN8I_CODEC selecting COMMON_CLK? Or really, why is > SOC_RT305X selecting HAVE_LEGACY_CLK? The SND_SUN8I_CODEC I fixed in following patch (I sent separately v2 of it). The SOC_RT305X select HAVE_LEGACY_CLK? because it is an old, Ralink platform, not converted to Common clock frm. Few clock operations are defined in: arch/mips/ralink/clk.c Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4609C5519F for ; Wed, 18 Nov 2020 07:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 602622463F for ; Wed, 18 Nov 2020 07:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgKRHsR (ORCPT ); Wed, 18 Nov 2020 02:48:17 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:36417 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgKRHsQ (ORCPT ); Wed, 18 Nov 2020 02:48:16 -0500 Received: by mail-ed1-f65.google.com with SMTP id m16so957325edr.3; Tue, 17 Nov 2020 23:48:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/VBymVKVFuIaMs6diTaKJdglBbHoKWE5HN40ZxS82fM=; b=ZoQXuxH+O+bMZf6e01a5OMk9ERHYOga+zduslROkrb0PoC1qdpsAMBS9m/r9xs3xdH pOAsqdM5IZIe1OxHvwq5MbntFv8ZylO2ufc66o6O9BzN42J4XzXkM2kzOe2zcX4X50+J 8vfTwwj0xleWzXBBKaa0wNRfEjexpfgMkMVPS1jJbBsPNbakT5sK3J1r9WOZVI0DPg0U EXSKz+EUgP3H4o8h8t7eu3FY72qnHRXJxGr/fs2Tw1qYAcbj0upMEdRAJfaphMMg7JEw fBJzInSNZAL0tFu0X5HbAoaCGTIyHBJgjL+ojNgF51Ueb+99jWoTXX+Hc72pAr+Hxp+D rlXQ== X-Gm-Message-State: AOAM532hxQ6o2qZiFQE4V99fQQOBcX0g+PRAVF52+kEU5JTFEIah4p27 ZhqHJry+Vx9AKUUNfEMFZpQ= X-Google-Smtp-Source: ABdhPJx+aZjGIA58JBNNsU2EYJuORCMi9eVDKQ3IfVQdHZjH8ummbU4/k0jvYclGpHK/bGP8ytcepg== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr24597168edp.361.1605685694599; Tue, 17 Nov 2020 23:48:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g7sm13224731edl.5.2020.11.17.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 23:48:13 -0800 (PST) Date: Wed, 18 Nov 2020 08:48:12 +0100 From: Krzysztof Kozlowski To: Stephen Boyd Cc: Chen-Yu Tsai , Greg Kroah-Hartman , Jaroslav Kysela , Jernej Skrabec , Liam Girdwood , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Sakari Ailus , Takashi Iwai , alsa-devel@alsa-project.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK Message-ID: <20201118074812.GA5803@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-2-krzk@kernel.org> <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legacy clocks are provided by architecture, so it correctly depends on > > !HAVE_LEGACY_CLK. > > > > However it is possible to create a config which selects both COMMON_CLK > > (by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (by SOC_RT305X) which leads to > > Why is SND_SUN8I_CODEC selecting COMMON_CLK? Or really, why is > SOC_RT305X selecting HAVE_LEGACY_CLK? The SND_SUN8I_CODEC I fixed in following patch (I sent separately v2 of it). The SOC_RT305X select HAVE_LEGACY_CLK? because it is an old, Ralink platform, not converted to Common clock frm. Few clock operations are defined in: arch/mips/ralink/clk.c Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180F3C5519F for ; Wed, 18 Nov 2020 07:49:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FA812225B for ; Wed, 18 Nov 2020 07:49:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uHzG/3Yz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FA812225B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Twzm3f7THlOz+rWwwf0ntsJx7v77vnuyIgs10Z5BQR4=; b=uHzG/3YzPK0uP/p3veKnSXc7q 4JRunVb6tqPwycmauwqtqhHsEJjSdWgV7kcVjoXX0k6CJFd6ubj06FQf6zaagq2UgEP/ddsZ4M3j+ 3tEOKl4sTe69qNgeFf7tU7YjnVXjXqOTAEdOqcNIqy6vA16lBUgkaA4odNsUtj3tO1CeZfONionk/ hjLLVLr+TLUL4X2F/qvtiwsfFchy8cizFAVuGComkYtbZP7vZbuBQ0mZorWIqHNPbS2XaFAaMaB5U MsdzEuE/4MNFcUap+17Er7DvQmsf71ywxLqTKxOX7jDuz11dLpa+xCJECiytqSbIk8SR47x8Fbl0C uN3qCY0XA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfICQ-0001oJ-Jy; Wed, 18 Nov 2020 07:48:18 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfICN-0001nv-Rz for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 07:48:16 +0000 Received: by mail-ed1-f66.google.com with SMTP id a15so972858edy.1 for ; Tue, 17 Nov 2020 23:48:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/VBymVKVFuIaMs6diTaKJdglBbHoKWE5HN40ZxS82fM=; b=XxMLj9jUwzXBZVksvE9homR/TMe+GefQ6hS3Mtl/ZVmgDJ6o6xkz96Rfj68tOT2+S4 7cMDI8EaG/SjoqP3tc7PGdkUzZU4DC6T77s4Y8kKNIpH+dpq0AJJS5cmYLWMo1q1pbZ/ 3v/LtLDhk94OpKYlU/gSesZzAciuhw63ZVg/WmW6lTITe2kd7uqBmERwsn+16XERb9VI mKAk6RaKrVlV8OXPrfed7NdgFwuJI/PIR+LBRMYZ1T8z23B6tW9g8OBQPh8urHM/k1X5 eJPa1G0Cbqhln+ngY76wnZ2tWjd4jngWbnkuN3ofp/Y2UQzObYk6mu+wNxHtbJ3Vx42t 3Vhg== X-Gm-Message-State: AOAM530QCddZLkkIiw8cbIDc0aeIbaZP+y8dZW8zYsh+Y9COeUOUEKaw 1PS1Lr01yLeaxM+vc3NQGiE= X-Google-Smtp-Source: ABdhPJx+aZjGIA58JBNNsU2EYJuORCMi9eVDKQ3IfVQdHZjH8ummbU4/k0jvYclGpHK/bGP8ytcepg== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr24597168edp.361.1605685694599; Tue, 17 Nov 2020 23:48:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g7sm13224731edl.5.2020.11.17.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 23:48:13 -0800 (PST) Date: Wed, 18 Nov 2020 08:48:12 +0100 From: Krzysztof Kozlowski To: Stephen Boyd Subject: Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK Message-ID: <20201118074812.GA5803@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-2-krzk@kernel.org> <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_024816_111133_1B8708EE X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Jernej Skrabec , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Greg Kroah-Hartman , Michael Turquette , Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Mark Brown , Sakari Ailus , Mauro Carvalho Chehab , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legacy clocks are provided by architecture, so it correctly depends on > > !HAVE_LEGACY_CLK. > > > > However it is possible to create a config which selects both COMMON_CLK > > (by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (by SOC_RT305X) which leads to > > Why is SND_SUN8I_CODEC selecting COMMON_CLK? Or really, why is > SOC_RT305X selecting HAVE_LEGACY_CLK? The SND_SUN8I_CODEC I fixed in following patch (I sent separately v2 of it). The SOC_RT305X select HAVE_LEGACY_CLK? because it is an old, Ralink platform, not converted to Common clock frm. Few clock operations are defined in: arch/mips/ralink/clk.c Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel