From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14194C56202 for ; Wed, 18 Nov 2020 08:43:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C9D024654 for ; Wed, 18 Nov 2020 08:43:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PNvc5vIy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C9D024654 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCC6B6E082; Wed, 18 Nov 2020 08:43:07 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27C346E082 for ; Wed, 18 Nov 2020 08:43:06 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id 1so1896427wme.3 for ; Wed, 18 Nov 2020 00:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fnDyKeim6MLktf6goxDG8bETMIT1x5B36xRg+H6Tp/M=; b=PNvc5vIyrM8C6v8Z5V12ssPdpy36I2f7x9AozlD63o4mrUjyxSHNOAWNPdKG7szVFK aV3pcXO/4aHBMgR626nYQY0gAHd7ShMdqGKJooslFMOoueqx8cLs6V3YRVR8MWaXGcgC vtJMh4SY4YQNpGLF+SUfVbBpnPRL0EzKM9BxYxNjA73hUroITzc/5RJda6Kc13T5oC09 shbKgF8A2HqrTC9Eytrz00gvcOtuqZeZ7USciOJIT0Rm9Wiz1EiXwRHrmb2ihwI7Uh5p Hoi/L6kQeF1dI34rorxfs5IkXdmHz+TSkkp8R97KD8IbEC8UoDc+0SpGzjZkxz7lm1Wg 8MFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fnDyKeim6MLktf6goxDG8bETMIT1x5B36xRg+H6Tp/M=; b=IBUcZNfvuz1nr7ZoxFDhU++x8bDwcxw1xw9ycG7wUAdVidj3NgyNrPjS/6RBGmOoxG aM4DkIXnxvEGJCy6pwhR0sP3MllcuTPIWS0KeS3Bcv7kt/CCkLYuw+IQKi3pvZ4BvVKv Y/BqD+G5iuISDiUOpUBI3l5U+8reZrYHQ6sxp1DLawGN7Ioh26lZpuDq0/XUxlB5MCud wEyYvWM3J9NemHB1AV1tnkZOqFa4BgyGn+FVO5Ggbj+cWU0Iv7DqyqoGmKrW6aaORRSa WXJxnVjrNL65sktCcRuIy6ZYEHkqqzARgIZpWFPE1i3DxOlT28Kfey4/ihCG2XzQqg1w Fb7w== X-Gm-Message-State: AOAM530hJvP0w5nnip/Y6rCQDIpLIo8cxOyj5DN0R8DUoOF9RR4j8q6W RUmyJ476QEVsaTkvMHrwKlRYbA== X-Google-Smtp-Source: ABdhPJyIWUVccZyAXEsObevGW/HAb1nxmtfyuHFvXXaetFjntxj3sQMrjXfKIJTB0JRP1IXOQra5yw== X-Received: by 2002:a7b:c92a:: with SMTP id h10mr1473209wml.138.1605688984839; Wed, 18 Nov 2020 00:43:04 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id e1sm1894406wmd.16.2020.11.18.00.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 00:43:03 -0800 (PST) Date: Wed, 18 Nov 2020 08:43:02 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Philipp Zabel , David Airlie , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH 42/42] include/drm/drm_atomic: Make use of 'new_crtc_state' Message-ID: <20201118084302.GN1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-43-lee.jones@linaro.org> <20201117194241.GV401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201117194241.GV401619@phenom.ffwll.local> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAxNyBOb3YgMjAyMCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gTW9uLCBOb3Yg MTYsIDIwMjAgYXQgMDU6NDE6MTJQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gSW4gdGhl IG1hY3JvIGZvcl9lYWNoX29sZG5ld19jcnRjX2luX3N0YXRlKCkgJ2NydGNfc3RhdGUnIGlzIHBy b3ZpZGVkCj4gPiBhcyBhIGNvbnRhaW5lciBmb3Igc3RhdGUtPmNydGNzW2ldLm5ld19zdGF0ZSwg YnV0IGlzIG5vdCB1dGlsaXNlZCBpbgo+ID4gc29tZSB1c2UtY2FzZXMsIHNvIHdlIGZha2UtdXNl IGl0IGluc3RlYWQuCj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWls ZCB3YXJuaW5nKHMpOgo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1wbGFuZS5j OiBJbiBmdW5jdGlvbiDigJhpcHVfcGxhbmVzX2Fzc2lnbl9wcmXigJk6Cj4gPiAgZHJpdmVycy9n cHUvZHJtL2lteC9pcHV2My1wbGFuZS5jOjc0Njo0Mjogd2FybmluZzogdmFyaWFibGUg4oCYY3J0 Y19zdGF0ZeKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ ID4gCj4gPiBDYzogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPiA+IENj OiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPgo+ID4gQ2M6IFNoYXduIEd1byA8c2hhd25ndW9Aa2VybmVsLm9yZz4K PiA+IENjOiBTYXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+Cj4gPiBDYzogUGVu Z3V0cm9uaXggS2VybmVsIFRlYW0gPGtlcm5lbEBwZW5ndXRyb25peC5kZT4KPiA+IENjOiBGYWJp byBFc3RldmFtIDxmZXN0ZXZhbUBnbWFpbC5jb20+Cj4gPiBDYzogTlhQIExpbnV4IFRlYW0gPGxp bnV4LWlteEBueHAuY29tPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gCj4g T2sgSSBtZXJnZWQgdGhlbSBhbGwgZXhjZXB0Ogo+IC0gZHJtL2FtZCBhbmQgZHJtL2lteCwgc2hv dWxkIGJlIHBpY2tlZCB1cCBhbHJlYWR5IGJ5IHJlc3BlY3RpdmUKPiAgIG1haW50YWluZXJzCj4g LSBkcm0vbXNtLCBSb2IgcHJvbWlzZWQgdG8gdGFrZSBjYXJlCj4gCj4gVGhhbmtzIGEgbG90IGZv ciB5b3VyIHBhdGNoZXMuCgpQZXJmZWN0LiAgVGhhbmsgeW91IGZvciByZXZpZXdpbmcvbWVyZ2lu ZyB0aGVtLgoKPiA+IC0tLQo+ID4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWMuaCB8IDMgKystCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oIGIvaW5jbHVkZS9kcm0vZHJt X2F0b21pYy5oCj4gPiBpbmRleCBkYzVlMGZiZWNjMDRlLi41NGUwNTFhOTU3ZGZjIDEwMDY0NAo+ ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9k cm1fYXRvbWljLmgKPiA+IEBAIC03ODMsNyArNzgzLDggQEAgdm9pZCBkcm1fc3RhdGVfZHVtcChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX3ByaW50ZXIgKnApOwo+ID4gIAkJCSAg ICAgICh2b2lkKShjcnRjKSAvKiBPbmx5IHRvIGF2b2lkIHVudXNlZC1idXQtc2V0LXZhcmlhYmxl IHdhcm5pbmcgKi8sIFwKPiA+ICAJCQkgICAgIChvbGRfY3J0Y19zdGF0ZSkgPSAoX19zdGF0ZSkt PmNydGNzW19faV0ub2xkX3N0YXRlLCBcCj4gPiAgCQkJICAgICAodm9pZCkob2xkX2NydGNfc3Rh dGUpIC8qIE9ubHkgdG8gYXZvaWQgdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgd2FybmluZyAqLywg XAo+ID4gLQkJCSAgICAgKG5ld19jcnRjX3N0YXRlKSA9IChfX3N0YXRlKS0+Y3J0Y3NbX19pXS5u ZXdfc3RhdGUsIDEpKQo+ID4gKwkJCSAgICAgKG5ld19jcnRjX3N0YXRlKSA9IChfX3N0YXRlKS0+ Y3J0Y3NbX19pXS5uZXdfc3RhdGUsIFwKPiA+ICsJCQkgICAgICh2b2lkKShuZXdfY3J0Y19zdGF0 ZSkgLyogT25seSB0byBhdm9pZCB1bnVzZWQtYnV0LXNldC12YXJpYWJsZSB3YXJuaW5nICovLCAx KSkKPiA+ICAKPiA+ICAvKioKPiA+ICAgKiBmb3JfZWFjaF9vbGRfY3J0Y19pbl9zdGF0ZSAtIGl0 ZXJhdGUgb3ZlciBhbGwgQ1JUQ3MgaW4gYW4gYXRvbWljIHVwZGF0ZQo+IAoKLS0gCkxlZSBKb25l cyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMK TGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBM aW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D90C5519F for ; Wed, 18 Nov 2020 08:43:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB48224656 for ; Wed, 18 Nov 2020 08:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PNvc5vIy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgKRInI (ORCPT ); Wed, 18 Nov 2020 03:43:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726724AbgKRInI (ORCPT ); Wed, 18 Nov 2020 03:43:08 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911C5C0613D4 for ; Wed, 18 Nov 2020 00:43:06 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id w24so1903564wmi.0 for ; Wed, 18 Nov 2020 00:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fnDyKeim6MLktf6goxDG8bETMIT1x5B36xRg+H6Tp/M=; b=PNvc5vIyrM8C6v8Z5V12ssPdpy36I2f7x9AozlD63o4mrUjyxSHNOAWNPdKG7szVFK aV3pcXO/4aHBMgR626nYQY0gAHd7ShMdqGKJooslFMOoueqx8cLs6V3YRVR8MWaXGcgC vtJMh4SY4YQNpGLF+SUfVbBpnPRL0EzKM9BxYxNjA73hUroITzc/5RJda6Kc13T5oC09 shbKgF8A2HqrTC9Eytrz00gvcOtuqZeZ7USciOJIT0Rm9Wiz1EiXwRHrmb2ihwI7Uh5p Hoi/L6kQeF1dI34rorxfs5IkXdmHz+TSkkp8R97KD8IbEC8UoDc+0SpGzjZkxz7lm1Wg 8MFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fnDyKeim6MLktf6goxDG8bETMIT1x5B36xRg+H6Tp/M=; b=Hi0g5e9+40EzheK87gQdWiVdoazXu5FySQI5NEyANEok3hTQjKbWU0kdhoj6YYBjuP jsVfvgVzzXmckOmMQNiPeJzgGyxNxVMaYVbgEqivkGqT9cJ6Wt7qvcLUFpFegaWuL81l 3aXePpmD0Lg3nDOzA62CS1Ki23fAdQccoFmX0yGeo7A7bSi0IDmfK5aXXucPXLSxv7Kc VnRTHwTPIWLzwtUjgi8kPRp83YQ3R5sDWCud85bTS5fiD2NSKdY/FlULwF7Xaf7oeS0x /b9o7VY0hkK47nauYkU4yc/CYDA+LxKiVLY39YAcVK6+A3ui5nxxjJDF18AZDJ+o4qNj PHAQ== X-Gm-Message-State: AOAM530scXICu77x5b33e4V9GPXJtgfTBlrfzbN8C22pQFiF44oJhc2Y XX0a80lSOL0/PG+yYCZ+o1K497cOa9hITBvC X-Google-Smtp-Source: ABdhPJyIWUVccZyAXEsObevGW/HAb1nxmtfyuHFvXXaetFjntxj3sQMrjXfKIJTB0JRP1IXOQra5yw== X-Received: by 2002:a7b:c92a:: with SMTP id h10mr1473209wml.138.1605688984839; Wed, 18 Nov 2020 00:43:04 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id e1sm1894406wmd.16.2020.11.18.00.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 00:43:03 -0800 (PST) Date: Wed, 18 Nov 2020 08:43:02 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Philipp Zabel , David Airlie , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH 42/42] include/drm/drm_atomic: Make use of 'new_crtc_state' Message-ID: <20201118084302.GN1869941@dell> References: <20201116174112.1833368-1-lee.jones@linaro.org> <20201116174112.1833368-43-lee.jones@linaro.org> <20201117194241.GV401619@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201117194241.GV401619@phenom.ffwll.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Mon, Nov 16, 2020 at 05:41:12PM +0000, Lee Jones wrote: > > In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided > > as a container for state->crtcs[i].new_state, but is not utilised in > > some use-cases, so we fake-use it instead. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/imx/ipuv3-plane.c: In function ‘ipu_planes_assign_pre’: > > drivers/gpu/drm/imx/ipuv3-plane.c:746:42: warning: variable ‘crtc_state’ set but not used [-Wunused-but-set-variable] > > > > Cc: Philipp Zabel > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: Fabio Estevam > > Cc: NXP Linux Team > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > Ok I merged them all except: > - drm/amd and drm/imx, should be picked up already by respective > maintainers > - drm/msm, Rob promised to take care > > Thanks a lot for your patches. Perfect. Thank you for reviewing/merging them. > > --- > > include/drm/drm_atomic.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > > index dc5e0fbecc04e..54e051a957dfc 100644 > > --- a/include/drm/drm_atomic.h > > +++ b/include/drm/drm_atomic.h > > @@ -783,7 +783,8 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > > (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ > > (old_crtc_state) = (__state)->crtcs[__i].old_state, \ > > (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ > > - (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) > > + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ > > + (void)(new_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > > > /** > > * for_each_old_crtc_in_state - iterate over all CRTCs in an atomic update > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog