From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD1FC5519F for ; Wed, 18 Nov 2020 15:39:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADB2B20897 for ; Wed, 18 Nov 2020 15:39:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="phyYlJzI"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="fVm7YQ8j"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TqhBKuNe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADB2B20897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A996416A8; Wed, 18 Nov 2020 16:38:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A996416A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605713963; bh=47cw+Dx69ulWO/0BHF/ppFpJTJCmwVY75KKpUmzGRbc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=phyYlJzIoe7MFPkTOEttWIXyzGZYrArAaFSXyY507EUfbbo9ygdfK6RPrpSiGARRS 4YmIqjHOWUg9KMEMLqZ7aki4TBRLbdqmpj6pRogCu5zM11CeTtyxyd5oCnaVfu97BR i8Ex8EwSgTDFQU4HMTt6TvZq9thiLkDMJz7+b1Oc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 237D5F80168; Wed, 18 Nov 2020 16:38:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF6D7F8016C; Wed, 18 Nov 2020 16:38:29 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 575C4F80158 for ; Wed, 18 Nov 2020 16:38:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 575C4F80158 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="fVm7YQ8j"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TqhBKuNe" Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 79F895803C7; Wed, 18 Nov 2020 10:38:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 18 Nov 2020 10:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=jiFRinBhroU8gF2dg+tsxbq0jYn 80Lj5IEmgVTmjZxQ=; b=fVm7YQ8jpspmpzPYfV/ipmzCzVB77F1xuT0tVIAL222 sWkdad23hFwGGBOjR/DsrS4ToGE2s6dgJ4mCifZkVTC+5CxV2nRvi3Fy3PLLtiKc A6BxyThaixitas2h07F7QU+PWkjLLqcDXTEzXp33QLXrujnaoK2k/vPHbTWSHDkR sm8xpp+xDNwndRn++5soUOffme25aXRqGuwsRdaXP9112HRwyCskbf9e2o3W5XIB ywCxcovtVSmE6HUMVPnDeajtGBOcqNxLKUzo9/0/X9qclG8XzVft8qm6yN7MThig D98YndIEmJ0b3HK2Pc88jzsa2nmKaPD6zJD2Q0pTWew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jiFRin BhroU8gF2dg+tsxbq0jYn80Lj5IEmgVTmjZxQ=; b=TqhBKuNe1VVa182VvJuctB bvbOXPFd7bqpiYPdAtuNw3jtU5FKFaoD60wB40xJo6S5fFZt2k/ic02lBo8fc9CS rvWQVy6Po/LEFGS+QSffxfPj3rwgpUuzIbLhV4BclAa3UeyD7vJSFzeUauspxjyy zTd6YI1pnhcAlh0qsZJj+PA5RZjp6pI8I7chd3NWThENGapjWaX7Mx/QUlRtnQHY zdUVn/OnZ04ujZEFw5Qm954gLqAVY/WygagJvLSUwWMkJKzRpiNMYnw/uRQx7imo vk1ROKIusbKWoL8ShMFu2qpY6626xdR2OxHL+pkZoRsw2OiOhy7PxXsZKr5grdwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B1AF93064AAF; Wed, 18 Nov 2020 10:38:17 -0500 (EST) Date: Wed, 18 Nov 2020 16:38:16 +0100 From: Maxime Ripard To: Krzysztof Kozlowski Subject: Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201118153816.fctrz6dfjiph2mgl@gilmour.lan> References: <20201117182310.73609-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6ukipbmjbi6ayno" Content-Disposition: inline In-Reply-To: <20201117182310.73609-1-krzk@kernel.org> Cc: Jernej Skrabec , alsa-devel@alsa-project.org, Samuel Holland , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Chen-Yu Tsai , Mark Brown , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --x6ukipbmjbi6ayno Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote: > COMMON_CLK is a user-selectable option with its own dependencies. The > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > should not select COMMON_CLK because they will create a dependency cycle > and build failures. For example on MIPS a configuration with COMMON_CLK > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > SOC_RT305X) is possible: >=20 > WARNING: unmet direct dependencies detected for COMMON_CLK > Depends on [n]: !HAVE_LEGACY_CLK [=3Dy] > Selected by [y]: > - SND_SUN8I_CODEC [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && SND= _SOC [=3Dy] && > (ARCH_SUNXI || COMPILE_TEST [=3Dy]) && OF [=3Dy] && (MACH_SUN8I || = ARM64 && ARCH_SUNXI || COMPILE_TEST [=3Dy]) >=20 > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_r= ate': > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/rali= nk/clk.o:(.text+0x88): first defined here >=20 > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Samuel Holland Acked-by: Maxime Ripard however, I'm not sure the prefix is the one Mark would expect? Maxime --x6ukipbmjbi6ayno Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7U/6AAKCRDj7w1vZxhR xUOAAP48nXr96GGEF754GEu/aKJQDqP5hJ6/mTDONuk2RUglHgD/Zdrpl1dzj8xT QlREWW9yHK4WzcLL4dqiaF1XVhXliQI= =47Fl -----END PGP SIGNATURE----- --x6ukipbmjbi6ayno-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56FDC63777 for ; Wed, 18 Nov 2020 15:39:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B025420897 for ; Wed, 18 Nov 2020 15:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ebv1/KZe"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="fVm7YQ8j"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TqhBKuNe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B025420897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qykd2CK3tJTjQRapgXhBrevLl9RFqBZSajOgqH8YS9o=; b=ebv1/KZeYpw2DFy7g4BvminpK Czo05WoT6wVAXKm9DBu896BhsC3tiXsBQ2W1mkiSMHkC1fDSXQk9oul4Z82O76nLQF0YrBIHdaMRa g5hSu905YQKW2WVGlOWNGy35QWmb49clBjXGkWh8bUysbXCC7aHUG78zwrSKR7OTzwvb3mdoqMOJl aiRWepZlY6mUnO79dHt09HDqTZnBhown4txVI03Db0WEyDKUD5PW+g+NBnwOVGBGX2UlNlAEq50C1 phVv6T1lAk5XTLQZnigT2Qd0HlU+q0palptjeQxexg4OB4RlEzJWm+d0dEocWA1h5BN/MquZyOoR4 lW+/NvPsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfPXQ-0005AG-AA; Wed, 18 Nov 2020 15:38:28 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfPXK-00058A-1o for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 15:38:23 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 79F895803C7; Wed, 18 Nov 2020 10:38:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 18 Nov 2020 10:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=jiFRinBhroU8gF2dg+tsxbq0jYn 80Lj5IEmgVTmjZxQ=; b=fVm7YQ8jpspmpzPYfV/ipmzCzVB77F1xuT0tVIAL222 sWkdad23hFwGGBOjR/DsrS4ToGE2s6dgJ4mCifZkVTC+5CxV2nRvi3Fy3PLLtiKc A6BxyThaixitas2h07F7QU+PWkjLLqcDXTEzXp33QLXrujnaoK2k/vPHbTWSHDkR sm8xpp+xDNwndRn++5soUOffme25aXRqGuwsRdaXP9112HRwyCskbf9e2o3W5XIB ywCxcovtVSmE6HUMVPnDeajtGBOcqNxLKUzo9/0/X9qclG8XzVft8qm6yN7MThig D98YndIEmJ0b3HK2Pc88jzsa2nmKaPD6zJD2Q0pTWew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jiFRin BhroU8gF2dg+tsxbq0jYn80Lj5IEmgVTmjZxQ=; b=TqhBKuNe1VVa182VvJuctB bvbOXPFd7bqpiYPdAtuNw3jtU5FKFaoD60wB40xJo6S5fFZt2k/ic02lBo8fc9CS rvWQVy6Po/LEFGS+QSffxfPj3rwgpUuzIbLhV4BclAa3UeyD7vJSFzeUauspxjyy zTd6YI1pnhcAlh0qsZJj+PA5RZjp6pI8I7chd3NWThENGapjWaX7Mx/QUlRtnQHY zdUVn/OnZ04ujZEFw5Qm954gLqAVY/WygagJvLSUwWMkJKzRpiNMYnw/uRQx7imo vk1ROKIusbKWoL8ShMFu2qpY6626xdR2OxHL+pkZoRsw2OiOhy7PxXsZKr5grdwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B1AF93064AAF; Wed, 18 Nov 2020 10:38:17 -0500 (EST) Date: Wed, 18 Nov 2020 16:38:16 +0100 From: Maxime Ripard To: Krzysztof Kozlowski Subject: Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201118153816.fctrz6dfjiph2mgl@gilmour.lan> References: <20201117182310.73609-1-krzk@kernel.org> MIME-Version: 1.0 In-Reply-To: <20201117182310.73609-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_103822_185456_9B5CB241 X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , alsa-devel@alsa-project.org, Samuel Holland , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Chen-Yu Tsai , Mark Brown , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1752348806506774307==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1752348806506774307== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6ukipbmjbi6ayno" Content-Disposition: inline --x6ukipbmjbi6ayno Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote: > COMMON_CLK is a user-selectable option with its own dependencies. The > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > should not select COMMON_CLK because they will create a dependency cycle > and build failures. For example on MIPS a configuration with COMMON_CLK > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > SOC_RT305X) is possible: >=20 > WARNING: unmet direct dependencies detected for COMMON_CLK > Depends on [n]: !HAVE_LEGACY_CLK [=3Dy] > Selected by [y]: > - SND_SUN8I_CODEC [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && SND= _SOC [=3Dy] && > (ARCH_SUNXI || COMPILE_TEST [=3Dy]) && OF [=3Dy] && (MACH_SUN8I || = ARM64 && ARCH_SUNXI || COMPILE_TEST [=3Dy]) >=20 > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_r= ate': > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/rali= nk/clk.o:(.text+0x88): first defined here >=20 > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Samuel Holland Acked-by: Maxime Ripard however, I'm not sure the prefix is the one Mark would expect? Maxime --x6ukipbmjbi6ayno Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7U/6AAKCRDj7w1vZxhR xUOAAP48nXr96GGEF754GEu/aKJQDqP5hJ6/mTDONuk2RUglHgD/Zdrpl1dzj8xT QlREWW9yHK4WzcLL4dqiaF1XVhXliQI= =47Fl -----END PGP SIGNATURE----- --x6ukipbmjbi6ayno-- --===============1752348806506774307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1752348806506774307==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B698C63798 for ; Wed, 18 Nov 2020 15:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0F5B24779 for ; Wed, 18 Nov 2020 15:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgKRPiV (ORCPT ); Wed, 18 Nov 2020 10:38:21 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:58261 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgKRPiU (ORCPT ); Wed, 18 Nov 2020 10:38:20 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 79F895803C7; Wed, 18 Nov 2020 10:38:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 18 Nov 2020 10:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=jiFRinBhroU8gF2dg+tsxbq0jYn 80Lj5IEmgVTmjZxQ=; b=fVm7YQ8jpspmpzPYfV/ipmzCzVB77F1xuT0tVIAL222 sWkdad23hFwGGBOjR/DsrS4ToGE2s6dgJ4mCifZkVTC+5CxV2nRvi3Fy3PLLtiKc A6BxyThaixitas2h07F7QU+PWkjLLqcDXTEzXp33QLXrujnaoK2k/vPHbTWSHDkR sm8xpp+xDNwndRn++5soUOffme25aXRqGuwsRdaXP9112HRwyCskbf9e2o3W5XIB ywCxcovtVSmE6HUMVPnDeajtGBOcqNxLKUzo9/0/X9qclG8XzVft8qm6yN7MThig D98YndIEmJ0b3HK2Pc88jzsa2nmKaPD6zJD2Q0pTWew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jiFRin BhroU8gF2dg+tsxbq0jYn80Lj5IEmgVTmjZxQ=; b=TqhBKuNe1VVa182VvJuctB bvbOXPFd7bqpiYPdAtuNw3jtU5FKFaoD60wB40xJo6S5fFZt2k/ic02lBo8fc9CS rvWQVy6Po/LEFGS+QSffxfPj3rwgpUuzIbLhV4BclAa3UeyD7vJSFzeUauspxjyy zTd6YI1pnhcAlh0qsZJj+PA5RZjp6pI8I7chd3NWThENGapjWaX7Mx/QUlRtnQHY zdUVn/OnZ04ujZEFw5Qm954gLqAVY/WygagJvLSUwWMkJKzRpiNMYnw/uRQx7imo vk1ROKIusbKWoL8ShMFu2qpY6626xdR2OxHL+pkZoRsw2OiOhy7PxXsZKr5grdwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B1AF93064AAF; Wed, 18 Nov 2020 10:38:17 -0500 (EST) Date: Wed, 18 Nov 2020 16:38:16 +0100 From: Maxime Ripard To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201118153816.fctrz6dfjiph2mgl@gilmour.lan> References: <20201117182310.73609-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6ukipbmjbi6ayno" Content-Disposition: inline In-Reply-To: <20201117182310.73609-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x6ukipbmjbi6ayno Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote: > COMMON_CLK is a user-selectable option with its own dependencies. The > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > should not select COMMON_CLK because they will create a dependency cycle > and build failures. For example on MIPS a configuration with COMMON_CLK > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > SOC_RT305X) is possible: >=20 > WARNING: unmet direct dependencies detected for COMMON_CLK > Depends on [n]: !HAVE_LEGACY_CLK [=3Dy] > Selected by [y]: > - SND_SUN8I_CODEC [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && SND= _SOC [=3Dy] && > (ARCH_SUNXI || COMPILE_TEST [=3Dy]) && OF [=3Dy] && (MACH_SUN8I || = ARM64 && ARCH_SUNXI || COMPILE_TEST [=3Dy]) >=20 > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_r= ate': > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/rali= nk/clk.o:(.text+0x88): first defined here >=20 > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Samuel Holland Acked-by: Maxime Ripard however, I'm not sure the prefix is the one Mark would expect? Maxime --x6ukipbmjbi6ayno Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7U/6AAKCRDj7w1vZxhR xUOAAP48nXr96GGEF754GEu/aKJQDqP5hJ6/mTDONuk2RUglHgD/Zdrpl1dzj8xT QlREWW9yHK4WzcLL4dqiaF1XVhXliQI= =47Fl -----END PGP SIGNATURE----- --x6ukipbmjbi6ayno--