From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B91C6379D for ; Thu, 19 Nov 2020 08:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBE6A246CE for ; Thu, 19 Nov 2020 08:09:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g+ix/XqX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbgKSIJJ (ORCPT ); Thu, 19 Nov 2020 03:09:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgKSIJJ (ORCPT ); Thu, 19 Nov 2020 03:09:09 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E87C0613CF for ; Thu, 19 Nov 2020 00:09:08 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id p6so142129plr.7 for ; Thu, 19 Nov 2020 00:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9YeX71DgvayKaBn55/9EguYcKXPkstIm7k9o5hsUwd4=; b=g+ix/XqX7fwT7g0wx9jHzdNVXBba7Yu/WJLfwnSiMAdEPtKmmo/hM2oxQqWdpVCuJc 1KKLUOoRuaP/w+gSYU2/zRs79JTHFJoYO8dp/VJf++5VYfEWVv0zVrHk9Hwy/4KMy6Pt MWnZi7QlYNMj2wK1pSc9AhtHWr8D+xWicSX8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9YeX71DgvayKaBn55/9EguYcKXPkstIm7k9o5hsUwd4=; b=kjTFEgej1F42fogGV/OKwHL23i++qwdIyl3unln+QckKY+fAyPhb8PP62c12S+mT1j L4J14glhLD/nyXFLjUOll1M8hPax+McWc1dlTkbPXHKhQh163p2EDHknAc/bsCqXhHdO 4Bp17jQ5R01sV+wHt5a0QplbLhTgJ/5Lbhkho9Jdco5NgMZWaPQKAjrW4zhpwhwx/3wv yTFCBJ9UY7WeurM8eUnnQ0ftpr7CiZsOBgFmtQflPD6mNN3Qan7aWF9K4e+EOxwFiwJb JY41M+YroLIoqL61YdXUC6AQ+dEjPopTZtuEnjVauzzPaPejSP7uh0ziAP8kAlKln7Dr XZ3Q== X-Gm-Message-State: AOAM531SD7i1LL7Pyn63TprYJsXPiP+WRbkwpf1eJq/ixwaA3USK3ecm wpTlpCZRljPJbLT2QRblj11o8JBkkdPpoQ== X-Google-Smtp-Source: ABdhPJyjgjvgkqU/XXSkUf6OeAkjb64BJmpaJrHCk6LYUKDVS3qmAt7paEzL1YBGyoPtbY4Zb+syyw== X-Received: by 2002:a17:902:a415:b029:d8:f55b:5e9b with SMTP id p21-20020a170902a415b02900d8f55b5e9bmr7492889plq.6.1605773348474; Thu, 19 Nov 2020 00:09:08 -0800 (PST) Received: from google.com ([2620:15c:202:201:a28c:fdff:fef0:49dd]) by smtp.gmail.com with ESMTPSA id a123sm29092392pfd.218.2020.11.19.00.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 00:09:08 -0800 (PST) Date: Thu, 19 Nov 2020 00:09:06 -0800 From: Prashant Malani To: Utkarsh Patel Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com, rajmohan.mani@intel.com, azhar.shaikh@intel.com Subject: Re: [PATCH v3 2/4] platform/chrome: cros_ec_typec: Use Thunderbolt 3 cable discover mode VDO in USB4 mode Message-ID: <20201119080906.GE3652649@google.com> References: <20201119063211.2264-1-utkarsh.h.patel@intel.com> <20201119063211.2264-3-utkarsh.h.patel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119063211.2264-3-utkarsh.h.patel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Utkarsh, On Wed, Nov 18, 2020 at 10:32:09PM -0800, Utkarsh Patel wrote: > Configure Thunderbolt 3 cable generation value by filling Thunderbolt 3 > cable discover mode VDO to support rounded Thunderbolt 3 cables. > While we are here use Thunderbolt 3 cable discover mode VDO to fill active > cable plug link training value. > > Suggested-by: Heikki Krogerus > Signed-off-by: Utkarsh Patel > > -- > Changes in v3: > - Added a check for cable's TBT support before filling TBT3 discover mode > VDO. > > Changes in v2: > - No change. > -- > --- > drivers/platform/chrome/cros_ec_typec.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 8111ed1fc574..68b17ee1d1ae 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -514,8 +514,18 @@ static int cros_typec_enable_usb4(struct cros_typec_data *typec, > else if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE) > data.eudo |= EUDO_CABLE_TYPE_RE_TIMER << EUDO_CABLE_TYPE_SHIFT; > > - data.active_link_training = !!(pd_ctrl->control_flags & > - USB_PD_CTRL_ACTIVE_LINK_UNIDIR); > + /* > + * Filling TBT3 Cable VDO when TBT3 cable is being used to establish > + * USB4 connection. > + */ > + if (pd_ctrl->cable_gen) { > + data.tbt_cable_vdo = TBT_MODE; > + > + if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) > + data.tbt_cable_vdo |= TBT_CABLE_LINK_TRAINING; > + > + data.tbt_cable_vdo |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); > + } I think the following would decouple Rounded Support and Active Cable Link Training?: struct typec_thunderbolt_data data = {}; ... if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_LINK_UNIDIR) data.tbt_cable_vdo |= TBT_CABLE_LINK_TRAINING; data.tbt_cable_vdo |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen); if (data.tbt_cable_vdo) data.tbt_cable_vdo |= TBT_MODE; Best regards, -Prashant