From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92CCC2D0E4 for ; Thu, 19 Nov 2020 08:25:26 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 175FE246B0 for ; Thu, 19 Nov 2020 08:25:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 175FE246B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-PqTWgHS9Nw6ZcztKrv_XIQ-1; Thu, 19 Nov 2020 03:25:22 -0500 X-MC-Unique: PqTWgHS9Nw6ZcztKrv_XIQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8B8B1005D44; Thu, 19 Nov 2020 08:25:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69B7F189A5; Thu, 19 Nov 2020 08:25:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A124F180954D; Thu, 19 Nov 2020 08:25:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AJ8PEPm014112 for ; Thu, 19 Nov 2020 03:25:14 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1600B2166BA2; Thu, 19 Nov 2020 08:25:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10E532166B44 for ; Thu, 19 Nov 2020 08:25:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85C7F800962 for ; Thu, 19 Nov 2020 08:25:10 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-G-NEXkzLPTaMTfaLns4RKQ-1; Thu, 19 Nov 2020 03:25:07 -0500 X-MC-Unique: G-NEXkzLPTaMTfaLns4RKQ-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1FC9DAD2F; Thu, 19 Nov 2020 08:25:06 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id C74001E1303; Thu, 19 Nov 2020 09:25:05 +0100 (CET) Date: Thu, 19 Nov 2020 09:25:05 +0100 From: Jan Kara To: Christoph Hellwig Message-ID: <20201119082505.GS1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-8-hch@lst.de> <20201118143747.GL1981@quack2.suse.cz> <20201119075225.GA15815@lst.de> MIME-Version: 1.0 In-Reply-To: <20201119075225.GA15815@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Jan Kara , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mm@kvack.org Subject: Re: [dm-devel] [PATCH 07/20] init: refactor name_to_dev_t X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu 19-11-20 08:52:25, Christoph Hellwig wrote: > On Wed, Nov 18, 2020 at 03:37:47PM +0100, Jan Kara wrote: > > > -static inline dev_t blk_lookup_devt(const char *name, int partno) > > > -{ > > > - dev_t devt = MKDEV(0, 0); > > > - return devt; > > > -} > > > #endif /* CONFIG_BLOCK */ > > > > This hunk looks unrelated to the change? Also why you move the declaration > > outside the CONFIG_BLOCK ifdef? AFAICS blk_lookup_devt() still exists only > > when CONFIG_BLOCK is defined? Otherwise the patch looks good to me. > > blk_lookup_devt is a hack only for name_to_dev_t only referenced from > code under CONFIG_BLOCK now, as it didn't do anything before when > blk_lookup_devt returned 0. I guess I'll need to update the commit log > a little to mention this. OK, understood. Still it would seem more logical to leave blk_lookup_devt() declaration inside #ifdef CONFIG_BLOCK and just delete the !CONFIG_BLOCK definition (to make it clear we ever expect only users compiled when CONFIG_BLOCK is defined). But whatever... Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1873DC56201 for ; Thu, 19 Nov 2020 08:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF1FE246D1 for ; Thu, 19 Nov 2020 08:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725877AbgKSIZI (ORCPT ); Thu, 19 Nov 2020 03:25:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:52024 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgKSIZH (ORCPT ); Thu, 19 Nov 2020 03:25:07 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1FC9DAD2F; Thu, 19 Nov 2020 08:25:06 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id C74001E1303; Thu, 19 Nov 2020 09:25:05 +0100 (CET) Date: Thu, 19 Nov 2020 09:25:05 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/20] init: refactor name_to_dev_t Message-ID: <20201119082505.GS1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-8-hch@lst.de> <20201118143747.GL1981@quack2.suse.cz> <20201119075225.GA15815@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119075225.GA15815@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Thu 19-11-20 08:52:25, Christoph Hellwig wrote: > On Wed, Nov 18, 2020 at 03:37:47PM +0100, Jan Kara wrote: > > > -static inline dev_t blk_lookup_devt(const char *name, int partno) > > > -{ > > > - dev_t devt = MKDEV(0, 0); > > > - return devt; > > > -} > > > #endif /* CONFIG_BLOCK */ > > > > This hunk looks unrelated to the change? Also why you move the declaration > > outside the CONFIG_BLOCK ifdef? AFAICS blk_lookup_devt() still exists only > > when CONFIG_BLOCK is defined? Otherwise the patch looks good to me. > > blk_lookup_devt is a hack only for name_to_dev_t only referenced from > code under CONFIG_BLOCK now, as it didn't do anything before when > blk_lookup_devt returned 0. I guess I'll need to update the commit log > a little to mention this. OK, understood. Still it would seem more logical to leave blk_lookup_devt() declaration inside #ifdef CONFIG_BLOCK and just delete the !CONFIG_BLOCK definition (to make it clear we ever expect only users compiled when CONFIG_BLOCK is defined). But whatever... Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941DBC2D0E4 for ; Thu, 19 Nov 2020 08:26:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0DB7246B0 for ; Thu, 19 Nov 2020 08:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JAQjaZQK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0DB7246B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/qZHl2TCMj11X0lRnqbkFNjj1/ZiVJXoa6+Myv/sFp0=; b=JAQjaZQKHjKtpNf4cytq0BVhY AmHEkxywQV4/t7aXoPg2IfsGkAws647UlAmbLJwsPvxcU43ewNTDN6XWlGq4ILmsJpQyTcydZfbS/ LnO/jHTw3dOF+fNgcF21/SYu7Bsas9CGysKvmV+ypLGwN7Suc9sKWwVjwNbHjzbzvoNXk0d9N+Wjr p/OjKGJE+wM2Vzl7JHb7GQ3AKmToSms+dm0rdOQnKOQN0omisifdK4FhCAjCVBHXSIfIuVW5HGLbD AvC/vmjr/gYhNbPVkxalSEPvo5qsqILrwFBwcRgQSA6+O0h7UVpHu4eUMrn9b6Ndth1jCZ1p3dL/C Di4nfJxvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kffFe-0006GF-2u; Thu, 19 Nov 2020 08:25:10 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kffFb-0006Fh-Ib for linux-mtd@lists.infradead.org; Thu, 19 Nov 2020 08:25:08 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1FC9DAD2F; Thu, 19 Nov 2020 08:25:06 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id C74001E1303; Thu, 19 Nov 2020 09:25:05 +0100 (CET) Date: Thu, 19 Nov 2020 09:25:05 +0100 From: Jan Kara To: Christoph Hellwig Subject: Re: [PATCH 07/20] init: refactor name_to_dev_t Message-ID: <20201119082505.GS1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-8-hch@lst.de> <20201118143747.GL1981@quack2.suse.cz> <20201119075225.GA15815@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119075225.GA15815@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_032507_814045_473617B4 X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Jan Kara , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu 19-11-20 08:52:25, Christoph Hellwig wrote: > On Wed, Nov 18, 2020 at 03:37:47PM +0100, Jan Kara wrote: > > > -static inline dev_t blk_lookup_devt(const char *name, int partno) > > > -{ > > > - dev_t devt = MKDEV(0, 0); > > > - return devt; > > > -} > > > #endif /* CONFIG_BLOCK */ > > > > This hunk looks unrelated to the change? Also why you move the declaration > > outside the CONFIG_BLOCK ifdef? AFAICS blk_lookup_devt() still exists only > > when CONFIG_BLOCK is defined? Otherwise the patch looks good to me. > > blk_lookup_devt is a hack only for name_to_dev_t only referenced from > code under CONFIG_BLOCK now, as it didn't do anything before when > blk_lookup_devt returned 0. I guess I'll need to update the commit log > a little to mention this. OK, understood. Still it would seem more logical to leave blk_lookup_devt() declaration inside #ifdef CONFIG_BLOCK and just delete the !CONFIG_BLOCK definition (to make it clear we ever expect only users compiled when CONFIG_BLOCK is defined). But whatever... Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/