From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB48CC388F9 for ; Thu, 19 Nov 2020 09:43:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4706F246E0 for ; Thu, 19 Nov 2020 09:43:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w5tTbr66" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4706F246E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nk1yUltWvO+0DiHL+5jsSgtobCDDuYilbwnWTQsGmFk=; b=w5tTbr66UWGdSEvvNzFs9q5DV x1+difW+9CNMzrktqdeuaLm6MUAqntEa1+d6MWltKi1xab0fFVON6iPUaf+XpP9kXvXjCyVoGYM19 d5ixT9LAPk0PKt8stgrbTW5sBvovQHDXrVX+B9tQjG5UnNEVGp6vj7aht+XBBOfFKN8kJsmsmgPGI 5EpzscvN16hfKVVZamr+BS4olm3uTTtmh+S7Y++i5Tau9HRAg1G9ZCnKElw8KsXtwY+kHYGGSut7S y8gHWu4yjqDwCpAABJ8h0ZRarDlTsGN6r6nH/F8lyT0CrFTPLOaN1ssZq/XZEAuCoWS9NEY6CjL3I 14n5OGBUw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgS8-0002iR-SA; Thu, 19 Nov 2020 09:42:08 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgS6-0002hq-94 for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 09:42:07 +0000 Received: by mail-ed1-f65.google.com with SMTP id a15so5160523edy.1 for ; Thu, 19 Nov 2020 01:42:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3auPEnlipqCorigcU4BHjBL1ODSkT0upvIcBnwf2V8I=; b=RWjro7D0lRKWzDbyIKSnnI61sDCVhPSJebIKR7kC8m2ub6VkWLpnsaZn9H/2KnD1wG 13KvN2GVYn25UKpMh0rMhj9YS9RoUQuJJ5HcxHTNOHooMyc2Ego3lgM8p6q5P+inhqWe NnvabR3v/ku30dQPM+aXdu6RGZAa4jALwPFS+eksssUtHyPYEINWlmy/ktDmyy0MmYBc 24e1EwRWj2JjeeLOf+OnVPUo5/2CRHw0bVK1eJlyJXQnfRLOcbUjVexyibzZuI70c3Nc T5WHwACLsQ3M63ACqWiRs3/pZ+WSDY0ZLYz6MqSkKzZTowwvCQcwH+DjbWjLPfXZqm2L jpbA== X-Gm-Message-State: AOAM530D+oOFKDZMbaslLtqKL3zCqW1qq1sk2yaJf+9035xAAXM1I2PM 6bRIwgJK6aNrUCMuu3K43P4= X-Google-Smtp-Source: ABdhPJy9aK/v8lgD//8i81Okyz9z/08o/+z/Z/jVtCQN8EkcFIdhDPo/tTgCG6Gz3Q6sry9vOEiW2A== X-Received: by 2002:a05:6402:370:: with SMTP id s16mr28723329edw.50.1605778924729; Thu, 19 Nov 2020 01:42:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id s20sm14458997edw.26.2020.11.19.01.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 01:42:03 -0800 (PST) Date: Thu, 19 Nov 2020 10:42:01 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver Message-ID: <20201119094201.GA3841@kozik-lap> References: <20201113110409.13546-1-alice.guo@nxp.com> <20201113110409.13546-4-alice.guo@nxp.com> <20201114164128.GD14989@kozik-lap> <20201116161338.GB25108@kozik-lap> <20201118104226.GA23766@kozik-lap> <20201118141042.GA34654@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_044206_406728_26E4D3D3 X-CRM114-Status: GOOD ( 29.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Peng Fan , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMTksIDIwMjAgYXQgMDc6MzI6MTdBTSArMDAwMCwgQWxpY2UgR3VvIHdyb3Rl Ogo+IAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEtyenlzenRv ZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiA+IFNlbnQ6IDIwMjDlubQxMeaciDE45pel IDIyOjExCj4gPiBUbzogQWxpY2UgR3VvIDxhbGljZS5ndW9AbnhwLmNvbT4KPiA+IENjOiByb2Jo K2R0QGtlcm5lbC5vcmc7IHNoYXduZ3VvQGtlcm5lbC5vcmc7IHMuaGF1ZXJAcGVuZ3V0cm9uaXgu ZGU7Cj4gPiBkbC1saW51eC1pbXggPGxpbnV4LWlteEBueHAuY29tPjsgUGVuZyBGYW4gPHBlbmcu ZmFuQG54cC5jb20+Owo+ID4gZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5l bEB2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKPiA+IFN1YmplY3Q6IFJlOiBbRVhUXSBSZTogW1BBVENIIHYzIDQvNF0gc29jOiBpbXg4bTog Y2hhbmdlIHRvIHVzZSBwbGF0Zm9ybSBkcml2ZXIKPiA+IAo+ID4gQ2F1dGlvbjogRVhUIEVtYWls Cj4gPiAKPiA+IE9uIFdlZCwgTm92IDE4LCAyMDIwIGF0IDAyOjA3OjQxUE0gKzAwMDAsIEFsaWNl IEd1byB3cm90ZToKPiA+ID4KPiA+ID4KPiA+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQo+ID4gPiA+IEZyb206IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KPiA+ ID4gPiBTZW50OiAyMDIw5bm0MTHmnIgxOOaXpSAxODo0Mgo+ID4gPiA+IFRvOiBBbGljZSBHdW8g PGFsaWNlLmd1b0BueHAuY29tPgo+ID4gPiA+IENjOiByb2JoK2R0QGtlcm5lbC5vcmc7IHNoYXdu Z3VvQGtlcm5lbC5vcmc7IHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU7Cj4gPiA+ID4gZGwtbGludXgt aW14IDxsaW51eC1pbXhAbnhwLmNvbT47IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPjsKPiA+ ID4gPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVs Lm9yZzsKPiA+ID4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+ID4g PiBTdWJqZWN0OiBSZTogW0VYVF0gUmU6IFtQQVRDSCB2MyA0LzRdIHNvYzogaW14OG06IGNoYW5n ZSB0byB1c2UKPiA+ID4gPiBwbGF0Zm9ybSBkcml2ZXIKPiA+ID4gPgo+ID4gPiA+IENhdXRpb246 IEVYVCBFbWFpbAo+ID4gPiA+Cj4gPiA+ID4gT24gV2VkLCBOb3YgMTgsIDIwMjAgYXQgMTA6Mjg6 NDdBTSArMDAwMCwgQWxpY2UgR3VvIHdyb3RlOgo+ID4gPiA+ICA+Cj4gPiA+ID4gPiA+IElmIGl0 IGlzIHByb3Blcmx5IGV4cGxhaW5lZCBhbmQgdGhlcmUgaXMgbm8gb3RoZXIgd2F5IHRoZW4geWVz LAo+ID4gPiA+ID4gPiB5b3UgY291bGQuIEhlcmUsIGZvciBvbGQgRFRCcywgSSB3b3VsZCBwcmVm ZXIgdG8gdXNlCj4gPiA+ID4gPiA+IG9mX3BsYXRmb3JtX2RldmljZV9jcmVhdGUoKSBhbmQgYmlu ZCB0byAic29jIiBub2RlIChjaGlsZCBvZiByb290KS4KPiA+ID4gPiA+ID4gVGhpcyB3YXkgeW91 IHdvdWxkIGFsd2F5cyBoYXZlIGRldmljZSBhbmQgZXhhY3RseSBvbmUgZW50cnkKPiA+ID4gPiA+ ID4gcG9pbnQgZm9yIHRoZSBwcm9iZS4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBz dGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBpbXg4X3NvY19pbml0X2RyaXZlciA9IHsKPiA+ ID4gPiA+ICAgICAgIC5wcm9iZSA9IGlteDhfc29jX2luaXRfcHJvYmUsCj4gPiA+ID4gPiAgICAg ICAuZHJpdmVyID0gewo+ID4gPiA+ID4gICAgICAgICAgICAgICAubmFtZSA9ICJzb2NAMCIsCj4g PiA+ID4gPiAgICAgICB9LAo+ID4gPiA+ID4gfTsKPiA+ID4gPiA+IENhbiBJIHVzZSAic29jQDAi IHRvIG1hdGNoIHRoaXMgZHJpdmVyPyBJdCB3aWxsIG5vdCB1c2UKPiA+ID4gPiA+IG9mX3BsYXRm b3JtX2RldmljZV9jcmVhdGUoKS4gSXQgd2lsbCB1c2Ugb2ZfZmluZF9wcm9wZXJ0eSgpIHRvCj4g PiA+ID4gPiBkZXRlcm1pbmUgd2hldGhlciBhbmQgbnZtZW0tY2VsbHMgY2FuIGJlIHVzZWQuIElm IHRoZXJlIGlzIG5vCj4gPiA+ID4gPiBudm1lbS1jZWxscywKPiA+ID4gPiBpdCB3aWxsIHVzZSB0 aGUgb2xkIHdheSwgd2hpY2ggc3VwcG9ydHMgb2xkIERUQlMuIFRoZXJlIGlzIG5vIG5lZWQKPiA+ ID4gPiB0byBhZGQgbmV3IGNvbXBhdGlibGUuCj4gPiA+ID4KPiA+ID4gPiBObywgdGhlIHNvY0Aw IGlzIG5vdCBhIHByb3BlciBuYW1lIGZvciB0aGUgZHJpdmVyLgo+ID4gPgo+ID4gPiBJIGhhdmUg bm8gZ29vZCBpZGVhLCBwbGVhc2UgZ2l2ZSBzdWdnZXN0aW9uLiBTaG91bGQgSSBzdGlsbCBhZGQg bmV3IGNvbXBhdGlibGU/Cj4gPiA+IFNob3VsZCBJIHN0aWxsIGtlZXAgZGV2aWNlX2luaXRjYWxs PyBJZiB1c2UKPiA+ID4gb2ZfcGxhdGZvcm1fZGV2aWNlX2NyZWF0ZSgpLCB3aGljaCBub2RlIHNo b3VsZCBJIHVzZT8KPiA+IAo+ID4gSSBtZW50aW9uZWQgbXkgaWRlYSBpbiB0aGUgZW1haWwgYmVm b3JlIC0gb2ZfcGxhdGZvcm1fZGV2aWNlX2NyZWF0ZSgpIHRvIGJpbmQKPiA+IHRvIHRoZSBzb2Mg bm9kZS4gVGhpcyB3aWxsIGhhdmUgdG8gYmUgaW4gdGhlIGluaXRjYWxsLCB5b3UgZG9uJ3QgaGF2 ZSBhIGNob2ljZSB0bwo+ID4gYXZvaWQgaXQsIHNpbmNlIHRoZXJlIHdhcyBubyBjb21wYXRpYmxl IGJlZm9yZS4KPiA+Cj4gCj4gCW5vZGUgPSBvZl9maW5kX25vZGVfYnlfcGF0aCgiL3NvY0AwIik7 Cj4gCWlmICghbm9kZSkKPiAJCXJldHVybiAtRU5PREVWOwo+IAo+IAlwZGV2ID0gb2ZfcGxhdGZv cm1fZGV2aWNlX2NyZWF0ZShub2RlLCAiWFhYIiwgTlVMTCk7Cj4gCWlmICghcGRldikKPiAJCXJl dHVybiAtRU5PREVWOwo+IAo+IENhbm5vdCB1c2Ugb2ZfcGxhdGZvcm1fZGV2aWNlX2NyZWF0ZSBi ZWNhdXNlICJvZl9ub2RlX3Rlc3RfYW5kX3NldF9mbGFnKG5wLCBPRl9QT1BVTEFURUQpIiByZXR1 cm5zIHRydWUuCj4gb2ZfcGxhdGZvcm1fZGV2aWNlX2NyZWF0ZSBpcyB1c2VkIHRvIGNyZWF0ZSBw bGF0Zm9ybSBkZXZpY2UsIGJ1dCBzb2NAMCBpcyBjcmVhdGVkIGJ5IGNvbW1vbiBjb2RlLiBJIGRv bid0IGtub3cgaG93Cj4gdG8gYmluZCB0byB0aGUgc29jIG5vZGUuIFRoZSB3YXkgSSBkaWQgaW4g djMgc2VlbXMgbm90IGJhZCwgaXQgY2FuIHdvcmsgY29ycmVjdGx5IGFuZCBzdXBwb3J0IG9sZCBE VEJzLiBDYW4gSSBrZWVwIHRoaXMgd2F5PwoKSW5kZWVkLCBpdCB3b3VsZCByZXF1aXJlIHNvbWUg bW9yZSBoYWNrcyBhbmQgYWN0dWFsbHkgbWlnaHQgbm90IHdvcmsgYXQKYWxsIHNpbmNlIGJ1cyBk ZXZpY2UgaXMgYWxyZWFkeSBjcmVhdGVkLiBLZWVwIHRoZSBvbGQgd2F5IGFuZCBmaXggb3RoZXIK cG9pbnRlZCBvdXQgaXNzdWVzLgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A84C2D0E4 for ; Thu, 19 Nov 2020 09:42:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C879B2469D for ; Thu, 19 Nov 2020 09:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726740AbgKSJmH convert rfc822-to-8bit (ORCPT ); Thu, 19 Nov 2020 04:42:07 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:32791 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbgKSJmH (ORCPT ); Thu, 19 Nov 2020 04:42:07 -0500 Received: by mail-ed1-f68.google.com with SMTP id k4so5164658edl.0; Thu, 19 Nov 2020 01:42:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3auPEnlipqCorigcU4BHjBL1ODSkT0upvIcBnwf2V8I=; b=Ltaa/tHJGpYIAD9TUO6XSrAhfNOlE1XcECAl/PBwFC3PM3GGfoYwMW3t3poQvAqpxC 8CSRVd0DhSixNun5AD7AyRuL1ednH8go/Ofwik+IpeD4KPYJ+mlC9xjeY41/CGBLgOwP gSWLfzWKh+sqiE/lRch2+vpO22dyNFk7HcUKL9r/Odt+qNvwc+2kqcWCKYwxNMQMTaXw h6hIYwbDy/NTnNGrwxP6KX3UZwNEL22KYEgilkfMt0sWnJbLdeY23/M9jV8xKknIwMd3 9aR1YMaiJDD/+VKf57OaqI5J+O3nH+OdzgMbd7ZtxlNM5001EiF4MotBZYfiRZCGqeKg AYaA== X-Gm-Message-State: AOAM532ir+7lywH5G7eXgM2wPtzS6lxmOOwElWrYqiuxvssNPXYjTeZ/ pVyb+Sv1w5MfXGgjIBSnOgY= X-Google-Smtp-Source: ABdhPJy9aK/v8lgD//8i81Okyz9z/08o/+z/Z/jVtCQN8EkcFIdhDPo/tTgCG6Gz3Q6sry9vOEiW2A== X-Received: by 2002:a05:6402:370:: with SMTP id s16mr28723329edw.50.1605778924729; Thu, 19 Nov 2020 01:42:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id s20sm14458997edw.26.2020.11.19.01.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 01:42:03 -0800 (PST) Date: Thu, 19 Nov 2020 10:42:01 +0100 From: Krzysztof Kozlowski To: Alice Guo Cc: "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , dl-linux-imx , Peng Fan , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver Message-ID: <20201119094201.GA3841@kozik-lap> References: <20201113110409.13546-1-alice.guo@nxp.com> <20201113110409.13546-4-alice.guo@nxp.com> <20201114164128.GD14989@kozik-lap> <20201116161338.GB25108@kozik-lap> <20201118104226.GA23766@kozik-lap> <20201118141042.GA34654@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 19, 2020 at 07:32:17AM +0000, Alice Guo wrote: > > > > -----Original Message----- > > From: Krzysztof Kozlowski > > Sent: 2020年11月18日 22:11 > > To: Alice Guo > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > dl-linux-imx ; Peng Fan ; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver > > > > Caution: EXT Email > > > > On Wed, Nov 18, 2020 at 02:07:41PM +0000, Alice Guo wrote: > > > > > > > > > > -----Original Message----- > > > > From: Krzysztof Kozlowski > > > > Sent: 2020年11月18日 18:42 > > > > To: Alice Guo > > > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > > > dl-linux-imx ; Peng Fan ; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org > > > > Subject: Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use > > > > platform driver > > > > > > > > Caution: EXT Email > > > > > > > > On Wed, Nov 18, 2020 at 10:28:47AM +0000, Alice Guo wrote: > > > > > > > > > > > If it is properly explained and there is no other way then yes, > > > > > > you could. Here, for old DTBs, I would prefer to use > > > > > > of_platform_device_create() and bind to "soc" node (child of root). > > > > > > This way you would always have device and exactly one entry > > > > > > point for the probe. > > > > > > > > > > > > > > > > static struct platform_driver imx8_soc_init_driver = { > > > > > .probe = imx8_soc_init_probe, > > > > > .driver = { > > > > > .name = "soc@0", > > > > > }, > > > > > }; > > > > > Can I use "soc@0" to match this driver? It will not use > > > > > of_platform_device_create(). It will use of_find_property() to > > > > > determine whether and nvmem-cells can be used. If there is no > > > > > nvmem-cells, > > > > it will use the old way, which supports old DTBS. There is no need > > > > to add new compatible. > > > > > > > > No, the soc@0 is not a proper name for the driver. > > > > > > I have no good idea, please give suggestion. Should I still add new compatible? > > > Should I still keep device_initcall? If use > > > of_platform_device_create(), which node should I use? > > > > I mentioned my idea in the email before - of_platform_device_create() to bind > > to the soc node. This will have to be in the initcall, you don't have a choice to > > avoid it, since there was no compatible before. > > > > node = of_find_node_by_path("/soc@0"); > if (!node) > return -ENODEV; > > pdev = of_platform_device_create(node, "XXX", NULL); > if (!pdev) > return -ENODEV; > > Cannot use of_platform_device_create because "of_node_test_and_set_flag(np, OF_POPULATED)" returns true. > of_platform_device_create is used to create platform device, but soc@0 is created by common code. I don't know how > to bind to the soc node. The way I did in v3 seems not bad, it can work correctly and support old DTBs. Can I keep this way? Indeed, it would require some more hacks and actually might not work at all since bus device is already created. Keep the old way and fix other pointed out issues. Best regards, Krzysztof