From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F510C388F9 for ; Thu, 19 Nov 2020 09:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7952221FB for ; Thu, 19 Nov 2020 09:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgKSJyN (ORCPT ); Thu, 19 Nov 2020 04:54:13 -0500 Received: from muru.com ([72.249.23.125]:48774 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726545AbgKSJyM (ORCPT ); Thu, 19 Nov 2020 04:54:12 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0F4DB80C1; Thu, 19 Nov 2020 09:54:18 +0000 (UTC) Date: Thu, 19 Nov 2020 11:54:09 +0200 From: Tony Lindgren To: Youling Tang Cc: Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm: Fix memleak in omap2xxx_clkt_vps_init Message-ID: <20201119095409.GN26857@atomide.com> References: <1605326818-13823-1-git-send-email-tangyouling@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605326818-13823-1-git-send-email-tangyouling@loongson.cn> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Youling Tang [201114 04:07]: > If the clk_register fails, we should free hw before function returns to > prevent memleak. Thanks applying both into omap-for-v5.11/soc. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF749C6369E for ; Thu, 19 Nov 2020 09:54:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36DE9221FB for ; Thu, 19 Nov 2020 09:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CLXpYaBh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36DE9221FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TVm9GzX7mcZT/Z86cFT8sDStMG1nsxHnWs7nCCaGXTI=; b=CLXpYaBhm8kPIb5NuLzLpgge/ L/2TQ/xKB9agLzCBogPbLE7wJPkgfCl+aH/TB77EzaIVuWkRpnSpCNPIn2rivSK47aqelO8qk9cBu GbE2h/51DhVvOoA6wWlQflXHf4GagrYZrICps0wzhfUWih1ZDfN3+k9zj4IuykB0/imHE4QsNoZ85 EOVBEOPg86Nqt+/0MCG926sRVAZVOyQzNq8P/vnGnFdGxTvZqSCjQhQmByhMzgl/YYMgybd8dwspd 9JE9vT/ZbS6zyZkrb3rl1+e7yzQdllLSTEw+ud0QCV3YlFQciMP8Sa4UruIm7XOZXnFofOcLnw0FT LTUa+jKmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgdr-0004RF-F8; Thu, 19 Nov 2020 09:54:15 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgdo-0004Qb-PV for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 09:54:13 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0F4DB80C1; Thu, 19 Nov 2020 09:54:18 +0000 (UTC) Date: Thu, 19 Nov 2020 11:54:09 +0200 From: Tony Lindgren To: Youling Tang Subject: Re: [PATCH 1/2] arm: Fix memleak in omap2xxx_clkt_vps_init Message-ID: <20201119095409.GN26857@atomide.com> References: <1605326818-13823-1-git-send-email-tangyouling@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1605326818-13823-1-git-send-email-tangyouling@loongson.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_045412_941114_04B85BDE X-CRM114-Status: UNSURE ( 8.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Youling Tang [201114 04:07]: > If the clk_register fails, we should free hw before function returns to > prevent memleak. Thanks applying both into omap-for-v5.11/soc. Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel