From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CE8C2D0E4 for ; Thu, 19 Nov 2020 10:33:12 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E52C221F1 for ; Thu, 19 Nov 2020 10:33:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E52C221F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-WcOWcCsDOdmdQ38fbUXTcA-1; Thu, 19 Nov 2020 05:33:07 -0500 X-MC-Unique: WcOWcCsDOdmdQ38fbUXTcA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96B1B801B18; Thu, 19 Nov 2020 10:33:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6607310016F5; Thu, 19 Nov 2020 10:33:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 01B5E180954D; Thu, 19 Nov 2020 10:33:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AJAX0ER004230 for ; Thu, 19 Nov 2020 05:33:00 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7151DC77E0; Thu, 19 Nov 2020 10:33:00 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BF9AC77DE for ; Thu, 19 Nov 2020 10:32:58 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 51CE5801232 for ; Thu, 19 Nov 2020 10:32:58 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299--6MJDipgPd6MA5-wau0O2Q-1; Thu, 19 Nov 2020 05:32:55 -0500 X-MC-Unique: -6MJDipgPd6MA5-wau0O2Q-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3937FACBA; Thu, 19 Nov 2020 10:32:54 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D5CBE1E130B; Thu, 19 Nov 2020 11:32:53 +0100 (CET) Date: Thu, 19 Nov 2020 11:32:53 +0100 From: Jan Kara To: Christoph Hellwig Message-ID: <20201119103253.GV1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-14-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20201118084800.2339180-14-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mm@kvack.org Subject: Re: [dm-devel] [PATCH 13/20] block: remove ->bd_contains X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed 18-11-20 09:47:53, Christoph Hellwig wrote: > Now that each hd_struct has a reference to the corresponding > block_device, there is no need for the bd_contains pointer. Add > a bdev_whole() helper to look up the whole device block_device > struture instead. > > Signed-off-by: Christoph Hellwig Just two nits below. Otherwise feel free to add: Reviewed-by: Jan Kara > @@ -1521,7 +1510,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, void *holder, > if (bdev->bd_bdi == &noop_backing_dev_info) > bdev->bd_bdi = bdi_get(disk->queue->backing_dev_info); > } else { > - if (bdev->bd_contains == bdev) { > + if (!bdev->bd_partno) { This should be !bdev_is_partition(bdev) for consistency, right? > ret = 0; > if (bdev->bd_disk->fops->open) > ret = bdev->bd_disk->fops->open(bdev, mode); ... > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 0069bee992063e..453b940b87d8e9 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -32,7 +32,6 @@ struct block_device { > #ifdef CONFIG_SYSFS > struct list_head bd_holder_disks; > #endif > - struct block_device * bd_contains; > u8 bd_partno; > struct hd_struct * bd_part; > /* number of times partitions within this device have been opened. */ > @@ -48,6 +47,9 @@ struct block_device { > struct mutex bd_fsfreeze_mutex; > } __randomize_layout; > > +#define bdev_whole(_bdev) \ > + ((_bdev)->bd_disk->part0.bdev) > + > #define bdev_kobj(_bdev) \ > (&part_to_dev((_bdev)->bd_part)->kobj) I'd somewhat prefer if these helpers could actually be inline functions and not macros. I guess they are macros because hd_struct isn't in blk_types.h. But if we moved helpers to blkdev.h, we'd have all definitions we need... Is that a problem for some users? Honza -- Jan Kara SUSE Labs, CR -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95EE9C388F9 for ; Thu, 19 Nov 2020 10:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 472FA221F1 for ; Thu, 19 Nov 2020 10:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgKSKc4 (ORCPT ); Thu, 19 Nov 2020 05:32:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:34386 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726274AbgKSKc4 (ORCPT ); Thu, 19 Nov 2020 05:32:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3937FACBA; Thu, 19 Nov 2020 10:32:54 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D5CBE1E130B; Thu, 19 Nov 2020 11:32:53 +0100 (CET) Date: Thu, 19 Nov 2020 11:32:53 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 13/20] block: remove ->bd_contains Message-ID: <20201119103253.GV1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118084800.2339180-14-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed 18-11-20 09:47:53, Christoph Hellwig wrote: > Now that each hd_struct has a reference to the corresponding > block_device, there is no need for the bd_contains pointer. Add > a bdev_whole() helper to look up the whole device block_device > struture instead. > > Signed-off-by: Christoph Hellwig Just two nits below. Otherwise feel free to add: Reviewed-by: Jan Kara > @@ -1521,7 +1510,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, void *holder, > if (bdev->bd_bdi == &noop_backing_dev_info) > bdev->bd_bdi = bdi_get(disk->queue->backing_dev_info); > } else { > - if (bdev->bd_contains == bdev) { > + if (!bdev->bd_partno) { This should be !bdev_is_partition(bdev) for consistency, right? > ret = 0; > if (bdev->bd_disk->fops->open) > ret = bdev->bd_disk->fops->open(bdev, mode); ... > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 0069bee992063e..453b940b87d8e9 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -32,7 +32,6 @@ struct block_device { > #ifdef CONFIG_SYSFS > struct list_head bd_holder_disks; > #endif > - struct block_device * bd_contains; > u8 bd_partno; > struct hd_struct * bd_part; > /* number of times partitions within this device have been opened. */ > @@ -48,6 +47,9 @@ struct block_device { > struct mutex bd_fsfreeze_mutex; > } __randomize_layout; > > +#define bdev_whole(_bdev) \ > + ((_bdev)->bd_disk->part0.bdev) > + > #define bdev_kobj(_bdev) \ > (&part_to_dev((_bdev)->bd_part)->kobj) I'd somewhat prefer if these helpers could actually be inline functions and not macros. I guess they are macros because hd_struct isn't in blk_types.h. But if we moved helpers to blkdev.h, we'd have all definitions we need... Is that a problem for some users? Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC29C388F9 for ; Thu, 19 Nov 2020 10:33:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F38E422202 for ; Thu, 19 Nov 2020 10:33:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DGEsP3O7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F38E422202 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M50O34Bo+4/stE+aNMBFMeyab+J/5wyror3QFbguwTQ=; b=DGEsP3O7vImzVSMdxXkREEHx/ f36xJKNdq2pUS7so4P2M2+gcmuFnAhrV+N0tr/JudRO5LWHhRVz7Nx+GLsKKET0NGPzhwWtrz7ATc e5YhgA+kqOQiqV9ppZQ575Oua0wUJNII1u4KqXnw3TRODgGRPhxJbgYkwiKRDiBQTF9+cDL5d5LAY HH6GpoMbozW0Z4KgZVdcKMMKyro2DcNvdgtLS3GjBrEzeX1tsaTy8BEJa2JGJxH+RtSSyHwSi0Rd7 s9O8yI0l9TO0AgvOVv/k9tjwMDF1lwS8rHXE05Y36LDw3o8OjmFkHPlEDjSgMftbyOCmO+Nw+M+Mm SWDJJzQeQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfhFK-0008Cu-8M; Thu, 19 Nov 2020 10:32:58 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfhFI-0008Br-1z for linux-mtd@lists.infradead.org; Thu, 19 Nov 2020 10:32:56 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3937FACBA; Thu, 19 Nov 2020 10:32:54 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D5CBE1E130B; Thu, 19 Nov 2020 11:32:53 +0100 (CET) Date: Thu, 19 Nov 2020 11:32:53 +0100 From: Jan Kara To: Christoph Hellwig Subject: Re: [PATCH 13/20] block: remove ->bd_contains Message-ID: <20201119103253.GV1981@quack2.suse.cz> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-14-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201118084800.2339180-14-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_053256_248570_4CAB121B X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed 18-11-20 09:47:53, Christoph Hellwig wrote: > Now that each hd_struct has a reference to the corresponding > block_device, there is no need for the bd_contains pointer. Add > a bdev_whole() helper to look up the whole device block_device > struture instead. > > Signed-off-by: Christoph Hellwig Just two nits below. Otherwise feel free to add: Reviewed-by: Jan Kara > @@ -1521,7 +1510,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, void *holder, > if (bdev->bd_bdi == &noop_backing_dev_info) > bdev->bd_bdi = bdi_get(disk->queue->backing_dev_info); > } else { > - if (bdev->bd_contains == bdev) { > + if (!bdev->bd_partno) { This should be !bdev_is_partition(bdev) for consistency, right? > ret = 0; > if (bdev->bd_disk->fops->open) > ret = bdev->bd_disk->fops->open(bdev, mode); ... > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 0069bee992063e..453b940b87d8e9 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -32,7 +32,6 @@ struct block_device { > #ifdef CONFIG_SYSFS > struct list_head bd_holder_disks; > #endif > - struct block_device * bd_contains; > u8 bd_partno; > struct hd_struct * bd_part; > /* number of times partitions within this device have been opened. */ > @@ -48,6 +47,9 @@ struct block_device { > struct mutex bd_fsfreeze_mutex; > } __randomize_layout; > > +#define bdev_whole(_bdev) \ > + ((_bdev)->bd_disk->part0.bdev) > + > #define bdev_kobj(_bdev) \ > (&part_to_dev((_bdev)->bd_part)->kobj) I'd somewhat prefer if these helpers could actually be inline functions and not macros. I guess they are macros because hd_struct isn't in blk_types.h. But if we moved helpers to blkdev.h, we'd have all definitions we need... Is that a problem for some users? Honza -- Jan Kara SUSE Labs, CR ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/