From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDC0C2D0E4 for ; Thu, 19 Nov 2020 13:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DD6322264 for ; Thu, 19 Nov 2020 13:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgKSNes (ORCPT ); Thu, 19 Nov 2020 08:34:48 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38160 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbgKSNer (ORCPT ); Thu, 19 Nov 2020 08:34:47 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kfk4z-007w8v-Lm; Thu, 19 Nov 2020 14:34:29 +0100 Date: Thu, 19 Nov 2020 14:34:29 +0100 From: Andrew Lunn To: Baruch Siach Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/5] gpio: mvebu: add pwm support for Armada 8K/7K Message-ID: <20201119133429.GS1804098@lunn.ch> References: <20201118231811.GH1853236@lunn.ch> <878sax6f43.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878sax6f43.fsf@tarshish> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org > >> @@ -1200,6 +1235,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev) > >> > >> devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); > >> > >> + /* Some MVEBU SoCs have simple PWM support for GPIO lines */ > >> + if (IS_ENABLED(CONFIG_PWM)) { > >> + err = mvebu_pwm_probe(pdev, mvchip, id); > >> + if (err) > >> + return err; > >> + } > >> + > > > > The existing error handling looks odd here. Why is there no goto > > err_domain when probing the PWMs fails? I wonder if this a bug from me > > from a long time again? > > What would you release under the err_domain label? As far as I can see > all resources are allocated using devres, and released automatically on > failure exit. The IRQ domain is still registers. So once the memory is automatically freed, don't we have a potential use after free? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB2DC2D0E4 for ; Thu, 19 Nov 2020 13:36:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1132B2080A for ; Thu, 19 Nov 2020 13:36:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pTE8h46b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1132B2080A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0he2ttqOY1gxePntw9rZC1NvyiLhnzEtJv/yNyCeXPo=; b=pTE8h46b0bMerGgDFAgl2aweM sqqO2gO9BAj6TPLH+QuTPhChySSFcTHqMr2LcFURVW6GdfmaXx6H6U2YQyV2AaEwQsW2/HsBCrCQq OYYAQ0b215g/dDpZNQFmlS7knswXbbxn0CnZyWuoCMQ5hlt12uqJZfKcTAs1EZP442Z9CQVR/kNUv EiZNDNgifavLhO9j+hTV7B0+psdNz2YCS6p77Ar4kySwt4eOLDSu03eAJ687IL+tUt9JKE32dZo5u jGBbZ1Q1022S4rzdS0UzFECaZ86mSpfDAY5beiTzgjYqoB/R4POqUO1Q4vBGjlpUs/C6yMFUCadUk V39ZgkW9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfk5P-0000vS-0Y; Thu, 19 Nov 2020 13:34:55 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfk5L-0000uq-HS for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 13:34:52 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kfk4z-007w8v-Lm; Thu, 19 Nov 2020 14:34:29 +0100 Date: Thu, 19 Nov 2020 14:34:29 +0100 From: Andrew Lunn To: Baruch Siach Subject: Re: [PATCH 3/5] gpio: mvebu: add pwm support for Armada 8K/7K Message-ID: <20201119133429.GS1804098@lunn.ch> References: <20201118231811.GH1853236@lunn.ch> <878sax6f43.fsf@tarshish> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878sax6f43.fsf@tarshish> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_083451_680284_D94C98F2 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Sascha Hauer , Jason Cooper , linux-gpio@vger.kernel.org, Linus Walleij , Chris Packham , Bartosz Golaszewski , Thierry Reding , Thomas Petazzoni , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Ralph Sennhauser , Lee Jones , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > >> @@ -1200,6 +1235,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev) > >> > >> devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); > >> > >> + /* Some MVEBU SoCs have simple PWM support for GPIO lines */ > >> + if (IS_ENABLED(CONFIG_PWM)) { > >> + err = mvebu_pwm_probe(pdev, mvchip, id); > >> + if (err) > >> + return err; > >> + } > >> + > > > > The existing error handling looks odd here. Why is there no goto > > err_domain when probing the PWMs fails? I wonder if this a bug from me > > from a long time again? > > What would you release under the err_domain label? As far as I can see > all resources are allocated using devres, and released automatically on > failure exit. The IRQ domain is still registers. So once the memory is automatically freed, don't we have a potential use after free? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel