From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org
Subject: Re: [RFC 0/2] Introduce perf-stat -b for BPF programs
Date: Thu, 19 Nov 2020 11:52:46 -0300 [thread overview]
Message-ID: <20201119145246.GJ692998@kernel.org> (raw)
In-Reply-To: <20201119045046.1491106-1-songliubraving@fb.com>
Em Wed, Nov 18, 2020 at 08:50:44PM -0800, Song Liu escreveu:
> This set introduces perf-stat -b option to count events for BPF programs.
> This is similar to bpftool-prog-profile. But perf-stat makes it much more
> flexible.
>
> Sending as RFC because I would like comments on some key design choices:
> 1. We are using BPF skeletons here, which is by far the easiest way to
> write and ship BPF programs. However, this requires bpftool, which
> makes building perf slower.
> 2. A Makefile is added to tools/perf/util/bpf_skel/ to build bpftool,
> and BPF skeletons. This keeps main perf Makefiles simple. But we may
> not like it for some reason?
I'll review it in detail, but before that: thanks a lot for working on
this! Looks super cool from a first quick look. :-)
- Arnaldo
> Some known limitations (or work to be done):
> 1. Only counting events for one BPF program at a time.
> 2. Need extra logic in target__validate().
> Song Liu (2):
> perf: support build BPF skeletons with perf
> perf-stat: enable counting events for BPF programs
>
> tools/build/Makefile.feature | 3 +-
> tools/perf/Makefile.config | 8 +
> tools/perf/Makefile.perf | 15 +-
> tools/perf/builtin-stat.c | 59 ++++-
> tools/perf/util/Build | 1 +
> tools/perf/util/bpf_counter.c | 215 ++++++++++++++++++
> tools/perf/util/bpf_counter.h | 71 ++++++
> tools/perf/util/bpf_skel/.gitignore | 3 +
> tools/perf/util/bpf_skel/Makefile | 71 ++++++
> .../util/bpf_skel/bpf_prog_profiler.bpf.c | 96 ++++++++
> tools/perf/util/bpf_skel/dummy.bpf.c | 19 ++
> tools/perf/util/evsel.c | 10 +
> tools/perf/util/evsel.h | 5 +
> tools/perf/util/target.h | 6 +
> 14 files changed, 571 insertions(+), 11 deletions(-)
> create mode 100644 tools/perf/util/bpf_counter.c
> create mode 100644 tools/perf/util/bpf_counter.h
> create mode 100644 tools/perf/util/bpf_skel/.gitignore
> create mode 100644 tools/perf/util/bpf_skel/Makefile
> create mode 100644 tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> create mode 100644 tools/perf/util/bpf_skel/dummy.bpf.c
>
> --
> 2.24.1
--
- Arnaldo
prev parent reply other threads:[~2020-11-19 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 4:50 [RFC 0/2] Introduce perf-stat -b for BPF programs Song Liu
2020-11-19 4:50 ` [RFC 1/2] perf: support build BPF skeletons with perf Song Liu
2020-11-22 23:27 ` Jiri Olsa
2020-11-24 23:47 ` Song Liu
2020-11-25 16:38 ` Jiri Olsa
2020-11-22 23:32 ` Jiri Olsa
2020-11-24 23:51 ` Song Liu
2020-11-22 23:35 ` Jiri Olsa
2020-11-24 23:52 ` Song Liu
2020-11-25 16:40 ` Jiri Olsa
2020-11-24 19:51 ` Jiri Olsa
2020-11-24 23:59 ` Song Liu
2020-11-24 19:51 ` Jiri Olsa
2020-11-24 23:53 ` Song Liu
2020-11-19 4:50 ` [RFC 2/2] perf-stat: enable counting events for BPF programs Song Liu
2020-11-23 23:47 ` Jiri Olsa
2020-11-24 23:31 ` Song Liu
2020-11-25 16:42 ` Jiri Olsa
2020-11-24 19:51 ` Jiri Olsa
2020-11-24 23:43 ` Song Liu
2020-11-25 0:02 ` Song Liu
2020-11-25 16:43 ` Jiri Olsa
2020-11-19 14:52 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119145246.GJ692998@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.