From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Eric Farman <farman@linux.ibm.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
Tony Krowiak <akrowiak@linux.ibm.com>
Subject: Re: [RFC PATCH 1/2] vfio-mdev: Wire in a request handler for mdev parent
Date: Thu, 19 Nov 2020 16:56:11 +0100 [thread overview]
Message-ID: <20201119165611.6a811d76.pasic@linux.ibm.com> (raw)
In-Reply-To: <20201119123026.1353cb3c.cohuck@redhat.com>
On Thu, 19 Nov 2020 12:30:26 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> > +static void vfio_mdev_request(void *device_data, unsigned int count)
> > +{
> > + struct mdev_device *mdev = device_data;
> > + struct mdev_parent *parent = mdev->parent;
> > +
> > + if (unlikely(!parent->ops->request))
>
> Hm. Do you think that all drivers should implement a ->request()
> callback?
@Tony: What do you think, does vfio_ap need something like this?
BTW how is this supposed to work in a setup where the one parent
has may children (like vfio_ap or the gpu slice and dice usecases).
After giving this some thought I'm under the impression, I don't
get the full picture yet.
Regards,
Halil
next prev parent reply other threads:[~2020-11-19 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 3:21 [RFC PATCH 0/2] Connect request callback to mdev and vfio-ccw Eric Farman
2020-11-17 3:21 ` [RFC PATCH 1/2] vfio-mdev: Wire in a request handler for mdev parent Eric Farman
2020-11-19 11:30 ` Cornelia Huck
2020-11-19 14:36 ` Eric Farman
2020-11-19 15:56 ` Halil Pasic [this message]
2020-11-20 11:17 ` Cornelia Huck
2020-11-23 19:12 ` Tony Krowiak
2020-11-19 16:27 ` Alex Williamson
2020-11-19 20:04 ` Eric Farman
2020-11-20 11:22 ` Cornelia Huck
2020-11-19 15:29 ` Halil Pasic
2020-11-17 3:21 ` [RFC PATCH 2/2] vfio-ccw: Wire in the request callback Eric Farman
2020-11-19 11:43 ` Cornelia Huck
2020-11-19 12:00 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119165611.6a811d76.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.