From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5437DC5519F for ; Fri, 20 Nov 2020 09:14:43 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FE6D2224C for ; Fri, 20 Nov 2020 09:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TTIb8ohQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FE6D2224C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4BCA085B36; Fri, 20 Nov 2020 09:14:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WfGsbYQ4iN6u; Fri, 20 Nov 2020 09:14:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 89F94867AA; Fri, 20 Nov 2020 09:14:39 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 66A14C1825; Fri, 20 Nov 2020 09:14:39 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id AE089C0891 for ; Fri, 20 Nov 2020 09:14:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 90F9C875CC for ; Fri, 20 Nov 2020 09:14:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2YIiBJhtWwQu for ; Fri, 20 Nov 2020 09:14:36 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by hemlock.osuosl.org (Postfix) with ESMTPS id 19B4C875C3 for ; Fri, 20 Nov 2020 09:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mNLnU8cl44VoAwmtF3N/cVr4YIhMWVFWr0ATljQRTes=; b=TTIb8ohQ+PwDq74N++0bgk2zll V4Tj1uTEh1nLpZA5CWmWqyId5ggC5fFNgj0pboCtHDqY3L67GCyZNuDKPhIyDglg/E86QFfp03+bI wGOy+rZdGneSYckkAgLWS4Lquu6jKns1/3RDzJtgxPXaG/cApFOXbxrjmFwxID+CMkn8bfg2ariPD q8PRJnZIyL/pF1pJzmkrZOIsiNWxi9EqbnrSKptOWKTutDymxTvJ3MTHzpDBEzdVC/iFZdmds1m9/ d0Edw6QH1c1pHG3bkB/sYhvaimIvfkENpPeia3BDp903NdAOst0DSmCRA3GxWKsouD7etMiOrv1DU Mvs7rk4A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2TH-0003xV-Ap; Fri, 20 Nov 2020 09:12:47 +0000 Date: Fri, 20 Nov 2020 09:12:47 +0000 From: Christoph Hellwig To: Christian Brauner Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120091247.GA14894@infradead.org> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120091044.ofkzgiwoyru23vc4@wittgenstein> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Cc: Lennart Poettering , Mimi Zohar , David Howells , Andreas Dilger , containers@lists.linux-foundation.org, Tycho Andersen , "Darrick J. Wong" , smbarber@chromium.org, Christoph Hellwig , linux-ext4@vger.kernel.org, Mrunal Patel , Kees Cook , Arnd Bergmann , Jann Horn , selinux@vger.kernel.org, Josh Triplett , linux-fsdevel@vger.kernel.org, Aleksa Sarai , Alexander Viro , Andy Lutomirski , OGAWA Hirofumi , Geoffrey Thomas , James Bottomley , John Johansen , Theodore Tso , Seth Forshee , Dmitry Kasatkin , Stephen Smalley , Jonathan Corbet , linux-security-module@vger.kernel.org, linux-audit@redhat.com, "Eric W. Biederman" , linux-api@vger.kernel.org, Casey Schaufler , Alban Crequy , linux-integrity@vger.kernel.org, Todd Kjos X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > Maybe you didn't see this or you're referring to xfstests but this > series contains a >=4000 lines long test-suite that validates all core > features with and without idmapped mounts. It's the last patch in this > version of the series and it's located in: > tools/testing/selftests/idmap_mounts. > > Everytime a filesystem is added this test-suite will be updated. We > would perfer if this test would be shipped with the kernel itself and > not in a separate test-suite such as xfstests. But we're happy to add > patches for the latter at some point too. selftests is a complete pain to use, partialy because it is not integrated with the framework we file system developers use (xfstests) and partially because having the test suite in the kernel tree really breaks a lot of the typical use cases. So I think we'll need to wire this up in the proper place instead. _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB124C64E7A for ; Fri, 20 Nov 2020 09:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BE9D2224C for ; Fri, 20 Nov 2020 09:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TTIb8ohQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbgKTJNE (ORCPT ); Fri, 20 Nov 2020 04:13:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgKTJND (ORCPT ); Fri, 20 Nov 2020 04:13:03 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E24C0613CF; Fri, 20 Nov 2020 01:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mNLnU8cl44VoAwmtF3N/cVr4YIhMWVFWr0ATljQRTes=; b=TTIb8ohQ+PwDq74N++0bgk2zll V4Tj1uTEh1nLpZA5CWmWqyId5ggC5fFNgj0pboCtHDqY3L67GCyZNuDKPhIyDglg/E86QFfp03+bI wGOy+rZdGneSYckkAgLWS4Lquu6jKns1/3RDzJtgxPXaG/cApFOXbxrjmFwxID+CMkn8bfg2ariPD q8PRJnZIyL/pF1pJzmkrZOIsiNWxi9EqbnrSKptOWKTutDymxTvJ3MTHzpDBEzdVC/iFZdmds1m9/ d0Edw6QH1c1pHG3bkB/sYhvaimIvfkENpPeia3BDp903NdAOst0DSmCRA3GxWKsouD7etMiOrv1DU Mvs7rk4A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2TH-0003xV-Ap; Fri, 20 Nov 2020 09:12:47 +0000 Date: Fri, 20 Nov 2020 09:12:47 +0000 From: Christoph Hellwig To: Christian Brauner Cc: "Darrick J. Wong" , Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Jann Horn , Seth Forshee , St??phane Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-audit@redhat.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120091247.GA14894@infradead.org> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120091044.ofkzgiwoyru23vc4@wittgenstein> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > Maybe you didn't see this or you're referring to xfstests but this > series contains a >=4000 lines long test-suite that validates all core > features with and without idmapped mounts. It's the last patch in this > version of the series and it's located in: > tools/testing/selftests/idmap_mounts. > > Everytime a filesystem is added this test-suite will be updated. We > would perfer if this test would be shipped with the kernel itself and > not in a separate test-suite such as xfstests. But we're happy to add > patches for the latter at some point too. selftests is a complete pain to use, partialy because it is not integrated with the framework we file system developers use (xfstests) and partially because having the test suite in the kernel tree really breaks a lot of the typical use cases. So I think we'll need to wire this up in the proper place instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAF2C5519F for ; Fri, 20 Nov 2020 13:54:49 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 189C222272 for ; Fri, 20 Nov 2020 13:54:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 189C222272 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-PM86gia-P6KX2ffdB90Exg-1; Fri, 20 Nov 2020 08:54:45 -0500 X-MC-Unique: PM86gia-P6KX2ffdB90Exg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53B52100C663; Fri, 20 Nov 2020 13:54:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C6295D6BA; Fri, 20 Nov 2020 13:54:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1DC711809CA1; Fri, 20 Nov 2020 13:54:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AK9foEc025199 for ; Fri, 20 Nov 2020 04:41:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id BBFA82026D5D; Fri, 20 Nov 2020 09:41:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B633B2026D48 for ; Fri, 20 Nov 2020 09:41:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24388800157 for ; Fri, 20 Nov 2020 09:41:47 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-RITY3WiQMf-Ko5mIDq1Luw-1; Fri, 20 Nov 2020 04:41:45 -0500 X-MC-Unique: RITY3WiQMf-Ko5mIDq1Luw-1 Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2TH-0003xV-Ap; Fri, 20 Nov 2020 09:12:47 +0000 Date: Fri, 20 Nov 2020 09:12:47 +0000 From: Christoph Hellwig To: Christian Brauner Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120091247.GA14894@infradead.org> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> MIME-Version: 1.0 In-Reply-To: <20201120091044.ofkzgiwoyru23vc4@wittgenstein> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Fri, 20 Nov 2020 08:54:26 -0500 Cc: Phil Estes , Lennart Poettering , Mimi Zohar , David Howells , Andreas Dilger , containers@lists.linux-foundation.org, Tycho Andersen , "Darrick J. Wong" , James Morris , smbarber@chromium.org, Christoph Hellwig , linux-ext4@vger.kernel.org, Mrunal Patel , Serge Hallyn , Arnd Bergmann , Jann Horn , selinux@vger.kernel.org, Josh Triplett , linux-fsdevel@vger.kernel.org, Aleksa Sarai , Alexander Viro , Andy Lutomirski , OGAWA Hirofumi , Geoffrey Thomas , James Bottomley , John Johansen , Theodore Tso , Seth Forshee , Dmitry Kasatkin , Jonathan Corbet , linux-security-module@vger.kernel.org, linux-audit@redhat.com, "Eric W. Biederman" , linux-api@vger.kernel.org, Alban Crequy , linux-integrity@vger.kernel.org, St??phane Graber , Todd Kjos X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > Maybe you didn't see this or you're referring to xfstests but this > series contains a >=4000 lines long test-suite that validates all core > features with and without idmapped mounts. It's the last patch in this > version of the series and it's located in: > tools/testing/selftests/idmap_mounts. > > Everytime a filesystem is added this test-suite will be updated. We > would perfer if this test would be shipped with the kernel itself and > not in a separate test-suite such as xfstests. But we're happy to add > patches for the latter at some point too. selftests is a complete pain to use, partialy because it is not integrated with the framework we file system developers use (xfstests) and partially because having the test suite in the kernel tree really breaks a lot of the typical use cases. So I think we'll need to wire this up in the proper place instead. -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit