From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764E2C5519F for ; Fri, 20 Nov 2020 09:17:36 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4C872224C for ; Fri, 20 Nov 2020 09:17:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4C872224C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-cvtmcI3NPyiFJdxnKvNdUA-1; Fri, 20 Nov 2020 04:17:32 -0500 X-MC-Unique: cvtmcI3NPyiFJdxnKvNdUA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 630241005D59; Fri, 20 Nov 2020 09:17:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BB4019D9B; Fri, 20 Nov 2020 09:17:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C7EE44BB7B; Fri, 20 Nov 2020 09:17:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AK9HOoP022163 for ; Fri, 20 Nov 2020 04:17:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7F6A3E779D; Fri, 20 Nov 2020 09:17:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78DA0E77A3 for ; Fri, 20 Nov 2020 09:17:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4DC5E186E121 for ; Fri, 20 Nov 2020 09:17:22 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-Vy4CPgg-OZSajnRCYw94Ow-1; Fri, 20 Nov 2020 04:17:17 -0500 X-MC-Unique: Vy4CPgg-OZSajnRCYw94Ow-1 Received: by verein.lst.de (Postfix, from userid 2407) id E4E0067373; Fri, 20 Nov 2020 10:17:14 +0100 (CET) Date: Fri, 20 Nov 2020 10:17:14 +0100 From: Christoph Hellwig To: Matthew Wilcox Message-ID: <20201120091714.GF21715@lst.de> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-18-hch@lst.de> <20201119151316.GH29991@casper.infradead.org> MIME-Version: 1.0 In-Reply-To: <20201119151316.GH29991@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-mm@kvack.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, Christoph Hellwig Subject: Re: [dm-devel] [PATCH 17/20] filemap: consistently use ->f_mapping over ->i_mapping X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 19, 2020 at 03:13:16PM +0000, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 09:47:57AM +0100, Christoph Hellwig wrote: > > @@ -2887,13 +2887,13 @@ EXPORT_SYMBOL(filemap_map_pages); > > vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf) > > { > > struct page *page = vmf->page; > > - struct inode *inode = file_inode(vmf->vma->vm_file); > > + struct inode *inode = vmf->vma->vm_file->f_mapping->host; > > vm_fault_t ret = VM_FAULT_LOCKED; > > > > sb_start_pagefault(inode->i_sb); > > file_update_time(vmf->vma->vm_file); > > lock_page(page); > > - if (page->mapping != inode->i_mapping) { > > + if (page->mapping != vmf->vma->vm_file->f_mapping) { > > Bit messy. I'd do: > > struct address_space *mapping = vmf->vma->vm_file->f_mapping; > > sb_start_pagefault(mapping->host->i_sb); > > if (page->mapping != mapping) > > sb_end_pagefault(mapping->host->i_sb); Fine with me. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8340EC64E75 for ; Fri, 20 Nov 2020 09:17:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E8142224C for ; Fri, 20 Nov 2020 09:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbgKTJRV (ORCPT ); Fri, 20 Nov 2020 04:17:21 -0500 Received: from verein.lst.de ([213.95.11.211]:42132 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725824AbgKTJRR (ORCPT ); Fri, 20 Nov 2020 04:17:17 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id E4E0067373; Fri, 20 Nov 2020 10:17:14 +0100 (CET) Date: Fri, 20 Nov 2020 10:17:14 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Coly Li , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 17/20] filemap: consistently use ->f_mapping over ->i_mapping Message-ID: <20201120091714.GF21715@lst.de> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-18-hch@lst.de> <20201119151316.GH29991@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119151316.GH29991@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Thu, Nov 19, 2020 at 03:13:16PM +0000, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 09:47:57AM +0100, Christoph Hellwig wrote: > > @@ -2887,13 +2887,13 @@ EXPORT_SYMBOL(filemap_map_pages); > > vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf) > > { > > struct page *page = vmf->page; > > - struct inode *inode = file_inode(vmf->vma->vm_file); > > + struct inode *inode = vmf->vma->vm_file->f_mapping->host; > > vm_fault_t ret = VM_FAULT_LOCKED; > > > > sb_start_pagefault(inode->i_sb); > > file_update_time(vmf->vma->vm_file); > > lock_page(page); > > - if (page->mapping != inode->i_mapping) { > > + if (page->mapping != vmf->vma->vm_file->f_mapping) { > > Bit messy. I'd do: > > struct address_space *mapping = vmf->vma->vm_file->f_mapping; > > sb_start_pagefault(mapping->host->i_sb); > > if (page->mapping != mapping) > > sb_end_pagefault(mapping->host->i_sb); Fine with me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6DAC5519F for ; Fri, 20 Nov 2020 09:18:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D196A2224C for ; Fri, 20 Nov 2020 09:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UmTZdb6r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D196A2224C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ASV8mNwXw2ldkSPeKfHYn2zzubPH756lqukplbD3ZVA=; b=UmTZdb6rlKlKe5Y7KKTzHJNr1 kVUhwsfzDt0N93K6ZPpBUWdfkIdtieOIPhe7wZp4lqibUza6Trx3ylg9CZyb9I4sON0GjFhteaWaz CCDaWY3dJVDjy2FT0xXJwXERaswaCKuEY+mXL9jfX4+Sl3ozYAp39h/friw6XJCybPZiGHUYkXRjQ 6zPMC2o4uHatbosdGDdCpKxryBRHTnqlBFZXDwRc8m/ADNwfLfvEwFMxrxoI1J6EozolcDZ0zUyB6 zzmj754dU+1mtx8lRleZm8GSTTkxIqTZg0UVgQu0l/RjUbP2A1G1BTcOcbMu9MvREphKUVqqFK8cu CZqcylxMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2Xg-0006Z9-Cv; Fri, 20 Nov 2020 09:17:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2Xc-0006X4-ER for linux-mtd@lists.infradead.org; Fri, 20 Nov 2020 09:17:17 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E4E0067373; Fri, 20 Nov 2020 10:17:14 +0100 (CET) Date: Fri, 20 Nov 2020 10:17:14 +0100 From: Christoph Hellwig To: Matthew Wilcox Subject: Re: [PATCH 17/20] filemap: consistently use ->f_mapping over ->i_mapping Message-ID: <20201120091714.GF21715@lst.de> References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-18-hch@lst.de> <20201119151316.GH29991@casper.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119151316.GH29991@casper.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_041716_651324_8B5AE4C8 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Mike Snitzer , Konrad Rzeszutek Wilk , Richard Weinberger , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-mm@kvack.org, Jan Kara , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 03:13:16PM +0000, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 09:47:57AM +0100, Christoph Hellwig wrote: > > @@ -2887,13 +2887,13 @@ EXPORT_SYMBOL(filemap_map_pages); > > vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf) > > { > > struct page *page = vmf->page; > > - struct inode *inode = file_inode(vmf->vma->vm_file); > > + struct inode *inode = vmf->vma->vm_file->f_mapping->host; > > vm_fault_t ret = VM_FAULT_LOCKED; > > > > sb_start_pagefault(inode->i_sb); > > file_update_time(vmf->vma->vm_file); > > lock_page(page); > > - if (page->mapping != inode->i_mapping) { > > + if (page->mapping != vmf->vma->vm_file->f_mapping) { > > Bit messy. I'd do: > > struct address_space *mapping = vmf->vma->vm_file->f_mapping; > > sb_start_pagefault(mapping->host->i_sb); > > if (page->mapping != mapping) > > sb_end_pagefault(mapping->host->i_sb); Fine with me. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/