From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773F7C63777 for ; Fri, 20 Nov 2020 09:44:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAE8322227 for ; Fri, 20 Nov 2020 09:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UJJ1EJ8F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAE8322227 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kzt1YaIh50jA+gmg7SeDx2r4FL857zaO7ezWnFgtngA=; b=UJJ1EJ8F2iNqCQXc4lH91/L0w 9hI8ppzr4Grs1nkv8VEMY0uXFHMjGGBgUE3li65Om5aFJ4Mlw1kJw7Z4Mk2vrMfdzJyRvEGdB/Scf QAzLLoEXtK0l8219pQzsxaPUdXqWujJE4eSaAZh24dlR+zmvp0aKDEqRlLl+kueZluznYe8VnI/PS MpEGUrtb5fLRQzyz2aGfSXZRBrxRUZDJC9aS3IqCJPH+84loBDHByTvbVyM+CuB8484LaERUO28dU NXjAY4kiZJKv3ySI7qLekDOuQj/GZRHkv+7JHfZAbvqQGIM+L4fpYDUfRp/MwkH6LUhAg+kbXSmHa /ObB8bydQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2y5-0004td-NY; Fri, 20 Nov 2020 09:44:37 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2y2-0004ss-O3 for linux-nvme@lists.infradead.org; Fri, 20 Nov 2020 09:44:35 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7CBEF67373; Fri, 20 Nov 2020 10:44:32 +0100 (CET) Date: Fri, 20 Nov 2020 10:44:32 +0100 From: "hch@lst.de" To: "George, Martin" Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group Message-ID: <20201120094432.GA25846@lst.de> References: <20201118114859.7985-1-marting@netapp.com> <20201118162415.GA16753@lst.de> <7fd0b51f3b7bc73abf7132aaa5ee7c493a93aef0.camel@netapp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7fd0b51f3b7bc73abf7132aaa5ee7c493a93aef0.camel@netapp.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_044434_912840_C9F5DEE0 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kbusch@kernel.org" , "hch@lst.de" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Nov 18, 2020 at 08:09:43PM +0000, George, Martin wrote: > > How can the namespace reference an ANA group that we haven't been > > notified about using the NVME_AEN_CFG_ANA_CHANGE AEN before? > > Well, I think that could be possible for a newly created namespace, > which happens to belong to a new ANA group. To quote the 1.4 spec in > context of Asymmetric Namespace Access Change under the Asynchronous > Event Information - Notice (Figure 147): > > "A controller shall not send this event if: > a) the change is due to the creation of a namespace (refer to section > 5.20); or > b) the change is due to the deletion of a namespace (refer to section > 5.20), > as the Namespace Attribute Changed event is sent for these changes." > > So it looks the NVME_AEN_CFG_ANA_CHANGE AEN is not required here for > such cases, but instead the NVME_AEN_CFG_NS_ATTR AEN would do. For the newly created namespace to beong to a newly created ANA group the controller first needs to send NVME_AEN_CFG_ANA_CHANGE to announce the ANA group, it then send NVME_AEN_CFG_NS_ATTR to announce the new namespaces. But the new namespace can't reference an ANA group that didn't exist, that is a separate event. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme