From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6976254097004467417==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Fri, 20 Nov 2020 19:00:07 +0800 Message-ID: <20201120110007.GA37192@ac61a234642b> In-Reply-To: <202011201903.Z88J8wJg-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============6976254097004467417== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Lee Duncan CC: Chris Leech CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: open-iscsi(a)googlegroups.com CC: linux-scsi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/scsi/scsi_transport_iscsi.c:4041:61-62: WARNING opportunity for kob= j_to_dev() drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity for kob= j_to_dev() drivers/scsi/scsi_transport_iscsi.c:926:60-61: WARNING opportunity for kobj= _to_dev() drivers/scsi/scsi_transport_iscsi.c:4454:61-62: WARNING opportunity for kob= j_to_dev() drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for kobj= _to_dev() drivers/scsi/scsi_transport_iscsi.c:4310:61-62: WARNING opportunity for kob= j_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 4d02da974ea85a62074efedf354e82778f910d82 commit: a2fc3718bc22e85378085568ecc5765fb28cabce coccinelle: api: add kobj_= to_dev.cocci script :::::: branch date: 13 hours ago :::::: commit date: 3 months ago Please take the patch only if it's a positive warning. Thanks! scsi_transport_iscsi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -433,7 +433,7 @@ iscsi_iface_attr(iface, initiator_name, static umode_t iscsi_iface_attr_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct iscsi_iface *iface =3D iscsi_dev_to_iface(dev); struct iscsi_transport *t =3D iface->transport; int param; @@ -923,7 +923,7 @@ static umode_t iscsi_flashnode_sess_attr struct attribute *attr, int i) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct iscsi_bus_flash_session *fnode_sess =3D iscsi_dev_to_flash_session(dev); struct iscsi_transport *t =3D fnode_sess->transport; @@ -1125,7 +1125,7 @@ static umode_t iscsi_flashnode_conn_attr struct attribute *attr, int i) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct iscsi_bus_flash_conn *fnode_conn =3D iscsi_dev_to_flash_conn(dev); struct iscsi_transport *t =3D fnode_conn->transport; int param; @@ -4038,7 +4038,7 @@ static struct attribute *iscsi_conn_attr static umode_t iscsi_conn_attr_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *cdev =3D container_of(kobj, struct device, kobj); + struct device *cdev =3D kobj_to_dev(kobj); struct iscsi_cls_conn *conn =3D transport_class_to_conn(cdev); struct iscsi_transport *t =3D conn->transport; int param; @@ -4307,7 +4307,7 @@ static struct attribute *iscsi_session_a static umode_t iscsi_session_attr_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *cdev =3D container_of(kobj, struct device, kobj); + struct device *cdev =3D kobj_to_dev(kobj); struct iscsi_cls_session *session =3D transport_class_to_session(cdev); struct iscsi_transport *t =3D session->transport; int param; @@ -4451,7 +4451,7 @@ static struct attribute *iscsi_host_attr static umode_t iscsi_host_attr_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *cdev =3D container_of(kobj, struct device, kobj); + struct device *cdev =3D kobj_to_dev(kobj); struct Scsi_Host *shost =3D transport_class_to_shost(cdev); struct iscsi_internal *priv =3D to_iscsi_internal(shost->transportt); int param; --===============6976254097004467417==--