From: Uladzislau Rezki <urezki@gmail.com>
To: Zqiang <qiang.zhang@windriver.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
josh@joshtriplett.org, rostedt@goodmis.org,
joel@joelfernandes.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
urezki@gmail.com
Subject: Re: [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack
Date: Fri, 20 Nov 2020 12:59:35 +0100 [thread overview]
Message-ID: <20201120115935.GA8042@pc636> (raw)
In-Reply-To: <20201119214934.GC1437@paulmck-ThinkPad-P72>
On Thu, Nov 19, 2020 at 01:49:34PM -0800, Paul E. McKenney wrote:
> On Wed, Nov 18, 2020 at 11:53:09AM +0800, qiang.zhang@windriver.com wrote:
> > From: Zqiang <qiang.zhang@windriver.com>
> >
> > Add kasan_record_aux_stack function for kvfree_call_rcu function to
> > record call stacks.
> >
> > Signed-off-by: Zqiang <qiang.zhang@windriver.com>
>
> Thank you, but this does not apply on the "dev" branch of the -rcu tree.
> See file:///home/git/kernel.org/rcutodo.html for more info.
>
> Adding others on CC who might have feedback on the general approach.
>
> Thanx, Paul
>
> > ---
> > kernel/rcu/tree.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index da3414522285..a252b2f0208d 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3506,7 +3506,7 @@ void kvfree_call_rcu(struct rcu_head *head, rcu_callback_t func)
> > success = true;
> > goto unlock_return;
> > }
> > -
> > + kasan_record_aux_stack(ptr);
Is that save to invoke it on vmalloced ptr.?
--
Vlad Rezki
next prev parent reply other threads:[~2020-11-20 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 3:53 [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack qiang.zhang
2020-11-19 21:49 ` Paul E. McKenney
2020-11-20 8:51 ` Dmitry Vyukov
2020-11-20 14:34 ` Paul E. McKenney
2020-11-20 14:44 ` Dmitry Vyukov
2020-11-20 14:54 ` Paul E. McKenney
2020-11-20 14:45 ` Paul E. McKenney
2020-11-20 11:59 ` Uladzislau Rezki [this message]
2020-11-20 12:06 ` Dmitry Vyukov
2020-11-20 12:49 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120115935.GA8042@pc636 \
--to=urezki@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang@windriver.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.