Re: [PATCH] dt-bindings: pinctrl: ocelot: convert pinctrl bindings to json-schema

[Rob Herring <robh@kernel.org>]

On Fri, Nov 13, 2020 at 01:12:46PM +0100, Gregory CLEMENT wrote:
> Convert device tree bindings for Microsemi SoC (Ocelot, Luton, Serval,
> Jguar2, Sarx5) Pin Controller to YAML format
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
>  .../bindings/pinctrl/mscc,ocelot-pinctrl.txt  | 41 ------------
>  .../bindings/pinctrl/mscc,ocelot-pinctrl.yaml | 64 +++++++++++++++++++
>  2 files changed, 64 insertions(+), 41 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.txt
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml

Please resend Cc'ing Linus.


> diff --git a/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
> new file mode 100644
> index 000000000000..b774b92becc8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/mscc,ocelot-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microsemi Ocelot pin controller Device Tree Bindings
> +
> +maintainers:
> +  - Alexandre Belloni <alexandre.belloni@bootlin.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,sparx5-pinctrl
> +      - mscc,jaguar2-pinctrl
> +      - mscc,luton-pinctrl
> +      - mscc,ocelot-pinctrl
> +      - mscc,serval-pinctrl
> +
> +  "#gpio-cells":
> +    const: 2
> +    description:
> +      The first cell is the pin number and the second cell specifies
> +      GPIO flags, as defined in <dt-bindings/gpio/gpio.h>.
> +
> +  reg:
> +    maxItems: 1
> +
> +  gpio-controller: true
> +
> +  gpio-ranges:
> +    maxItems: 1
> +
> +required:
> +  - "#gpio-cells"
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - gpio-ranges
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    gpio: pinctrl@71070034 {
> +        compatible = "mscc,ocelot-pinctrl";
> +        reg = <0x71070034 0x28>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +                gpio-ranges = <&gpio 0 0 22>;
> +
> +        uart_pins: uart-pins {

You need to define '-pins$' under patternProperties. Without it, this 
doesn't pass validation.

> +        		pins = "GPIO_6", "GPIO_7";
> +        		function = "uart";

mixed tabs and spaces. YAML wants spaces.

> +        };
> +
> +        uart2_pins: uart2-pins {
> +        		pins = "GPIO_12", "GPIO_13";
> +        		function = "uart2";
> +        };
> +    };
> +
> +...
> \ No newline at end of file

Fix this.