From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW
Date: Sun, 22 Nov 2020 01:02:21 +0300 [thread overview]
Message-ID: <20201122010221.1387bb3d@sovereign> (raw)
In-Reply-To: <20201120211255.24803-1-nick.connolly@mayadata.io>
On Fri, 20 Nov 2020 21:12:55 +0000, Nick Connolly wrote:
> Linking with the 'pci' driver when building with MinGW on
> Windows fails with undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h
> before INITGUID is defined.
>
> Resolved by moving the include of devguid.h after the definition
> of INITGUID.
Commit changes should be described in present tense.
>
> Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> Cc: talshn@mellanox.com
A blank line should be here.
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
Apart from those nits,
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
next prev parent reply other threads:[~2020-11-21 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 21:12 [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW Nick Connolly
2020-11-20 22:41 ` Tal Shnaiderman
2020-11-20 23:43 ` Nick Connolly
2020-11-20 23:44 ` Nick Connolly
2020-11-21 20:47 ` Dmitry Kozlyuk
2020-11-21 21:50 ` Nick Connolly
2020-11-21 22:02 ` Dmitry Kozlyuk [this message]
2020-11-21 22:54 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-11-22 7:27 ` Tal Shnaiderman
2020-11-22 8:45 ` [dpdk-dev] [PATCH v3] " Nick Connolly
2020-11-22 9:00 ` Tal Shnaiderman
2020-11-22 17:57 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122010221.1387bb3d@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=pallavi.kadam@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.