From: Sasha Levin <sashal@kernel.org>
To: Kamal Mostafa <kamal@canonical.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
stable@vger.kernel.org, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH 5.9.x] usb: dwc2: Avoid leaving the error_debugfs label unused
Date: Sun, 22 Nov 2020 12:28:34 -0500 [thread overview]
Message-ID: <20201122172834.GH643756@sasha-vm> (raw)
In-Reply-To: <20201120164645.12542-1-kamal@canonical.com>
On Fri, Nov 20, 2020 at 08:46:45AM -0800, Kamal Mostafa wrote:
>From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>commit 190bb01b72d2d5c3654a03c42fb1ad0dc6114c79 upstream.
>
>The error_debugfs label is only used when either
>CONFIG_USB_DWC2_PERIPHERAL or CONFIG_USB_DWC2_DUAL_ROLE is enabled. Add
>the same #if to the error_debugfs label itself as the code which uses
>this label already has.
>
>This avoids the following compiler warning:
> warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
>
>Fixes: e1c08cf23172ed ("usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails")
>Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
>Reported-by: kernel test robot <lkp@intel.com>
>Reported-by: Jens Axboe <axboe@kernel.dk>
>Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>Signed-off-by: Felipe Balbi <balbi@kernel.org>
>Cc: stable@vger.kernel.org # 5.9.x
>Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2020-11-22 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 22:23 pick up "usb: dwc2: Avoid leaving the error_debugfs label unused" Kamal Mostafa
2020-11-20 8:39 ` Greg KH
2020-11-20 16:46 ` Kamal Mostafa
2020-11-20 16:46 ` [PATCH 5.9.x] usb: dwc2: Avoid leaving the error_debugfs label unused Kamal Mostafa
2020-11-22 17:28 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122172834.GH643756@sasha-vm \
--to=sashal@kernel.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kamal@canonical.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.