From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: robh+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] input: Add support for Azoteq IQS626A
Date: Sun, 22 Nov 2020 23:03:07 -0800 [thread overview]
Message-ID: <20201123070307.GE2034289@dtor-ws> (raw)
In-Reply-To: <1606084748-4097-3-git-send-email-jeff@labundy.com>
Hi Jeff,
On Sun, Nov 22, 2020 at 04:39:08PM -0600, Jeff LaBundy wrote:
> +
> + if ((sys_reg->active & tp_mask) == tp_mask)
> + input_set_abs_params(iqs626->trackpad,
> + ABS_X, 0, 255, 0, 0);
> + else
> + input_set_abs_params(iqs626->trackpad,
> + ABS_X, 0, 128, 0, 0);
> +#ifdef CONFIG_TOUCHSCREEN_PROPERTIES
> + touchscreen_parse_properties(iqs626->trackpad, false,
> + &iqs626->prop);
> +#endif /* CONFIG_TOUCHSCREEN_PROPERTIES */
This should not be separately selectable from CONFIG_INPUT, so there is
not need to have this guard.
The reason it is a separate symbol is historical - it used to depend on
OF in addition to INPUT. I suppose I can drop it now.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-11-23 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 22:39 [PATCH 0/2] Add support for Azoteq IQS626A Jeff LaBundy
2020-11-22 22:39 ` [PATCH 1/2] dt-bindings: input: Add bindings " Jeff LaBundy
2021-01-08 3:49 ` Jeff LaBundy
2020-11-22 22:39 ` [PATCH 2/2] input: Add support " Jeff LaBundy
2020-11-23 7:03 ` Dmitry Torokhov [this message]
2020-11-24 0:15 ` Jeff LaBundy
2020-12-01 7:01 ` Dmitry Torokhov
2020-12-02 5:53 ` Jeff LaBundy
2020-12-02 6:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123070307.GE2034289@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.