Re: [PATCH v6 5/6] usb: typec: mux: add typec switch via general mux control

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Nov 23, 2020 at 10:01:35PM +0800, Li Jun wrote:
> The general mux controller can be easily extended to support
> various mux selection, this especially fits typec orientation
> switch block with a dedicated driver.

...

> @@ -42,10 +43,8 @@ static void *typec_switch_match(struct device_connection *con, int ep,
>  	if (con->id && !fwnode_is_compatible(con->fwnode, con->id) &&
>  		       !fwnode_property_present(con->fwnode, con->id))
>  		return NULL;
> -
>  	dev = class_find_device(&typec_mux_class, NULL, con->fwnode,
>  				switch_fwnode_match);
> -
>  	return dev ? to_typec_switch(dev) : ERR_PTR(-EPROBE_DEFER);
>  }
>  

Not related change.

...

> +	if (sw->mux_ctrl)
> +		return typec_switch_mux_ctrl(sw->mux_ctrl, orientation);

> +	else

Redundant.

> +		return sw->set(sw, orientation);

-- 
With Best Regards,
Andy Shevchenko