* [PATCH] ath11k: Fix beamformee STS in HE cap
@ 2020-11-09 14:47 ` Ramya Gnanasekar
0 siblings, 0 replies; 4+ messages in thread
From: Ramya Gnanasekar @ 2020-11-09 14:47 UTC (permalink / raw)
To: ath11k; +Cc: Ramya Gnanasekar, linux-wireless
STS Beamformee capability sent from firmware is overwritten as
num_tx_chains - 1.
When num_tx_chains is 2, then STS is set to invalid value 1.
Since STS is not limited by number of TX chain, not overwriting the
capability received from firmware.
Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1
Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 7f8dd47..787b052 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3729,11 +3729,6 @@ static int ath11k_mac_copy_he_cap(struct ath11k *ar,
he_cap_elem->mac_cap_info[1] &=
IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
- he_cap_elem->phy_cap_info[4] &=
- ~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_UNDER_80MHZ_MASK;
- he_cap_elem->phy_cap_info[4] &=
- ~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_ABOVE_80MHZ_MASK;
- he_cap_elem->phy_cap_info[4] |= (ar->num_tx_chains - 1) << 2;
he_cap_elem->phy_cap_info[5] &=
~IEEE80211_HE_PHY_CAP5_BEAMFORMEE_NUM_SND_DIM_UNDER_80MHZ_MASK;
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath11k: Fix beamformee STS in HE cap
@ 2020-11-09 14:47 ` Ramya Gnanasekar
0 siblings, 0 replies; 4+ messages in thread
From: Ramya Gnanasekar @ 2020-11-09 14:47 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Ramya Gnanasekar
STS Beamformee capability sent from firmware is overwritten as
num_tx_chains - 1.
When num_tx_chains is 2, then STS is set to invalid value 1.
Since STS is not limited by number of TX chain, not overwriting the
capability received from firmware.
Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1
Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 7f8dd47..787b052 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3729,11 +3729,6 @@ static int ath11k_mac_copy_he_cap(struct ath11k *ar,
he_cap_elem->mac_cap_info[1] &=
IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
- he_cap_elem->phy_cap_info[4] &=
- ~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_UNDER_80MHZ_MASK;
- he_cap_elem->phy_cap_info[4] &=
- ~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_ABOVE_80MHZ_MASK;
- he_cap_elem->phy_cap_info[4] |= (ar->num_tx_chains - 1) << 2;
he_cap_elem->phy_cap_info[5] &=
~IEEE80211_HE_PHY_CAP5_BEAMFORMEE_NUM_SND_DIM_UNDER_80MHZ_MASK;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: Fix beamformee STS in HE cap
2020-11-09 14:47 ` Ramya Gnanasekar
(?)
@ 2020-11-23 18:06 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-11-23 18:06 UTC (permalink / raw)
To: Ramya Gnanasekar; +Cc: ath11k, linux-wireless, Ramya Gnanasekar
Ramya Gnanasekar <rgnanase@codeaurora.org> wrote:
> STS Beamformee capability sent from firmware is overwritten as
> num_tx_chains - 1.
> When num_tx_chains is 2, then STS is set to invalid value 1.
> Since STS is not limited by number of TX chain, not overwriting the
> capability received from firmware.
>
> Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
1057db1b8b76 ath11k: Fix beamformee STS in HE cap
--
https://patchwork.kernel.org/project/linux-wireless/patch/1604933229-15815-1-git-send-email-rgnanase@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: Fix beamformee STS in HE cap
2020-11-09 14:47 ` Ramya Gnanasekar
(?)
(?)
@ 2020-11-23 18:06 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-11-23 18:06 UTC (permalink / raw)
To: Ramya Gnanasekar; +Cc: linux-wireless, ath11k
Ramya Gnanasekar <rgnanase@codeaurora.org> wrote:
> STS Beamformee capability sent from firmware is overwritten as
> num_tx_chains - 1.
> When num_tx_chains is 2, then STS is set to invalid value 1.
> Since STS is not limited by number of TX chain, not overwriting the
> capability received from firmware.
>
> Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
1057db1b8b76 ath11k: Fix beamformee STS in HE cap
--
https://patchwork.kernel.org/project/linux-wireless/patch/1604933229-15815-1-git-send-email-rgnanase@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-23 18:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-09 14:47 [PATCH] ath11k: Fix beamformee STS in HE cap Ramya Gnanasekar
2020-11-09 14:47 ` Ramya Gnanasekar
2020-11-23 18:06 ` Kalle Valo
2020-11-23 18:06 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.