From: Ebrahim Byagowi <ebrahim@gnu.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gconfig: avoid use of hard coded colors for rows
Date: Mon, 23 Nov 2020 16:51:43 -0500 [thread overview]
Message-ID: <20201123215143.GA21824@gnu.org> (raw)
In-Reply-To: <20201123213314.GA25149@gnu.org>
Not an important thing of course just that I was unable to
use gconfig on my system with a theme dark is set like [1]
and this turns it into [2] without noticable change to the
light theme.
I had hit this minor issue also in the past but decided to
fix it this time.
This isn't the best possible approach as now we have we have
a GdkColor -> gchar * -> GdkColor round trip, yet wanted to
keep the change small and maybe go for a larger change later
if it worths it.
Hope you find it useful also.
[1]: https://i.imgur.com/MJfIkup.png
[2]: https://i.imgur.com/lgvod9V.png
next prev parent reply other threads:[~2020-11-23 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 21:33 [PATCH] gconfig: avoid use of hard coded colors for rows Ebrahim Byagowi
2020-11-23 21:51 ` Ebrahim Byagowi [this message]
2020-12-02 1:02 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123215143.GA21824@gnu.org \
--to=ebrahim@gnu.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.