From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1928505859810877175==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Tue, 24 Nov 2020 06:20:22 +0800 Message-ID: <20201123222022.GA28104@354249807b9d> In-Reply-To: <202011240615.qUYY8s9W-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1928505859810877175== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: linux-scsi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/scsi/scsi_transport_spi.c:1460:61-62: WARNING opportunity for kobj_= to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 418baf2c28f3473039f2f7377760bd8f6897ae18 commit: a2fc3718bc22e85378085568ecc5765fb28cabce coccinelle: api: add kobj_= to_dev.cocci script :::::: branch date: 23 hours ago :::::: commit date: 3 months ago Please take the patch only if it's a positive warning. Thanks! scsi_transport_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/scsi_transport_spi.c +++ b/drivers/scsi/scsi_transport_spi.c @@ -1457,7 +1457,7 @@ static int spi_host_configure(struct tra static umode_t target_attribute_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *cdev =3D container_of(kobj, struct device, kobj); + struct device *cdev =3D kobj_to_dev(kobj); struct scsi_target *starget =3D transport_class_to_starget(cdev); struct Scsi_Host *shost =3D transport_class_to_shost(cdev); struct spi_internal *si =3D to_spi_internal(shost->transportt); --===============1928505859810877175==--