From: Andrew Lunn <andrew@lunn.ch>
To: Moshe Shemesh <moshe@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Adrian Pop <pop.adrian61@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org,
Vladyslav Tarasiuk <vladyslavt@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>
Subject: Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type
Date: Tue, 24 Nov 2020 02:14:59 +0100 [thread overview]
Message-ID: <20201124011459.GD2031446@lunn.ch> (raw)
In-Reply-To: <1606123198-6230-1-git-send-email-moshe@mellanox.com>
On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote:
> Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable
> transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add
> CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5.
So the patches themselves look O.K.
But we are yet again kicking the can down the road and not fixing the
underlying inflexibility of the API.
Do we want to keep kicking the can, or is now the time to do the work
on this API?
Andrew
next prev parent reply other threads:[~2020-11-24 1:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 9:19 [PATCH net-next v2 0/2] Add support for DSFP transceiver type Moshe Shemesh
2020-11-23 9:19 ` [PATCH net-next v2 1/2] ethtool: Add CMIS 4.0 module type to UAPI Moshe Shemesh
2020-11-23 22:40 ` Jesse Brandeburg
2020-11-25 10:41 ` Moshe Shemesh
2020-11-23 9:19 ` [PATCH net-next v2 2/2] net/mlx5e: Add DSFP EEPROM dump support to ethtool Moshe Shemesh
2020-11-24 1:14 ` Andrew Lunn [this message]
2020-11-24 21:16 ` [PATCH net-next v2 0/2] Add support for DSFP transceiver type Jakub Kicinski
2020-11-25 10:40 ` Moshe Shemesh
2020-11-25 14:18 ` Andrew Lunn
2020-11-26 14:23 ` Moshe Shemesh
2020-11-26 15:21 ` Andrew Lunn
2020-11-27 15:12 ` Moshe Shemesh
2020-11-27 15:56 ` Andrew Lunn
2020-12-29 10:23 ` Vladyslav Tarasiuk
2020-12-29 16:25 ` Andrew Lunn
2020-12-30 13:55 ` Vladyslav Tarasiuk
2020-12-30 15:36 ` Andrew Lunn
2021-01-04 15:24 ` Vladyslav Tarasiuk
2021-01-04 15:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124011459.GD2031446@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=moshe@mellanox.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pop.adrian61@gmail.com \
--cc=vladyslavt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.