Re: [PATCH net-next 1/3] net: phy: dp83640: use new PTP_MSGTYPE_SYNC define

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]

Hi Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Christian-Eggers/net-ptp-use-common-defines-for-PTP-message-types-in-further-drivers/20201122-163319
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f9e425e99b0756c1479042afe761073779df2a30
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/ca8d2b8ed7f512e08334c0da147ff3cb53b89d51
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christian-Eggers/net-ptp-use-common-defines-for-PTP-message-types-in-further-drivers/20201122-163319
        git checkout ca8d2b8ed7f512e08334c0da147ff3cb53b89d51
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/phy/dp83640.c: In function 'is_sync':
>> drivers/net/phy/dp83640.c:972:39: error: 'PTP_MSGTYPE_SYNC' undeclared (first use in this function); did you mean 'CSD_TYPE_SYNC'?
     972 |  return ptp_get_msgtype(hdr, type) == PTP_MSGTYPE_SYNC;
         |                                       ^~~~~~~~~~~~~~~~
         |                                       CSD_TYPE_SYNC
   drivers/net/phy/dp83640.c:972:39: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/phy/dp83640.c:973:1: error: control reaches end of non-void function [-Werror=return-type]
     973 | }
         | ^
   cc1: some warnings being treated as errors

vim +972 drivers/net/phy/dp83640.c

   963	
   964	static int is_sync(struct sk_buff *skb, int type)
   965	{
   966		struct ptp_header *hdr;
   967	
   968		hdr = ptp_parse_header(skb, type);
   969		if (!hdr)
   970			return 0;
   971	
 > 972		return ptp_get_msgtype(hdr, type) == PTP_MSGTYPE_SYNC;
   973	}
   974	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45410 bytes --]