From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9387FC2D0E4 for ; Tue, 24 Nov 2020 07:25:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A3A520679 for ; Tue, 24 Nov 2020 07:25:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A3A520679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khShu-0002Ib-GA for qemu-devel@archiver.kernel.org; Tue, 24 Nov 2020 02:25:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khSg9-0001T8-Ef for qemu-devel@nongnu.org; Tue, 24 Nov 2020 02:23:57 -0500 Received: from 7.mo51.mail-out.ovh.net ([46.105.33.25]:42129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khSg2-0004fc-Oq for qemu-devel@nongnu.org; Tue, 24 Nov 2020 02:23:57 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.108.1.237]) by mo51.mail-out.ovh.net (Postfix) with ESMTPS id 0765323A882; Tue, 24 Nov 2020 08:23:47 +0100 (CET) Received: from kaod.org (37.59.142.97) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 24 Nov 2020 08:23:46 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-97G0020bf7ceb4-a857-4539-9f97-2d844c7d6537, 886B3C846F729F79F342FB8F3892F62368E4F687) smtp.auth=groug@kaod.org Date: Tue, 24 Nov 2020 08:23:45 +0100 From: Greg Kurz To: Christian Schoenebeck Subject: Re: [PATCH for-5.2] tests/9pfs: Mark "local" tests as "slow" Message-ID: <20201124082345.01001c04@bahia.lan> In-Reply-To: <10297311.nEiT89vc6u@silver> References: <160615331159.1339160.8458952247626802787.stgit@bahia.lan> <1652137.SzlE5fuBRn@silver> <10297311.nEiT89vc6u@silver> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.97] X-ClientProxiedBy: DAG2EX2.mxp5.local (172.16.2.12) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 6dd3e6b0-780a-4d95-8698-4b45a94a4643 X-Ovh-Tracer-Id: 13042987473220835808 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrudegjedgudefgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkjghfofggtgfgihesthejredtredtvdenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepkedvgfeugfdtvdelfeffueevfeegudekhefftdejvefgveeileeludffkeeuvdffnecuffhomhgrihhnpehnohhnghhnuhdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehthhhuthhhsehrvgguhhgrthdrtghomh Received-SPF: pass client-ip=46.105.33.25; envelope-from=groug@kaod.org; helo=7.mo51.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 23 Nov 2020 20:35:58 +0100 Christian Schoenebeck wrote: > On Montag, 23. November 2020 19:08:18 CET Christian Schoenebeck wrote: > > On Montag, 23. November 2020 18:41:51 CET Greg Kurz wrote: > > > The "local" tests can fail on some automated build systems as > > > reported here: > > > > > > https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html > > > > > > This will need to be investigated and addressed later. Let's go for a > > > workaround in the meantime : mark the "local" tests as "slow" so that > > > they aren't executed with a simple "make check" like in the case above. > > > > > > Reported-by: Cole Robinson > > > Signed-off-by: Greg Kurz > > > --- > > > > > > Unless there's a strong argument against merging this, I'll post > > > a PR with this fix for RC3. > > > --- > > > > > > tests/qtest/virtio-9p-test.c | 35 +++++++++++++++++++++-------------- > > > 1 file changed, 21 insertions(+), 14 deletions(-) > > > > > > diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c > > > index 21e340fa5f43..dad37ace9772 100644 > > > --- a/tests/qtest/virtio-9p-test.c > > > +++ b/tests/qtest/virtio-9p-test.c > > > @@ -1454,20 +1454,27 @@ static void register_virtio_9p_test(void) > > > > > > qos_add_test("synth/readdir/split_128", "virtio-9p", > > > > > > fs_readdir_split_128, &opts); > > > > > > - > > > - /* 9pfs test cases using the 'local' filesystem driver */ > > > - opts.before = assign_9p_local_driver; > > > - qos_add_test("local/config", "virtio-9p", pci_config, &opts); > > > - qos_add_test("local/create_dir", "virtio-9p", fs_create_dir, &opts); > > > - qos_add_test("local/unlinkat_dir", "virtio-9p", fs_unlinkat_dir, > > > &opts); - qos_add_test("local/create_file", "virtio-9p", > > > fs_create_file, > > > &opts); - qos_add_test("local/unlinkat_file", "virtio-9p", > > > fs_unlinkat_file, &opts); - qos_add_test("local/symlink_file", > > > "virtio-9p", fs_symlink_file, &opts); - > > > qos_add_test("local/unlinkat_symlink", "virtio-9p", fs_unlinkat_symlink, - > > > > > > &opts); > > > > > > - qos_add_test("local/hardlink_file", "virtio-9p", fs_hardlink_file, > > > &opts); - qos_add_test("local/unlinkat_hardlink", "virtio-9p", > > > fs_unlinkat_hardlink, - &opts); > > > + if (g_test_slow()) { > > > > If you don't mind, I would suggest simply using > > > > if (!g_test_slow()) { > > return; > > } > > > > here to keep the diff noise low. > > > > > + /* 9pfs test cases using the 'local' filesystem driver */ > > > + /* > > > + * XXX: Until we are sure that these tests can run everywhere, > > > + * keep them as "slow" so that they aren't run with "make check" > > > + */ > > > + opts.before = assign_9p_local_driver; > > > + qos_add_test("local/config", "virtio-9p", pci_config, &opts); > > > + qos_add_test("local/create_dir", "virtio-9p", fs_create_dir, > > > &opts); + qos_add_test("local/unlinkat_dir", "virtio-9p", > > > fs_unlinkat_dir, &opts); + qos_add_test("local/create_file", > > > "virtio-9p", fs_create_file, &opts); + > > > qos_add_test("local/unlinkat_file", "virtio-9p", fs_unlinkat_file, + > > > > > > &opts); > > > > > > + qos_add_test("local/symlink_file", "virtio-9p", fs_symlink_file, > > > &opts); + qos_add_test("local/unlinkat_symlink", "virtio-9p", > > > fs_unlinkat_symlink, + &opts); > > > + qos_add_test("local/hardlink_file", "virtio-9p", > > > fs_hardlink_file, > > > + &opts); > > > + qos_add_test("local/unlinkat_hardlink", "virtio-9p", > > > + fs_unlinkat_hardlink, &opts); > > > + } > > > > > > } > > > > > > libqos_init(register_virtio_9p_test); > > > > I agree that this is okay for now to avoid inconveniences with nearby 5.2 > > release, but do we agree that this is going to be reverted when 6.0 > > development phase starts? > > > > In 6.0 I would rather handle this by introducing a previously mentioned > > 'loglevel' option for 9p, and asking for the required log data if the local > > tests fail for somebody. I can take care about the loglevel option when 6.0 > > phase starts. > > > > Best regards, > > Christian Schoenebeck > > BTW, if I had to shoot in the dark, then my guess would be that system where > mkdir() failed with ENOTSUPP, does not support xattrs. > > If that's the root cause, then another option would be skipping the 'local' 9p > tests if the host system lacks xattr support, instead of disabling these tests > for all people by default. > Maybe but it's a bit too late now. RC3 is later today. I really must post something that fixes the "make check" breakage this morning. > Best regards, > Christian Schoenebeck > >