From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH v0 05/19] x86/boot/compressed/sev-es: Convert to insn_decode()
Date: Tue, 24 Nov 2020 11:19:38 +0100 [thread overview]
Message-ID: <20201124101952.7909-6-bp@alien8.de> (raw)
In-Reply-To: <20201124101952.7909-1-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
Other than simplifying the code there should be no functional changes
resulting from this.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/boot/compressed/sev-es.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/x86/boot/compressed/sev-es.c b/arch/x86/boot/compressed/sev-es.c
index 954cb2702e23..6bb28170a770 100644
--- a/arch/x86/boot/compressed/sev-es.c
+++ b/arch/x86/boot/compressed/sev-es.c
@@ -79,16 +79,15 @@ static inline void sev_es_wr_ghcb_msr(u64 val)
static enum es_result vc_decode_insn(struct es_em_ctxt *ctxt)
{
char buffer[MAX_INSN_SIZE];
- enum es_result ret;
+ int ret;
memcpy(buffer, (unsigned char *)ctxt->regs->ip, MAX_INSN_SIZE);
- insn_init(&ctxt->insn, buffer, MAX_INSN_SIZE, 1);
- insn_get_length(&ctxt->insn);
+ ret = insn_decode(&ctxt->insn, buffer, MAX_INSN_SIZE, INSN_MODE_64);
+ if (ret < 0)
+ return ES_DECODE_FAILED;
- ret = ctxt->insn.immediate.got ? ES_OK : ES_DECODE_FAILED;
-
- return ret;
+ return ES_OK;
}
static enum es_result vc_write_mem(struct es_em_ctxt *ctxt,
--
2.21.0
next prev parent reply other threads:[~2020-11-24 10:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 10:19 [RFC PATCH v0 00/19] x86/insn: Add an insn_decode() API Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 01/19] x86/insn: Rename insn_decode() to insn_decode_regs() Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 02/19] x86/insn: Add @buf_len param to insn_init() kernel-doc comment Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 03/19] x86/insn: Add an insn_decode() API Borislav Petkov
2020-11-25 16:53 ` Masami Hiramatsu
2020-11-25 19:25 ` Borislav Petkov
2020-11-26 1:37 ` Masami Hiramatsu
2020-11-26 17:50 ` Borislav Petkov
2020-11-27 5:54 ` Masami Hiramatsu
2020-11-24 10:19 ` [RFC PATCH v0 04/19] x86/insn-eval: Handle return values from the decoder Borislav Petkov
2020-11-24 10:19 ` Borislav Petkov [this message]
2020-11-24 10:19 ` [RFC PATCH v0 06/19] perf/x86/intel/ds: Check insn_get_length() retval Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 07/19] perf/x86/intel/ds: Check return values of insn decoder functions Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 08/19] x86/alternative: Use insn_decode() Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 09/19] x86/mce: Convert to insn_decode() Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 10/19] x86/kprobes: " Borislav Petkov
2020-11-25 17:19 ` Masami Hiramatsu
2020-11-24 10:19 ` [RFC PATCH v0 11/19] x86/sev-es: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 12/19] x86/traps: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 13/19] x86/uprobes: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 14/19] x86/tools/insn_decoder_test: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 15/19] tools/objtool: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 16/19] x86/tools/insn_sanity: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 17/19] tools/perf: " Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 18/19] x86/insn: Remove kernel_insn_init() Borislav Petkov
2020-11-24 10:19 ` [RFC PATCH v0 19/19] x86/insn: Make insn_complete() static Borislav Petkov
2020-11-24 17:46 ` [RFC PATCH v0 00/19] x86/insn: Add an insn_decode() API Borislav Petkov
2020-11-25 8:03 ` Masami Hiramatsu
2020-11-27 17:45 ` Andy Lutomirski
2020-11-27 22:35 ` Borislav Petkov
2020-11-29 8:50 ` Masami Hiramatsu
2020-11-30 13:44 ` Borislav Petkov
2020-11-30 17:21 ` Masami Hiramatsu
2020-12-02 18:04 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124101952.7909-6-bp@alien8.de \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhiramat@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.