From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com,
davem@davemloft.net, brouer@redhat.com, echaudro@redhat.com,
john.fastabend@gmail.com, borkmann@iogearbox.net,
alexei.starovoitov@gmail.com
Subject: Re: [PATCH net-next 0/3] mvneta: access skb_shared_info only on last frag
Date: Tue, 24 Nov 2020 23:18:54 +0100 [thread overview]
Message-ID: <20201124221854.GA64351@lore-desk> (raw)
In-Reply-To: <20201124122639.6fa91460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
> On Fri, 20 Nov 2020 18:05:41 +0100 Lorenzo Bianconi wrote:
> > Build skb_shared_info on mvneta_rx_swbm stack and sync it to xdp_buff
> > skb_shared_info area only on the last fragment.
> > Avoid avoid unnecessary xdp_buff initialization in mvneta_rx_swbm routine.
> > This a preliminary series to complete xdp multi-buff in mvneta driver.
>
> Looks fine, but since you need this for XDP multi-buff it should
> probably go via bpf-next, right?
>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Hi Jakub,
thx for the review. Since the series changes networking-only bits I sent it for
net-next, but I agree bpf-next is better.
@Alexei, Daniel: is it fine to merge the series in bpf-next?
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-11-24 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 17:05 [PATCH net-next 0/3] mvneta: access skb_shared_info only on last frag Lorenzo Bianconi
2020-11-20 17:05 ` [PATCH net-next 1/3] net: mvneta: avoid unnecessary xdp_buff initialization Lorenzo Bianconi
2020-11-20 17:05 ` [PATCH net-next 2/3] net: mvneta: move skb_shared_info in mvneta_xdp_put_buff caller Lorenzo Bianconi
2020-11-20 17:05 ` [PATCH net-next 3/3] net: mvneta: alloc skb_shared_info on the mvneta_rx_swbm stack Lorenzo Bianconi
2020-11-20 23:10 ` [PATCH net-next 0/3] mvneta: access skb_shared_info only on last frag Jesse Brandeburg
2020-11-24 20:26 ` Jakub Kicinski
2020-11-24 22:18 ` Lorenzo Bianconi [this message]
2020-11-24 22:25 ` Daniel Borkmann
2020-11-24 22:30 ` Jakub Kicinski
2020-11-24 23:00 ` Daniel Borkmann
2020-11-24 23:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124221854.GA64351@lore-desk \
--to=lorenzo@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.