Re: [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static

[Philip Li <philip.li@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

On Tue, Nov 24, 2020 at 06:08:42PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 24, 2020 at 06:37:55AM -0800, James Smart wrote:
> > On 11/22/2020 12:40 PM, kernel test robot wrote:
> > > 
> > > Fixes: 6b8fbd9b2db0 ("scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: kernel test robot <lkp@intel.com>
> > > ---
> > >   lpfc_nportdisc.c |    2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > index 2a340624bfc99b..0bd7b2048ec065 100644
> > > --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > @@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
> > >    * This routine is only called if we are SLI3, direct connect pt2pt
> > >    * mode and the remote NPort issues the PLOGI after link up.
> > >    */
> > > -void
> > > +static void
> > >   lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> > >   {
> > >   	LPFC_MBOXQ_t *login_mbox;
> > > 
> > 
> > Patch was already accepted:
> > 
> > f7cb0d0945eb scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
> > 
> > Please merge.
> 
> Foolish sparse warnings like this are not needed in stable, I have no
> idea why the kernel test bot keeps trying to do stuff like this.
Got it, Greg, we will avoid reporting this type sparse warning on stable.
If any other sparse warnings are also not that meaningful for stable, kindly
let us know and we will continue improve the testing.

Thanks for your feedback.

> 
> greg k-h
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org