From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C37C5519F for ; Wed, 25 Nov 2020 12:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95A2A2076B for ; Wed, 25 Nov 2020 12:54:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="a7gjzeaQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729438AbgKYMyy (ORCPT ); Wed, 25 Nov 2020 07:54:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:50392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728937AbgKYMyy (ORCPT ); Wed, 25 Nov 2020 07:54:54 -0500 Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71666206E5; Wed, 25 Nov 2020 12:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606308893; bh=NcE3+dgsaNxNTH+nxSaJa3qEfL3YRFoQ6AH2Z6VFQHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a7gjzeaQw8gqaRBaUyZOy5sUR2J1ue2BgtT8wiWE7vpNVO1bp6IDwU1JTPZRkI5fs twyAOO0XzXM1sucrjL22kkzADF4AGdwR5y6k6C5eXgzZ/XyZYqkR2l4h5+EmFr3WSF yiadG3vU7vSo8WZwowyoPcQDIgOs6udvyYjH4zqE= Date: Wed, 25 Nov 2020 14:54:40 +0200 From: Mike Rapoport To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Arnd Bergmann , Andrew Morton , Anshuman Khandual , Arvind Sankar , Baoquan He , Christian Brauner , Dmitry Safonov <0x7f454c46@gmail.com>, Eric Biggers , Geert Uytterhoeven , "Gustavo A. R. Silva" , Herbert Xu , Ira Weiny , Jens Axboe , Joe Perches , Kees Cook , Manish Narani , Oleg Nesterov , Pekka Enberg , "Peter Zijlstra (Intel)" , Randy Dunlap , Rob Herring , Robin Murphy , Sebastian Andrzej Siewior , Stafford Horne , Stefan Asserhall , "Steven Rostedt (VMware)" , Vlastimil Babka Subject: Re: [PATCH] microblaze: Remove noMMU code Message-ID: <20201125125440.GP8537@kernel.org> References: <20201125120739.GO8537@kernel.org> <7217421a-c4de-0bd1-3231-17563e51e3c9@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7217421a-c4de-0bd1-3231-17563e51e3c9@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Wed, Nov 25, 2020 at 01:14:49PM +0100, Michal Simek wrote: > Hi Mike, > > On 25. 11. 20 13:07, Mike Rapoport wrote: > > On Wed, Nov 25, 2020 at 12:30:32PM +0100, Michal Simek wrote: > >> This configuration is obsolete and likely none is really using it. That's > >> why remove it to simplify code. > >> > >> Cc: Arnd Bergmann > >> Signed-off-by: Michal Simek > >> --- > > > > Looks ok to me except several leftovers: > > > > $ git grep CONFIG_MMU arch/microblaze/ > > arch/microblaze/kernel/hw_exception_handler.S: * STACK FRAME STRUCTURE (for CONFIG_MMU=n) > > > > $ git grep -E 'MICROBLAZE_(64|16)K_PAGES' > > arch/microblaze/include/asm/page.h:#if defined(CONFIG_MICROBLAZE_64K_PAGES) > > arch/microblaze/include/asm/page.h:#elif defined(CONFIG_MICROBLAZE_16K_PAGES) > > arch/microblaze/kernel/hw_exception_handler.S:#ifdef CONFIG_MICROBLAZE_64K_PAGES > > arch/microblaze/kernel/hw_exception_handler.S:#elif CONFIG_MICROBLAZE_16K_PAGES > > drivers/net/Kconfig: IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \ > > > > > > I left it there intentionally. First one because there is description in > that comment which references noMMU. If this should be removed the whole > comment should be tuned to make sense. It is better to do it in separate > patch. Makes sense, I just grepped without actually opening the files :) > And second part. I know I removed that Kconfig macros for it but maybe > good to talk about what needs to change to support different page size > for systems with MMU. I'd add a sentence about it to the changelog. > Thanks, > Michal -- Sincerely yours, Mike.