From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Cline Subject: Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list Date: Wed, 25 Nov 2020 14:45:57 -0500 Message-ID: <20201125194557.GC20747@xps13> References: <20201103194912.184413-1-jcline@redhat.com> <20201103194912.184413-3-jcline@redhat.com> <505be3af57c36222564d0790aa8a992b1ea4d287.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <505be3af57c36222564d0790aa8a992b1ea4d287.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Lyude Paul Cc: David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ben Skeggs List-Id: nouveau.vger.kernel.org T24gV2VkLCBOb3YgMjUsIDIwMjAgYXQgMDE6Mzc6MDZQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBPbiBUdWUsIDIwMjAtMTEtMDMgYXQgMTQ6NDkgLTA1MDAsIEplcmVteSBDbGluZSB3cm90 ZToKPiA+IFJhdGhlciB0aGFuIHByb3RlY3RpbmcgdGhlIG5vdXZlYXVfZHJtIGNsaWVudHMgbGlz dCB3aXRoIHRoZSBsb2NrIHdpdGhpbgo+ID4gdGhlICJjbGllbnQiIG5vdXZlYXVfY2xpLCBhZGQg YSBkZWRpY2F0ZWQgbG9jayB0byBzZXJpYWxpemUgYWNjZXNzIHRvCj4gPiB0aGUgbGlzdC4gVGhp cyBpcyBib3RoIGNsZWFyZXIgYW5kIG5lY2Vzc2FyeSB0byBhdm9pZCBsb2NrZGVwIGJlaW5nCj4g PiB1cHNldCB3aXRoIHVzIHdoZW4gd2UgbmVlZCB0byBpdGVyYXRlIHRocm91Z2ggYWxsIHRoZSBj bGllbnRzIGluIHRoZQo+ID4gbGlzdCBhbmQgcG90ZW50aWFsbHkgbG9jayB0aGVpciBtdXRleCwg d2hpY2ggaXMgdGhlIHNhbWUgY2xhc3MgYXMgdGhlCj4gPiBsb2NrIHByb3RlY3RpbmcgdGhlIGVu dGlyZSBsaXN0Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBKZXJlbXkgQ2xpbmUgPGpjbGluZUBy ZWRoYXQuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVf ZHJtLmMgfCA5ICsrKysrLS0tLQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1 X2Rydi5oIHwgNSArKysrKwo+ID4gwqAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91 dmVhdS9ub3V2ZWF1X2RybS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVf ZHJtLmMKPiA+IGluZGV4IDRmZTRkNjY0YzVmMi4uZDE4MmI4NzcyNThhIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kcm0uYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kcm0uYwo+ID4gQEAgLTU1Nyw2ICs1NTcsNyBAQCBu b3V2ZWF1X2RybV9kZXZpY2VfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBudmttX2RiZ29wdChub3V2ZWF1X2RlYnVnLCAiRFJN Iik7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoElOSVRfTElTVF9IRUFEKCZkcm0tPmNsaWVu dHMpOwo+ID4gK8KgwqDCoMKgwqDCoMKgbXV0ZXhfaW5pdCgmZHJtLT5jbGllbnRzX2xvY2spOwo+ IAo+IExvb2tzIGxpa2UgeW91IGZvcmdvdCB0byBob29rIHVwIG11dGV4X2Rlc3Ryb3koKSBzb21l d2hlcmUuIE5vdGUgdGhlcmUncwo+IGFjdHVhbGx5IHBsZW50eSBvZiBjb2RlIGluIG5vdXZlYXUg cmlnaHQgbm93IHRoYXQgZm9yZ2V0cyB0byBkbyB0aGlzLCBidXQgYXQKPiBzb21lIHBvaW50IHdl IHNob3VsZCBwcm9iYWJseSBmaXggdGhhdCBhbmQgYXZvaWQgYWRkaW5nIG1vcmUgc3BvdHMgd2hl cmUgdGhlcmUncwo+IG5vIG11dGV4X2Rlc3Ryb3koKS4KPiAKCkknbSBndWlsdHkgb2YgaGF2aW5n IGxvb2tlZCBhdCB0aGUgZXhpc3RpbmcgbG9ja2luZyBpbml0IGNvZGUgaW4gbm91dmVhdQphbmQg bW9kZWxpbmcgdGhpcyB3b3JrIGFjY29yZGluZ2x5LiBJJ2xsIHNlbmQgb3V0IGEgZml4IGZvciB0 aGlzIHNob3J0bHkKYW5kIGxvb2sgYXQgdGlkeWluZyB1cCB0aGUgcmVzdCBvZiB0aGUgbG9ja3Mg aW4gYSBzZXBhcmF0ZSBzZXJpZXMuClRoYW5rcyEKCj4gPiDCoMKgwqDCoMKgwqDCoMKgc3Bpbl9s b2NrX2luaXQoJmRybS0+dGlsZS5sb2NrKTsKPiA+IMKgCj4gPiDCoMKgwqDCoMKgwqDCoMKgLyog d29ya2Fyb3VuZCBhbiBvZGQgaXNzdWUgb24gbnZjMSBieSBkaXNhYmxpbmcgdGhlIGRldmljZSdz Cj4gPiBAQCAtMTA4OSw5ICsxMDkwLDkgQEAgbm91dmVhdV9kcm1fb3BlbihzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUKPiA+ICpmcHJpdikKPiA+IMKgCj4gPiDCoMKgwqDC oMKgwqDCoMKgZnByaXYtPmRyaXZlcl9wcml2ID0gY2xpOwo+ID4gwqAKPiA+IC3CoMKgwqDCoMKg wqDCoG11dGV4X2xvY2soJmRybS0+Y2xpZW50Lm11dGV4KTsKPiA+ICvCoMKgwqDCoMKgwqDCoG11 dGV4X2xvY2soJmRybS0+Y2xpZW50c19sb2NrKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqBsaXN0X2Fk ZCgmY2xpLT5oZWFkLCAmZHJtLT5jbGllbnRzKTsKPiA+IC3CoMKgwqDCoMKgwqDCoG11dGV4X3Vu bG9jaygmZHJtLT5jbGllbnQubXV0ZXgpOwo+ID4gK8KgwqDCoMKgwqDCoMKgbXV0ZXhfdW5sb2Nr KCZkcm0tPmNsaWVudHNfbG9jayk7Cj4gPiDCoAo+ID4gwqBkb25lOgo+ID4gwqDCoMKgwqDCoMKg wqDCoGlmIChyZXQgJiYgY2xpKSB7Cj4gPiBAQCAtMTExNyw5ICsxMTE4LDkgQEAgbm91dmVhdV9k cm1fcG9zdGNsb3NlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdAo+ID4gZHJtX2ZpbGUg KmZwcml2KQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBub3V2ZWF1X2FiaTE2 X2ZpbmkoY2xpLT5hYmkxNik7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgbXV0ZXhfdW5sb2NrKCZjbGkt Pm11dGV4KTsKPiA+IMKgCj4gPiAtwqDCoMKgwqDCoMKgwqBtdXRleF9sb2NrKCZkcm0tPmNsaWVu dC5tdXRleCk7Cj4gPiArwqDCoMKgwqDCoMKgwqBtdXRleF9sb2NrKCZkcm0tPmNsaWVudHNfbG9j ayk7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgbGlzdF9kZWwoJmNsaS0+aGVhZCk7Cj4gPiAtwqDCoMKg wqDCoMKgwqBtdXRleF91bmxvY2soJmRybS0+Y2xpZW50Lm11dGV4KTsKPiA+ICvCoMKgwqDCoMKg wqDCoG11dGV4X3VubG9jaygmZHJtLT5jbGllbnRzX2xvY2spOwo+ID4gwqAKPiA+IMKgwqDCoMKg wqDCoMKgwqBub3V2ZWF1X2NsaV9maW5pKGNsaSk7Cj4gPiDCoMKgwqDCoMKgwqDCoMKga2ZyZWUo Y2xpKTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Ry di5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZHJ2LmgKPiA+IGluZGV4 IDlkMDRkMWIzNjQzNC4uNTUwZTVmMzM1MTQ2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL25vdXZlYXUvbm91dmVhdV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZl YXUvbm91dmVhdV9kcnYuaAo+ID4gQEAgLTE0MSw2ICsxNDEsMTEgQEAgc3RydWN0IG5vdXZlYXVf ZHJtIHsKPiA+IMKgCj4gPiDCoMKgwqDCoMKgwqDCoMKgc3RydWN0IGxpc3RfaGVhZCBjbGllbnRz Owo+ID4gwqAKPiA+ICvCoMKgwqDCoMKgwqDCoC8qKgo+ID4gK8KgwqDCoMKgwqDCoMKgICogQGNs aWVudHNfbG9jazogUHJvdGVjdHMgYWNjZXNzIHRvIHRoZSBAY2xpZW50cyBsaXN0IG9mICZzdHJ1 Y3QKPiA+IG5vdXZlYXVfY2xpLgo+ID4gK8KgwqDCoMKgwqDCoMKgICovCj4gPiArwqDCoMKgwqDC oMKgwqBzdHJ1Y3QgbXV0ZXggY2xpZW50c19sb2NrOwo+ID4gKwo+ID4gwqDCoMKgwqDCoMKgwqDC oHU4IG9sZF9wbV9jYXA7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCB7Cj4gCj4g LS0gCj4gU2luY2VyZWx5LAo+ICAgIEx5dWRlIFBhdWwgKHNoZS9oZXIpCj4gICAgU29mdHdhcmUg RW5naW5lZXIgYXQgUmVkIEhhdAo+ICAgIAo+IE5vdGU6IEkgZGVhbCB3aXRoIGEgbG90IG9mIGVt YWlscyBhbmQgaGF2ZSBhIGxvdCBvZiBidWdzIG9uIG15IHBsYXRlLiBJZiB5b3UndmUKPiBhc2tl ZCBtZSBhIHF1ZXN0aW9uLCBhcmUgd2FpdGluZyBmb3IgYSByZXZpZXcvbWVyZ2Ugb24gYSBwYXRj aCwgZXRjLiBhbmQgSQo+IGhhdmVuJ3QgcmVzcG9uZGVkIGluIGEgd2hpbGUsIHBsZWFzZSBmZWVs IGZyZWUgdG8gc2VuZCBtZSBhbm90aGVyIGVtYWlsIHRvIGNoZWNrCj4gb24gbXkgc3RhdHVzLiBJ IGRvbid0IGJpdGUhCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E26C56201 for ; Wed, 25 Nov 2020 19:46:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6476A207BB for ; Wed, 25 Nov 2020 19:46:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z5yLfhR/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6476A207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB2FC6E905; Wed, 25 Nov 2020 19:46:04 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 919286E905 for ; Wed, 25 Nov 2020 19:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606333562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e69pYqK6LdWzFPvgW/MsEcbIzlfutA0tPozCsp8JsBA=; b=Z5yLfhR/UyjAOAb+LalxmEM+GyGLj+jaQni/5BiUEwRoxnuxPIkylY4pGkB5vypsc3WrZo VCOhR2HBJgTOhcm6wZABH/57z6VrEu/Yn3/sN4oWjDNjsji1WHKpE2RRwlOsVEkTMnI7A5 QsA6e5M8uSSRKUmSdTYp8LZ6OGr2sy0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-WGS_dGdNNaCKMriNL0ZJAw-1; Wed, 25 Nov 2020 14:46:00 -0500 X-MC-Unique: WGS_dGdNNaCKMriNL0ZJAw-1 Received: by mail-qv1-f70.google.com with SMTP id t14so3176328qvc.13 for ; Wed, 25 Nov 2020 11:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=e69pYqK6LdWzFPvgW/MsEcbIzlfutA0tPozCsp8JsBA=; b=PUiD5/sCngncwf+icdn79UBm3zelzYa8o3DpS2hbZ0iqXqLmqFmgi2bLSfe5CqsVxN Pa9pNG3+bOjiNLSVoBPbrZenUrPVVUlue/ICdfLhlESr7/c9QraLlCUe+doQQCnAPYIt Z6zwckfdxvFn9cht1toGx+4vlR73Feuf9z43U+nRj2FtTH9wEsqCyC7megCRd6ve1LQv p1U+9DOdVy3Pp+S6daQc6LwxhgzAKNmv50Gqr8Do9X+PTPZGnWQHwXv9mH+1RuCt51GS jQD4P2JouSb1mD3xHn/+9IwwDc68H8uCF4IvbaGNr0mcWtcz4urNw+HiCTnyjdWuQ6+M oj6g== X-Gm-Message-State: AOAM533YNrJiu+dQGAi6Dt3mHsBCUm1pLRJKio6ryoMZQ7T/o/f8uTxC QMMYb6N76z9h1PSdVnX6btzOaLmvJUXzGf5A2TbMofxta8hZoZhDfJhghZdW+oj6Zzca+X3VwKd 7yyovA2+H5tNg9dbOsXvY2AkIDFoi X-Received: by 2002:a37:e40e:: with SMTP id y14mr512135qkf.356.1606333560285; Wed, 25 Nov 2020 11:46:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJpcF9jhzLh2FJKyoAjd88LJ5nR2LjSeUm7SVmZM9+VDLLKO7LmCId29U3QTbFbLzEqKyIfA== X-Received: by 2002:a37:e40e:: with SMTP id y14mr512121qkf.356.1606333560000; Wed, 25 Nov 2020 11:46:00 -0800 (PST) Received: from xps13 ([136.56.20.95]) by smtp.gmail.com with ESMTPSA id h142sm337753qke.104.2020.11.25.11.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 11:45:59 -0800 (PST) Date: Wed, 25 Nov 2020 14:45:57 -0500 From: Jeremy Cline To: Lyude Paul Subject: Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list Message-ID: <20201125194557.GC20747@xps13> References: <20201103194912.184413-1-jcline@redhat.com> <20201103194912.184413-3-jcline@redhat.com> <505be3af57c36222564d0790aa8a992b1ea4d287.camel@redhat.com> MIME-Version: 1.0 In-Reply-To: <505be3af57c36222564d0790aa8a992b1ea4d287.camel@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jcline@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBOb3YgMjUsIDIwMjAgYXQgMDE6Mzc6MDZQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBPbiBUdWUsIDIwMjAtMTEtMDMgYXQgMTQ6NDkgLTA1MDAsIEplcmVteSBDbGluZSB3cm90 ZToKPiA+IFJhdGhlciB0aGFuIHByb3RlY3RpbmcgdGhlIG5vdXZlYXVfZHJtIGNsaWVudHMgbGlz dCB3aXRoIHRoZSBsb2NrIHdpdGhpbgo+ID4gdGhlICJjbGllbnQiIG5vdXZlYXVfY2xpLCBhZGQg YSBkZWRpY2F0ZWQgbG9jayB0byBzZXJpYWxpemUgYWNjZXNzIHRvCj4gPiB0aGUgbGlzdC4gVGhp cyBpcyBib3RoIGNsZWFyZXIgYW5kIG5lY2Vzc2FyeSB0byBhdm9pZCBsb2NrZGVwIGJlaW5nCj4g PiB1cHNldCB3aXRoIHVzIHdoZW4gd2UgbmVlZCB0byBpdGVyYXRlIHRocm91Z2ggYWxsIHRoZSBj bGllbnRzIGluIHRoZQo+ID4gbGlzdCBhbmQgcG90ZW50aWFsbHkgbG9jayB0aGVpciBtdXRleCwg d2hpY2ggaXMgdGhlIHNhbWUgY2xhc3MgYXMgdGhlCj4gPiBsb2NrIHByb3RlY3RpbmcgdGhlIGVu dGlyZSBsaXN0Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBKZXJlbXkgQ2xpbmUgPGpjbGluZUBy ZWRoYXQuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVf ZHJtLmMgfCA5ICsrKysrLS0tLQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1 X2Rydi5oIHwgNSArKysrKwo+ID4gwqAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91 dmVhdS9ub3V2ZWF1X2RybS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVf ZHJtLmMKPiA+IGluZGV4IDRmZTRkNjY0YzVmMi4uZDE4MmI4NzcyNThhIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kcm0uYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kcm0uYwo+ID4gQEAgLTU1Nyw2ICs1NTcsNyBAQCBu b3V2ZWF1X2RybV9kZXZpY2VfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBudmttX2RiZ29wdChub3V2ZWF1X2RlYnVnLCAiRFJN Iik7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoElOSVRfTElTVF9IRUFEKCZkcm0tPmNsaWVu dHMpOwo+ID4gK8KgwqDCoMKgwqDCoMKgbXV0ZXhfaW5pdCgmZHJtLT5jbGllbnRzX2xvY2spOwo+ IAo+IExvb2tzIGxpa2UgeW91IGZvcmdvdCB0byBob29rIHVwIG11dGV4X2Rlc3Ryb3koKSBzb21l d2hlcmUuIE5vdGUgdGhlcmUncwo+IGFjdHVhbGx5IHBsZW50eSBvZiBjb2RlIGluIG5vdXZlYXUg cmlnaHQgbm93IHRoYXQgZm9yZ2V0cyB0byBkbyB0aGlzLCBidXQgYXQKPiBzb21lIHBvaW50IHdl IHNob3VsZCBwcm9iYWJseSBmaXggdGhhdCBhbmQgYXZvaWQgYWRkaW5nIG1vcmUgc3BvdHMgd2hl cmUgdGhlcmUncwo+IG5vIG11dGV4X2Rlc3Ryb3koKS4KPiAKCkknbSBndWlsdHkgb2YgaGF2aW5n IGxvb2tlZCBhdCB0aGUgZXhpc3RpbmcgbG9ja2luZyBpbml0IGNvZGUgaW4gbm91dmVhdQphbmQg bW9kZWxpbmcgdGhpcyB3b3JrIGFjY29yZGluZ2x5LiBJJ2xsIHNlbmQgb3V0IGEgZml4IGZvciB0 aGlzIHNob3J0bHkKYW5kIGxvb2sgYXQgdGlkeWluZyB1cCB0aGUgcmVzdCBvZiB0aGUgbG9ja3Mg aW4gYSBzZXBhcmF0ZSBzZXJpZXMuClRoYW5rcyEKCj4gPiDCoMKgwqDCoMKgwqDCoMKgc3Bpbl9s b2NrX2luaXQoJmRybS0+dGlsZS5sb2NrKTsKPiA+IMKgCj4gPiDCoMKgwqDCoMKgwqDCoMKgLyog d29ya2Fyb3VuZCBhbiBvZGQgaXNzdWUgb24gbnZjMSBieSBkaXNhYmxpbmcgdGhlIGRldmljZSdz Cj4gPiBAQCAtMTA4OSw5ICsxMDkwLDkgQEAgbm91dmVhdV9kcm1fb3BlbihzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUKPiA+ICpmcHJpdikKPiA+IMKgCj4gPiDCoMKgwqDC oMKgwqDCoMKgZnByaXYtPmRyaXZlcl9wcml2ID0gY2xpOwo+ID4gwqAKPiA+IC3CoMKgwqDCoMKg wqDCoG11dGV4X2xvY2soJmRybS0+Y2xpZW50Lm11dGV4KTsKPiA+ICvCoMKgwqDCoMKgwqDCoG11 dGV4X2xvY2soJmRybS0+Y2xpZW50c19sb2NrKTsKPiA+IMKgwqDCoMKgwqDCoMKgwqBsaXN0X2Fk ZCgmY2xpLT5oZWFkLCAmZHJtLT5jbGllbnRzKTsKPiA+IC3CoMKgwqDCoMKgwqDCoG11dGV4X3Vu bG9jaygmZHJtLT5jbGllbnQubXV0ZXgpOwo+ID4gK8KgwqDCoMKgwqDCoMKgbXV0ZXhfdW5sb2Nr KCZkcm0tPmNsaWVudHNfbG9jayk7Cj4gPiDCoAo+ID4gwqBkb25lOgo+ID4gwqDCoMKgwqDCoMKg wqDCoGlmIChyZXQgJiYgY2xpKSB7Cj4gPiBAQCAtMTExNyw5ICsxMTE4LDkgQEAgbm91dmVhdV9k cm1fcG9zdGNsb3NlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdAo+ID4gZHJtX2ZpbGUg KmZwcml2KQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBub3V2ZWF1X2FiaTE2 X2ZpbmkoY2xpLT5hYmkxNik7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgbXV0ZXhfdW5sb2NrKCZjbGkt Pm11dGV4KTsKPiA+IMKgCj4gPiAtwqDCoMKgwqDCoMKgwqBtdXRleF9sb2NrKCZkcm0tPmNsaWVu dC5tdXRleCk7Cj4gPiArwqDCoMKgwqDCoMKgwqBtdXRleF9sb2NrKCZkcm0tPmNsaWVudHNfbG9j ayk7Cj4gPiDCoMKgwqDCoMKgwqDCoMKgbGlzdF9kZWwoJmNsaS0+aGVhZCk7Cj4gPiAtwqDCoMKg wqDCoMKgwqBtdXRleF91bmxvY2soJmRybS0+Y2xpZW50Lm11dGV4KTsKPiA+ICvCoMKgwqDCoMKg wqDCoG11dGV4X3VubG9jaygmZHJtLT5jbGllbnRzX2xvY2spOwo+ID4gwqAKPiA+IMKgwqDCoMKg wqDCoMKgwqBub3V2ZWF1X2NsaV9maW5pKGNsaSk7Cj4gPiDCoMKgwqDCoMKgwqDCoMKga2ZyZWUo Y2xpKTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Ry di5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZHJ2LmgKPiA+IGluZGV4 IDlkMDRkMWIzNjQzNC4uNTUwZTVmMzM1MTQ2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL25vdXZlYXUvbm91dmVhdV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZl YXUvbm91dmVhdV9kcnYuaAo+ID4gQEAgLTE0MSw2ICsxNDEsMTEgQEAgc3RydWN0IG5vdXZlYXVf ZHJtIHsKPiA+IMKgCj4gPiDCoMKgwqDCoMKgwqDCoMKgc3RydWN0IGxpc3RfaGVhZCBjbGllbnRz Owo+ID4gwqAKPiA+ICvCoMKgwqDCoMKgwqDCoC8qKgo+ID4gK8KgwqDCoMKgwqDCoMKgICogQGNs aWVudHNfbG9jazogUHJvdGVjdHMgYWNjZXNzIHRvIHRoZSBAY2xpZW50cyBsaXN0IG9mICZzdHJ1 Y3QKPiA+IG5vdXZlYXVfY2xpLgo+ID4gK8KgwqDCoMKgwqDCoMKgICovCj4gPiArwqDCoMKgwqDC oMKgwqBzdHJ1Y3QgbXV0ZXggY2xpZW50c19sb2NrOwo+ID4gKwo+ID4gwqDCoMKgwqDCoMKgwqDC oHU4IG9sZF9wbV9jYXA7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCB7Cj4gCj4g LS0gCj4gU2luY2VyZWx5LAo+ICAgIEx5dWRlIFBhdWwgKHNoZS9oZXIpCj4gICAgU29mdHdhcmUg RW5naW5lZXIgYXQgUmVkIEhhdAo+ICAgIAo+IE5vdGU6IEkgZGVhbCB3aXRoIGEgbG90IG9mIGVt YWlscyBhbmQgaGF2ZSBhIGxvdCBvZiBidWdzIG9uIG15IHBsYXRlLiBJZiB5b3UndmUKPiBhc2tl ZCBtZSBhIHF1ZXN0aW9uLCBhcmUgd2FpdGluZyBmb3IgYSByZXZpZXcvbWVyZ2Ugb24gYSBwYXRj aCwgZXRjLiBhbmQgSQo+IGhhdmVuJ3QgcmVzcG9uZGVkIGluIGEgd2hpbGUsIHBsZWFzZSBmZWVs IGZyZWUgdG8gc2VuZCBtZSBhbm90aGVyIGVtYWlsIHRvIGNoZWNrCj4gb24gbXkgc3RhdHVzLiBJ IGRvbid0IGJpdGUhCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FC6C56202 for ; Wed, 25 Nov 2020 19:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C741207BC for ; Wed, 25 Nov 2020 19:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z5yLfhR/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728940AbgKYTqF (ORCPT ); Wed, 25 Nov 2020 14:46:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29970 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728749AbgKYTqE (ORCPT ); Wed, 25 Nov 2020 14:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606333562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e69pYqK6LdWzFPvgW/MsEcbIzlfutA0tPozCsp8JsBA=; b=Z5yLfhR/UyjAOAb+LalxmEM+GyGLj+jaQni/5BiUEwRoxnuxPIkylY4pGkB5vypsc3WrZo VCOhR2HBJgTOhcm6wZABH/57z6VrEu/Yn3/sN4oWjDNjsji1WHKpE2RRwlOsVEkTMnI7A5 QsA6e5M8uSSRKUmSdTYp8LZ6OGr2sy0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-FUD3H0mYOLGrNuQgqdQ15w-1; Wed, 25 Nov 2020 14:46:01 -0500 X-MC-Unique: FUD3H0mYOLGrNuQgqdQ15w-1 Received: by mail-qk1-f200.google.com with SMTP id q25so3221068qkm.17 for ; Wed, 25 Nov 2020 11:46:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=e69pYqK6LdWzFPvgW/MsEcbIzlfutA0tPozCsp8JsBA=; b=KnFoL6i0vFRcNA/PXo/bAByI1hWmxPA+SBDfX3CC8Hiu9p8aUeTsVgX6tuq0quyTsr BlcM2exEW2rs/etayD3l5sDzVU+ZjV1ZMweFYuvR/s9KT5rOeni5k9YERNAoDzsexYHM 6PHJe24+FG4WAxwIjuGa/YLrcqGAqkpYOxpnqs67wadqYWOOPj53blGvOn1MoZdYg1ko Z4XMbIzglP3rjZio/2P7bHLHJ8zk24Q4oQQXhCYDhgxCIWWke1ARkuuXchWgXG3fKbXc b1dkthTo0AGgTcHRFsBq1kvojycBq+4HVpl7uPUgplZJQ4YzLO/I1FPU/dgD7BKPwe4B g/Uw== X-Gm-Message-State: AOAM533auyFNxNVFd6fh9pof02cdXHwpTi659uEt4hWXxFgYtJQETG45 5aMIw872fYm9Opb4XzwBdsKFeDu5QthlqgWy5qCrStkebtm5bd+t4cUzH3SLnbh9wDZv0TOk3s4 XAswxrs7+qsUf8GdMyG/GNzpe X-Received: by 2002:a37:e40e:: with SMTP id y14mr512139qkf.356.1606333560285; Wed, 25 Nov 2020 11:46:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJpcF9jhzLh2FJKyoAjd88LJ5nR2LjSeUm7SVmZM9+VDLLKO7LmCId29U3QTbFbLzEqKyIfA== X-Received: by 2002:a37:e40e:: with SMTP id y14mr512121qkf.356.1606333560000; Wed, 25 Nov 2020 11:46:00 -0800 (PST) Received: from xps13 ([136.56.20.95]) by smtp.gmail.com with ESMTPSA id h142sm337753qke.104.2020.11.25.11.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 11:45:59 -0800 (PST) Date: Wed, 25 Nov 2020 14:45:57 -0500 From: Jeremy Cline To: Lyude Paul Cc: Ben Skeggs , Karol Herbst , David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list Message-ID: <20201125194557.GC20747@xps13> References: <20201103194912.184413-1-jcline@redhat.com> <20201103194912.184413-3-jcline@redhat.com> <505be3af57c36222564d0790aa8a992b1ea4d287.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <505be3af57c36222564d0790aa8a992b1ea4d287.camel@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 25, 2020 at 01:37:06PM -0500, Lyude Paul wrote: > On Tue, 2020-11-03 at 14:49 -0500, Jeremy Cline wrote: > > Rather than protecting the nouveau_drm clients list with the lock within > > the "client" nouveau_cli, add a dedicated lock to serialize access to > > the list. This is both clearer and necessary to avoid lockdep being > > upset with us when we need to iterate through all the clients in the > > list and potentially lock their mutex, which is the same class as the > > lock protecting the entire list. > > > > Signed-off-by: Jeremy Cline > > --- > >  drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +++++---- > >  drivers/gpu/drm/nouveau/nouveau_drv.h | 5 +++++ > >  2 files changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c > > b/drivers/gpu/drm/nouveau/nouveau_drm.c > > index 4fe4d664c5f2..d182b877258a 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > > @@ -557,6 +557,7 @@ nouveau_drm_device_init(struct drm_device *dev) > >                 nvkm_dbgopt(nouveau_debug, "DRM"); > >   > >         INIT_LIST_HEAD(&drm->clients); > > +       mutex_init(&drm->clients_lock); > > Looks like you forgot to hook up mutex_destroy() somewhere. Note there's > actually plenty of code in nouveau right now that forgets to do this, but at > some point we should probably fix that and avoid adding more spots where there's > no mutex_destroy(). > I'm guilty of having looked at the existing locking init code in nouveau and modeling this work accordingly. I'll send out a fix for this shortly and look at tidying up the rest of the locks in a separate series. Thanks! > >         spin_lock_init(&drm->tile.lock); > >   > >         /* workaround an odd issue on nvc1 by disabling the device's > > @@ -1089,9 +1090,9 @@ nouveau_drm_open(struct drm_device *dev, struct drm_file > > *fpriv) > >   > >         fpriv->driver_priv = cli; > >   > > -       mutex_lock(&drm->client.mutex); > > +       mutex_lock(&drm->clients_lock); > >         list_add(&cli->head, &drm->clients); > > -       mutex_unlock(&drm->client.mutex); > > +       mutex_unlock(&drm->clients_lock); > >   > >  done: > >         if (ret && cli) { > > @@ -1117,9 +1118,9 @@ nouveau_drm_postclose(struct drm_device *dev, struct > > drm_file *fpriv) > >                 nouveau_abi16_fini(cli->abi16); > >         mutex_unlock(&cli->mutex); > >   > > -       mutex_lock(&drm->client.mutex); > > +       mutex_lock(&drm->clients_lock); > >         list_del(&cli->head); > > -       mutex_unlock(&drm->client.mutex); > > +       mutex_unlock(&drm->clients_lock); > >   > >         nouveau_cli_fini(cli); > >         kfree(cli); > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h > > b/drivers/gpu/drm/nouveau/nouveau_drv.h > > index 9d04d1b36434..550e5f335146 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_drv.h > > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.h > > @@ -141,6 +141,11 @@ struct nouveau_drm { > >   > >         struct list_head clients; > >   > > +       /** > > +        * @clients_lock: Protects access to the @clients list of &struct > > nouveau_cli. > > +        */ > > +       struct mutex clients_lock; > > + > >         u8 old_pm_cap; > >   > >         struct { > > -- > Sincerely, > Lyude Paul (she/her) > Software Engineer at Red Hat > > Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've > asked me a question, are waiting for a review/merge on a patch, etc. and I > haven't responded in a while, please feel free to send me another email to check > on my status. I don't bite! >