From: Andrew Lunn <andrew@lunn.ch>
To: George McCollister <george.mccollister@gmail.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller " <davem@davemloft.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer
Date: Wed, 25 Nov 2020 21:34:29 +0100 [thread overview]
Message-ID: <20201125203429.GF2073444@lunn.ch> (raw)
In-Reply-To: <20201125193740.36825-2-george.mccollister@gmail.com>
> +static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct net_device *dev,
> + struct packet_type *pt)
> +{
> + int source_port;
> + u8 *trailer;
> +
> + if (skb_linearize(skb))
> + return NULL;
Something for Vladimir:
Could this linearise be moved into the core, depending on the
tail_tag?
> + if (pskb_trim_rcsum(skb, skb->len - 1))
> + return NULL;
And the overhead is also in dsa_devlink_ops, so maybe this can be
moved as well?
Andrew
next prev parent reply other threads:[~2020-11-25 20:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:37 [PATCH net-next v2 0/3] Arrow SpeedChips XRS700x DSA Driver George McCollister
2020-11-25 19:37 ` [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer George McCollister
2020-11-25 20:34 ` Andrew Lunn [this message]
2020-11-26 13:50 ` Vladimir Oltean
2020-11-26 14:01 ` Andrew Lunn
2020-11-26 14:28 ` Vladimir Oltean
2020-11-25 20:34 ` Andrew Lunn
2020-11-26 1:31 ` Florian Fainelli
2020-11-25 19:37 ` [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver George McCollister
2020-11-26 1:42 ` Jakub Kicinski
2020-11-26 2:25 ` George McCollister
2020-11-26 13:24 ` Vladimir Oltean
2020-11-26 17:56 ` Vladimir Oltean
2020-11-26 19:07 ` George McCollister
2020-11-26 22:05 ` Vladimir Oltean
2020-11-27 18:35 ` Jakub Kicinski
[not found] ` <CAFSKS=MAdnR2jzmkQfTnSQZ7GY5x5KJE=oeqPCQdbZdf5n=4ZQ@mail.gmail.com>
2020-11-27 19:50 ` Vladimir Oltean
2020-11-27 20:58 ` George McCollister
2020-11-27 21:37 ` Jakub Kicinski
2020-11-27 22:42 ` Vladimir Oltean
2020-11-27 23:21 ` Vladimir Oltean
2020-11-27 23:51 ` Jakub Kicinski
2020-11-27 23:30 ` Andrew Lunn
2020-11-27 23:39 ` Vladimir Oltean
2020-11-27 23:56 ` Jakub Kicinski
2020-11-28 1:45 ` Vladimir Oltean
2020-11-28 0:02 ` Vladimir Oltean
2020-11-28 0:39 ` Andrew Lunn
2020-11-28 1:41 ` Vladimir Oltean
2020-11-28 2:15 ` Jakub Kicinski
2020-11-30 16:52 ` George McCollister
2020-11-30 23:50 ` Vladimir Oltean
2020-11-30 23:58 ` George McCollister
2020-12-01 0:19 ` Vladimir Oltean
2020-11-27 20:47 ` Andrew Lunn
2020-11-27 21:13 ` Jakub Kicinski
2020-11-27 21:23 ` Vladimir Oltean
2020-11-27 21:36 ` Andrew Lunn
2020-12-02 0:28 ` Vladimir Oltean
2020-12-02 0:54 ` Jakub Kicinski
2020-11-27 22:03 ` Jakub Kicinski
2020-11-27 21:32 ` Andrew Lunn
2020-11-27 22:14 ` Jakub Kicinski
2020-11-27 22:46 ` Andrew Lunn
2020-11-25 19:37 ` [PATCH net-next v2 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches George McCollister
2020-11-26 1:30 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125203429.GF2073444@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.